All of lore.kernel.org
 help / color / mirror / Atom feed
From: Levin Du <djw@t-chip.com.cn>
To: "Jonathan A. Kollasch" <jakllsch@kollasch.net>
Cc: linux-rockchip@lists.infradead.org,
	linux-amarula@amarulasolutions.com, u-boot@lists.denx.de
Subject: Re: [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig【请注意，邮件由u-boot-bounces@lists.denx.de代发】
Date: Tue, 05 Nov 2019 10:11:14 +0800	[thread overview]
Message-ID: <87k18fqdh9.fsf@archiso.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20191102122808.v5nnb67gfwq24rae@tazenda.kollasch.net> (Jonathan A. Kollasch's message of "Sat, 2 Nov 2019 07:28:08 -0500")


The mainline uses 'rk3399-*', so there're rk3399-firefly.dts,
rk3399-roc-pc.dts, rk3399-khadas-edge.dts, etc. Shall we follow the kernel
convention, or add another roc-pc-rk3399 to the matrix? I prefer to keep it as
it is.


"Jonathan A. Kollasch" <jakllsch@kollasch.net> writes:

> On Sat, Nov 02, 2019 at 10:19:02AM +0530, Jagan Teki wrote:
>> roc-rk3399-pc_defconfig is committed in below
>> 
>> commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:
>
>> Add ROC-RK3399-PC support")
>> 
>> which doesn't follow the existing defconfigs on rk3399.
>> 
>> So, rename as followed with other rk3399 defconfigs.
>> 
>> Cc: Levin Du <djw@t-chip.com.cn>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>
> This strikes me as wrong, as the existing name is the actual name of the
> board.
>
> https://libre.computer/products/boards/roc-rk3399-pc/
>
> 	Jonathan Kollasch
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
-- 
Levin Du


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

WARNING: multiple messages have this Message-ID (diff)
From: Levin Du <djw@t-chip.com.cn>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig【请注意，邮件由u-boot-bounces@lists.denx.de代发】
Date: Tue, 05 Nov 2019 10:11:14 +0800	[thread overview]
Message-ID: <87k18fqdh9.fsf@archiso.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20191102122808.v5nnb67gfwq24rae@tazenda.kollasch.net> (Jonathan A. Kollasch's message of "Sat, 2 Nov 2019 07:28:08 -0500")


The mainline uses 'rk3399-*', so there're rk3399-firefly.dts,
rk3399-roc-pc.dts, rk3399-khadas-edge.dts, etc. Shall we follow the kernel
convention, or add another roc-pc-rk3399 to the matrix? I prefer to keep it as
it is.


"Jonathan A. Kollasch" <jakllsch@kollasch.net> writes:

> On Sat, Nov 02, 2019 at 10:19:02AM +0530, Jagan Teki wrote:
>> roc-rk3399-pc_defconfig is committed in below
>> 
>> commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:
>
>> Add ROC-RK3399-PC support")
>> 
>> which doesn't follow the existing defconfigs on rk3399.
>> 
>> So, rename as followed with other rk3399 defconfigs.
>> 
>> Cc: Levin Du <djw@t-chip.com.cn>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>
> This strikes me as wrong, as the existing name is the actual name of the
> board.
>
> https://libre.computer/products/boards/roc-rk3399-pc/
>
> 	Jonathan Kollasch
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
-- 
Levin Du

  reply	other threads:[~2019-11-05  2:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02  4:49 [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig Jagan Teki
2019-11-02  4:49 ` [U-Boot] " Jagan Teki
2019-11-02 12:28 ` Jonathan A. Kollasch
2019-11-02 12:28   ` [U-Boot] " Jonathan A. Kollasch
2019-11-05  2:11   ` Levin Du [this message]
2019-11-05  2:11     ` [U-Boot] [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig【请注意，邮件由u-boot-bounces@lists.denx.de代发】 Levin Du
2019-11-04  1:41 ` [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig djw
2019-11-04  1:41   ` [U-Boot] " djw at archiso.i-did-not-set--mail-host-address--so-tickle-me
2019-11-13  9:13 ` [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig【请注意，邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang
2019-11-13  9:13   ` [U-Boot] " Kever Yang
     [not found]   ` <fd21fa79-142f-00b9-f3df-8dc43372cb20-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2019-11-18  3:04     ` Kever Yang
2019-11-18  3:04       ` [U-Boot] " Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k18fqdh9.fsf@archiso.i-did-not-set--mail-host-address--so-tickle-me \
    --to=djw@t-chip.com.cn \
    --cc=jakllsch@kollasch.net \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.