ppc85xx_basic_defconfig is buggy ?

ppc85xx_basic_defconfig is buggy ?

[Christophe Leroy]

ppc85xx_basic_defconfig doesn't not select CONFIG_PPC_85xx.

Is that expected ?

Christophe

Re: ppc85xx_basic_defconfig is buggy ?

[Michael Ellerman]

Christophe Leroy <christophe.leroy@c-s.fr> writes:
> ppc85xx_basic_defconfig doesn't not select CONFIG_PPC_85xx.

You mean arch/powerpc/configs/mpc85xx_basic_defconfig presumably.

> Is that expected ?

Yeah it is expected.

It's not intended to be a full defconfig, it's used as a fragment and
merged with other configs, see arch/powerpc/Makefile:

  PHONY += mpc85xx_defconfig
  mpc85xx_defconfig:
  	$(call merge_into_defconfig,mpc85xx_basic_defconfig,\
  		85xx-32bit 85xx-hw fsl-emb-nonhw)

Where 85xx-32bit.config is:

  CONFIG_HIGHMEM=y
  CONFIG_KEXEC=y
  CONFIG_PPC_85xx=y
  CONFIG_PROC_KCORE=y
  CONFIG_PHYS_64BIT=y

So that's where PPC_85xx gets set.

But it's confusing that mpc85xx_basic_defconfig is named "foo_defconfig"
but is not actually a proper defconfig. We should rename it to
mpc85xx_basic.config to make it clearer that it's a fragment. I'll do a
patch.

cheers