All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	kernel-hardening@lists.openwall.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
	Tycho Andersen <tycho@tycho.ws>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [RESEND] rsi: Remove stack VLA usage
Date: Wed, 14 Mar 2018 11:11:12 +0200	[thread overview]
Message-ID: <87k1uf6mz3.fsf@codeaurora.org> (raw)
In-Reply-To: <20180314021151.GA11666@eros> (Tobin C. Harding's message of "Wed, 14 Mar 2018 13:11:51 +1100")

"Tobin C. Harding" <me@tobin.cc> writes:

> On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote:
>> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <me@tobin.cc> wrote:
>> > On Mon, Mar 12, 2018 at 09:46:06AM +0000, Kalle Valo wrote:
>> >> tcharding <me@tobin.cc> wrote:
>>=20
>> I'm pretty much sure it depends on the original email headers, like
>> above ^^^ =E2=80=94 no name.
>> Perhaps git config on your side should be done.
>
> Thanks for the suggestion Andy but the 'tcharding' as the name was
> munged by either Kalle or patchwork.  I'm guessing patchwork.

You guessed corretly, patchwork is here to blame. I sent my "please
rebase" mail earlier in this thread using my custom patchwork client
script (pwcli) which takes the name and address from patchwork.

Andy, this is definitely a bug in patchwork and I have seen this issue
multiple times already. I have understood that it has been fixed in a
recent version but patchwork.kernel.org is still running an old version.
In the original mail Tobin did have the correct From header which can be
checked from the headers in patch page[1]:

From: "Tobin C. Harding" <me@tobin.cc>

[1] https://patchwork.kernel.org/patch/10274983/

--=20
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	 kernel-hardening@lists.openwall.com,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 netdev <netdev@vger.kernel.org>,
	 <linux-wireless@vger.kernel.org>,
	 Tycho Andersen <tycho@tycho.ws>,
	 Kees Cook <keescook@chromium.org>
Subject: Re: [RESEND] rsi: Remove stack VLA usage
Date: Wed, 14 Mar 2018 11:11:12 +0200	[thread overview]
Message-ID: <87k1uf6mz3.fsf@codeaurora.org> (raw)
In-Reply-To: <20180314021151.GA11666@eros> (Tobin C. Harding's message of "Wed, 14 Mar 2018 13:11:51 +1100")

"Tobin C. Harding" <me@tobin.cc> writes:

> On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote:
>> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <me@tobin.cc> wrote:
>> > On Mon, Mar 12, 2018 at 09:46:06AM +0000, Kalle Valo wrote:
>> >> tcharding <me@tobin.cc> wrote:
>> 
>> I'm pretty much sure it depends on the original email headers, like
>> above ^^^ — no name.
>> Perhaps git config on your side should be done.
>
> Thanks for the suggestion Andy but the 'tcharding' as the name was
> munged by either Kalle or patchwork.  I'm guessing patchwork.

You guessed corretly, patchwork is here to blame. I sent my "please
rebase" mail earlier in this thread using my custom patchwork client
script (pwcli) which takes the name and address from patchwork.

Andy, this is definitely a bug in patchwork and I have seen this issue
multiple times already. I have understood that it has been fixed in a
recent version but patchwork.kernel.org is still running an old version.
In the original mail Tobin did have the correct From header which can be
checked from the headers in patch page[1]:

From: "Tobin C. Harding" <me@tobin.cc>

[1] https://patchwork.kernel.org/patch/10274983/

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	kernel-hardening@lists.openwall.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
	Tycho Andersen <tycho@tycho.ws>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [RESEND] rsi: Remove stack VLA usage
Date: Wed, 14 Mar 2018 11:11:12 +0200	[thread overview]
Message-ID: <87k1uf6mz3.fsf@codeaurora.org> (raw)
In-Reply-To: <20180314021151.GA11666@eros> (Tobin C. Harding's message of "Wed, 14 Mar 2018 13:11:51 +1100")

"Tobin C. Harding" <me@tobin.cc> writes:

> On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote:
>> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <me@tobin.cc> wrote:
>> > On Mon, Mar 12, 2018 at 09:46:06AM +0000, Kalle Valo wrote:
>> >> tcharding <me@tobin.cc> wrote:
>> 
>> I'm pretty much sure it depends on the original email headers, like
>> above ^^^ — no name.
>> Perhaps git config on your side should be done.
>
> Thanks for the suggestion Andy but the 'tcharding' as the name was
> munged by either Kalle or patchwork.  I'm guessing patchwork.

You guessed corretly, patchwork is here to blame. I sent my "please
rebase" mail earlier in this thread using my custom patchwork client
script (pwcli) which takes the name and address from patchwork.

Andy, this is definitely a bug in patchwork and I have seen this issue
multiple times already. I have understood that it has been fixed in a
recent version but patchwork.kernel.org is still running an old version.
In the original mail Tobin did have the correct From header which can be
checked from the headers in patch page[1]:

From: "Tobin C. Harding" <me@tobin.cc>

[1] https://patchwork.kernel.org/patch/10274983/

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	kernel-hardening@lists.openwall.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	linux-wireless@vger.kernel.org, Tycho Andersen <tycho@tycho.ws>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [RESEND] rsi: Remove stack VLA usage
Date: Wed, 14 Mar 2018 11:11:12 +0200	[thread overview]
Message-ID: <87k1uf6mz3.fsf@codeaurora.org> (raw)
In-Reply-To: <20180314021151.GA11666@eros> (Tobin C. Harding's message of "Wed, 14 Mar 2018 13:11:51 +1100")

"Tobin C. Harding" <me@tobin.cc> writes:

> On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote:
>> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <me@tobin.cc> wrote:
>> > On Mon, Mar 12, 2018 at 09:46:06AM +0000, Kalle Valo wrote:
>> >> tcharding <me@tobin.cc> wrote:
>> 
>> I'm pretty much sure it depends on the original email headers, like
>> above ^^^ — no name.
>> Perhaps git config on your side should be done.
>
> Thanks for the suggestion Andy but the 'tcharding' as the name was
> munged by either Kalle or patchwork.  I'm guessing patchwork.

You guessed corretly, patchwork is here to blame. I sent my "please
rebase" mail earlier in this thread using my custom patchwork client
script (pwcli) which takes the name and address from patchwork.

Andy, this is definitely a bug in patchwork and I have seen this issue
multiple times already. I have understood that it has been fixed in a
recent version but patchwork.kernel.org is still running an old version.
In the original mail Tobin did have the correct From header which can be
checked from the headers in patch page[1]:

From: "Tobin C. Harding" <me@tobin.cc>

[1] https://patchwork.kernel.org/patch/10274983/

-- 
Kalle Valo

  parent reply	other threads:[~2018-03-14  9:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  1:43 [RESEND PATCH] rsi: Remove stack VLA usage Tobin C. Harding
2018-03-12  2:06 ` Larry Finger
2018-03-13 20:09   ` Tobin C. Harding
2018-03-12  9:46 ` [RESEND] " Kalle Valo
2018-03-12  9:46 ` Kalle Valo
2018-03-12  9:46   ` Kalle Valo
2018-03-13 16:52 ` Kalle Valo
2018-03-13 16:52 ` Kalle Valo
2018-03-13 16:52   ` Kalle Valo
     [not found] ` <20180312094606.8192B6081A@smtp.codeaurora.org>
2018-03-13 20:17   ` tcharding
2018-03-13 21:00     ` Andy Shevchenko
2018-03-13 21:00       ` Andy Shevchenko
2018-03-14  2:11       ` Tobin C. Harding
2018-03-14  2:53         ` Kees Cook
2018-03-14  2:53           ` Kees Cook
2018-03-14  3:43           ` Tobin C. Harding
2018-03-14  9:19             ` Kalle Valo
2018-03-14  9:19               ` Kalle Valo
2018-03-14  9:19               ` Kalle Valo
2018-03-14  9:19               ` Kalle Valo
2018-03-14 20:19               ` Tobin C. Harding
2018-03-15  9:07                 ` Kalle Valo
2018-03-15  9:07                   ` Kalle Valo
2018-03-15  9:07                   ` Kalle Valo
2018-03-15  9:07                   ` Kalle Valo
2018-03-14  9:11         ` Kalle Valo [this message]
2018-03-14  9:11           ` Kalle Valo
2018-03-14  9:11           ` Kalle Valo
2018-03-14  9:11           ` Kalle Valo
2018-03-14  9:05     ` Kalle Valo
2018-03-14  9:05       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1uf6mz3.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=netdev@vger.kernel.org \
    --cc=tycho@tycho.ws \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.