[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Martin Bark]

See https://nodejs.org/en/blog/release/v9.0.0/

Signed-off-by: Martin Bark <martin@barkynet.com>
---
 package/nodejs/nodejs.hash | 4 ++--
 package/nodejs/nodejs.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
index 9367c543be..14dde1162b 100644
--- a/package/nodejs/nodejs.hash
+++ b/package/nodejs/nodejs.hash
@@ -1,2 +1,2 @@
-# From http://nodejs.org/dist/v8.8.1/SHASUMS256.txt
-sha256 5ce2c47ab779992db49942f757a01cc5131db5cef4e0dd270e48151b0887b57a  node-v8.8.1.tar.xz
+# From http://nodejs.org/dist/v9.0.0/SHASUMS256.txt
+sha256 5b52bd6a90a611a42e11a908022ccfc1c2e77dcc70bfe38054a18dc57a3d5fa5  node-v9.0.0.tar.xz
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index a29f5726cc..f3e532b4ed 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-NODEJS_VERSION = 8.8.1
+NODEJS_VERSION = 9.0.0
 NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz
 NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION)
 NODEJS_DEPENDENCIES = host-python host-nodejs c-ares \
-- 
2.15.0

[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Peter Korsgaard]

>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:

 > See https://nodejs.org/en/blog/release/v9.0.0/
 > Signed-off-by: Martin Bark <martin@barkynet.com>
 > ---
 >  package/nodejs/nodejs.hash | 4 ++--
 >  package/nodejs/nodejs.mk   | 2 +-
 >  2 files changed, 3 insertions(+), 3 deletions(-)

 > diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
 > index 9367c543be..14dde1162b 100644
 > --- a/package/nodejs/nodejs.hash
 > +++ b/package/nodejs/nodejs.hash
 > @@ -1,2 +1,2 @@
 > -# From http://nodejs.org/dist/v8.8.1/SHASUMS256.txt
 > -sha256 5ce2c47ab779992db49942f757a01cc5131db5cef4e0dd270e48151b0887b57a  node-v8.8.1.tar.xz
 > +# From http://nodejs.org/dist/v9.0.0/SHASUMS256.txt
 > +sha256 5b52bd6a90a611a42e11a908022ccfc1c2e77dcc70bfe38054a18dc57a3d5fa5  node-v9.0.0.tar.xz
 > diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
 > index a29f5726cc..f3e532b4ed 100644
 > --- a/package/nodejs/nodejs.mk
 > +++ b/package/nodejs/nodejs.mk
 > @@ -4,7 +4,7 @@
 >  #
 >  ################################################################################
 
 > -NODEJS_VERSION = 8.8.1
 > +NODEJS_VERSION = 9.0.0

Thanks. I will not bump the version for 2017.11 as I'll release -rc1
today. With 2018.02 becoming the next LTS, wouldn't it make more sense
to move to 8.9.0 instead?

https://nodejs.org/en/blog/release/v8.9.0/

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Martin Bark]

Peter,

On 6 November 2017 at 12:09, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:
>
>  > See https://nodejs.org/en/blog/release/v9.0.0/
>  > Signed-off-by: Martin Bark <martin@barkynet.com>
>  > ---
>  >  package/nodejs/nodejs.hash | 4 ++--
>  >  package/nodejs/nodejs.mk   | 2 +-
>  >  2 files changed, 3 insertions(+), 3 deletions(-)
>
>  > diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
>  > index 9367c543be..14dde1162b 100644
>  > --- a/package/nodejs/nodejs.hash
>  > +++ b/package/nodejs/nodejs.hash
>  > @@ -1,2 +1,2 @@
>  > -# From http://nodejs.org/dist/v8.8.1/SHASUMS256.txt
>  > -sha256 5ce2c47ab779992db49942f757a01cc5131db5cef4e0dd270e48151b0887b57a
> node-v8.8.1.tar.xz
>  > +# From http://nodejs.org/dist/v9.0.0/SHASUMS256.txt
>  > +sha256 5b52bd6a90a611a42e11a908022ccfc1c2e77dcc70bfe38054a18dc57a3d5fa5
> node-v9.0.0.tar.xz
>  > diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
>  > index a29f5726cc..f3e532b4ed 100644
>  > --- a/package/nodejs/nodejs.mk
>  > +++ b/package/nodejs/nodejs.mk
>  > @@ -4,7 +4,7 @@
>  >  #
>  >  ############################################################
> ####################
>
>  > -NODEJS_VERSION = 8.8.1
>  > +NODEJS_VERSION = 9.0.0
>
> Thanks. I will not bump the version for 2017.11 as I'll release -rc1
> today. With 2018.02 becoming the next LTS, wouldn't it make more sense
> to move to 8.9.0 instead?
>
> https://nodejs.org/en/blog/release/v8.9.0/


When we discussed this in the past it was decided to track the latest
version of nodejs.  This simplified buildroot to only support one version
of nodejs.  The release schedule of buildroot and nodejs don't really align
so what you're saying in practice means we would have to only track the LTS
versions of node (the even version numbers).

Thanks

Martin


>
> --
> Bye, Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171106/6d698887/attachment.html>

[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Peter Korsgaard]

>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:

Hi,

>> > +NODEJS_VERSION = 9.0.0
 >> 
 >> Thanks. I will not bump the version for 2017.11 as I'll release -rc1
 >> today. With 2018.02 becoming the next LTS, wouldn't it make more sense
 >> to move to 8.9.0 instead?
 >> 
 >> https://nodejs.org/en/blog/release/v8.9.0/

 > When we discussed this in the past it was decided to track the latest
 > version of nodejs.  This simplified buildroot to only support one version
 > of nodejs.  The release schedule of buildroot and nodejs don't really align
 > so what you're saying in practice means we would have to only track the LTS
 > versions of node (the even version numbers).

What I'm saying is that there is a tradeoff. If we move to the 9.x
version for the 2018.02 release then we'll have to migrate to 10.x quite
soon during the LTS period to get bug/security fixes - Which isn't
really nice.

We may move to 9.x for the 2018.05 release if there's a good reason for
it (I wouldn't know, I don't use nodejs), but again it means extra
effort for the LTS as fixes from master cannot simply be cherry picked -
E.G. you haven't submitted any nodejs version bumps for the 2017.02.x
series.

Do these odd non-LTS releases bring a lot of new features making it
worth the extra effort?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Martin Bark]

Hi,

On 6 November 2017 at 13:37, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:
>
> Hi,
>
> >> > +NODEJS_VERSION = 9.0.0
>  >>
>  >> Thanks. I will not bump the version for 2017.11 as I'll release -rc1
>  >> today. With 2018.02 becoming the next LTS, wouldn't it make more sense
>  >> to move to 8.9.0 instead?
>  >>
>  >> https://nodejs.org/en/blog/release/v8.9.0/
>
>  > When we discussed this in the past it was decided to track the latest
>  > version of nodejs.  This simplified buildroot to only support one
> version
>  > of nodejs.  The release schedule of buildroot and nodejs don't really
> align
>  > so what you're saying in practice means we would have to only track the
> LTS
>  > versions of node (the even version numbers).
>
> What I'm saying is that there is a tradeoff. If we move to the 9.x
> version for the 2018.02 release then we'll have to migrate to 10.x quite
> soon during the LTS period to get bug/security fixes - Which isn't
> really nice.
>
> We may move to 9.x for the 2018.05 release if there's a good reason for
> it (I wouldn't know, I don't use nodejs), but again it means extra
> effort for the LTS as fixes from master cannot simply be cherry picked -
> E.G. you haven't submitted any nodejs version bumps for the 2017.02.x
> series.
>
> Do these odd non-LTS releases bring a lot of new features making it
> worth the extra effort?
>

They can do, it varies.  It really just depends what major changes are
queued up.  Major releases can include breaking changes e.g. API changes

I can see arguments for following only LTS, only latest or both.  I guess
all i need is a final decision to be made.

We don't have to solve this right now.  How about i submit an 8.9.0 patch.

Thanks

Martin



>
> --
> Bye, Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171107/f9a7c4b6/attachment.html>

[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Peter Korsgaard]

>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:

Hi,

 >> Do these odd non-LTS releases bring a lot of new features making it
 >> worth the extra effort?
 >> 

 > They can do, it varies.  It really just depends what major changes are
 > queued up.  Major releases can include breaking changes e.g. API changes

Correct.

 > I can see arguments for following only LTS, only latest or both.  I guess
 > all i need is a final decision to be made.

I think we should at least do it for the LTS releases (E.G. now).

I don't know much about nodejs. What do other distibutions / build
systems do? We already have precedent in E.G. the gtk/freedesktop stack
(gtk/glib/gstreamer/..) where we don't package the uneven (development)
versions.

 > We don't have to solve this right now.  How about i submit an 8.9.0 patch.

Yes, please!

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/nodejs: bump version to 9.0.0

[Martin Bark]

Hi,

On 7 November 2017 at 12:00, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:
>
> Hi,
>
>  >> Do these odd non-LTS releases bring a lot of new features making it
>  >> worth the extra effort?
>  >>
>
>  > They can do, it varies.  It really just depends what major changes are
>  > queued up.  Major releases can include breaking changes e.g. API changes
>
> Correct.
>
>  > I can see arguments for following only LTS, only latest or both.  I
> guess
>  > all i need is a final decision to be made.
>
> I think we should at least do it for the LTS releases (E.G. now).
>
> I don't know much about nodejs. What do other distibutions / build
> systems do? We already have precedent in E.G. the gtk/freedesktop stack
> (gtk/glib/gstreamer/..) where we don't package the uneven (development)
> versions.
>

Frankly most distros and build systems seem to do a terrible job of keep
packages like nodejs up to date.  It's common to not use the packaged
version and instead use an program like nvm (node version manager) to
install a local copy similar to rvm for ruby.

archlinux is one of the few distos I've found that does it well. Just like
buildroot it too uses shared libs instead of the bundled libs included in
nodejs.  It updates frequently but since it's a rolling distro it always
tracks the latest nodejs version.


>
>  > We don't have to solve this right now.  How about i submit an 8.9.0
> patch.
>
> Yes, please!
>

I've just submitted a new patch for version 8.9.1 and changed this patch's
state to superseded.

Thanks

Martin


>
> --
> Bye, Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171108/53995c11/attachment.html>