All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] edid-decode: new package
@ 2015-12-09 13:15 Peter Korsgaard
  2015-12-09 13:19 ` Vicente Olivert Riera
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2015-12-09 13:15 UTC (permalink / raw)
  To: buildroot

commit: http://git.buildroot.net/buildroot/commit/?id=f856c1f7542cc7544ccea42d29922f118b9d40e2
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

[Peter: pass TARGET_CFLAGS/LDFLAGS, quote TARGET_DIR]
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/Config.in                  |  1 +
 package/edid-decode/Config.in      |  6 ++++++
 package/edid-decode/edid-decode.mk | 20 ++++++++++++++++++++
 3 files changed, 27 insertions(+)

diff --git a/package/Config.in b/package/Config.in
index 2bdad01..0eb6fda 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -340,6 +340,7 @@ endif
 	source "package/dtv-scan-tables/Config.in"
 	source "package/dvb-apps/Config.in"
 	source "package/dvbsnoop/Config.in"
+	source "package/edid-decode/Config.in"
 	source "package/eeprog/Config.in"
 	source "package/eudev/Config.in"
 	source "package/evemu/Config.in"
diff --git a/package/edid-decode/Config.in b/package/edid-decode/Config.in
new file mode 100644
index 0000000..64297b4
--- /dev/null
+++ b/package/edid-decode/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EDID_DECODE
+	bool "edid-decode"
+	help
+	  Decode EDID data in human-readable format.
+
+	  http://cgit.freedesktop.org/xorg/app/edid-decode/
diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
new file mode 100644
index 0000000..8fcc19e
--- /dev/null
+++ b/package/edid-decode/edid-decode.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# edid-decode
+#
+################################################################################
+
+EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
+EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
+EDID_DECODE_LICENSE = MIT
+EDID_DECODE_LICENSE_FILES = edid-decode.c
+
+define EDID_DECODE_BUILD_CMDS
+	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)"
+endef
+
+define EDID_DECODE_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
+endef
+
+$(eval $(generic-package))

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [Buildroot] [git commit] edid-decode: new package
  2015-12-09 13:15 [Buildroot] [git commit] edid-decode: new package Peter Korsgaard
@ 2015-12-09 13:19 ` Vicente Olivert Riera
  2015-12-09 21:51   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Vicente Olivert Riera @ 2015-12-09 13:19 UTC (permalink / raw)
  To: buildroot

Hello Peter,

$(TARGET_MAKE_ENV) should have been used before $(MAKE), as I said in my
review for this patch:

http://patchwork.ozlabs.org/patch/553537/

Regards,

Vincent.

On 09/12/15 13:15, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=f856c1f7542cc7544ccea42d29922f118b9d40e2
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> [Peter: pass TARGET_CFLAGS/LDFLAGS, quote TARGET_DIR]
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/Config.in                  |  1 +
>  package/edid-decode/Config.in      |  6 ++++++
>  package/edid-decode/edid-decode.mk | 20 ++++++++++++++++++++
>  3 files changed, 27 insertions(+)
> 
> diff --git a/package/Config.in b/package/Config.in
> index 2bdad01..0eb6fda 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -340,6 +340,7 @@ endif
>  	source "package/dtv-scan-tables/Config.in"
>  	source "package/dvb-apps/Config.in"
>  	source "package/dvbsnoop/Config.in"
> +	source "package/edid-decode/Config.in"
>  	source "package/eeprog/Config.in"
>  	source "package/eudev/Config.in"
>  	source "package/evemu/Config.in"
> diff --git a/package/edid-decode/Config.in b/package/edid-decode/Config.in
> new file mode 100644
> index 0000000..64297b4
> --- /dev/null
> +++ b/package/edid-decode/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_EDID_DECODE
> +	bool "edid-decode"
> +	help
> +	  Decode EDID data in human-readable format.
> +
> +	  http://cgit.freedesktop.org/xorg/app/edid-decode/
> diff --git a/package/edid-decode/edid-decode.mk b/package/edid-decode/edid-decode.mk
> new file mode 100644
> index 0000000..8fcc19e
> --- /dev/null
> +++ b/package/edid-decode/edid-decode.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# edid-decode
> +#
> +################################################################################
> +
> +EDID_DECODE_VERSION = 681153145d5e05ee15032ea792e967cda06e7622
> +EDID_DECODE_SITE = git://anongit.freedesktop.org/git/xorg/app/edid-decode.git
> +EDID_DECODE_LICENSE = MIT
> +EDID_DECODE_LICENSE_FILES = edid-decode.c
> +
> +define EDID_DECODE_BUILD_CMDS
> +	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)"
> +endef
> +
> +define EDID_DECODE_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
> +endef
> +
> +$(eval $(generic-package))
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Buildroot] [git commit] edid-decode: new package
  2015-12-09 13:19 ` Vicente Olivert Riera
@ 2015-12-09 21:51   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2015-12-09 21:51 UTC (permalink / raw)
  To: buildroot

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Hello Peter,
 > $(TARGET_MAKE_ENV) should have been used before $(MAKE), as I said in my
 > review for this patch:

 > http://patchwork.ozlabs.org/patch/553537/

Strange, I didn't see your mail when I applied the patch - My mail has
been acting up a bit.

TARGET_MAKE_ENV doesn't really matter here as it doesn't call anything
else than $CC / mkdir / install, but I'll add it for consistency and in
case future versions do.

Thanks for the review!

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-09 21:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-09 13:15 [Buildroot] [git commit] edid-decode: new package Peter Korsgaard
2015-12-09 13:19 ` Vicente Olivert Riera
2015-12-09 21:51   ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.