* [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
@ 2015-01-29 11:02 ` Dexuan Cui
0 siblings, 0 replies; 6+ messages in thread
From: Dexuan Cui @ 2015-01-29 11:02 UTC (permalink / raw)
To: gregkh, linux-kernel, driverdev-devel, olaf, apw, jasowang, kys; +Cc: haiyangz
Before the line vmbus_open() returns, srv->util_cb can be already running
and the variablies, like util_fw_version, are needed by the srv->util_cb.
So we have to make sure the variables are initialized before the vmbus_open().
CC: "K. Y. Srinivasan" <kys@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
---
drivers/hv/hv_util.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
index 3b9c9ef..c5be773 100644
--- a/drivers/hv/hv_util.c
+++ b/drivers/hv/hv_util.c
@@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
set_channel_read_state(dev->channel, false);
- ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
- srv->util_cb, dev->channel);
- if (ret)
- goto error;
-
hv_set_drvdata(dev, srv);
+
/*
* Based on the host; initialize the framework and
* service version numbers we will negotiate.
@@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
hb_srv_version = HB_VERSION;
}
+ ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
+ srv->util_cb, dev->channel);
+ if (ret)
+ goto error;
+
return 0;
error:
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
@ 2015-01-29 11:02 ` Dexuan Cui
0 siblings, 0 replies; 6+ messages in thread
From: Dexuan Cui @ 2015-01-29 11:02 UTC (permalink / raw)
To: gregkh, linux-kernel, driverdev-devel, olaf, apw, jasowang, kys; +Cc: haiyangz
Before the line vmbus_open() returns, srv->util_cb can be already running
and the variablies, like util_fw_version, are needed by the srv->util_cb.
So we have to make sure the variables are initialized before the vmbus_open().
CC: "K. Y. Srinivasan" <kys@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
---
drivers/hv/hv_util.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
index 3b9c9ef..c5be773 100644
--- a/drivers/hv/hv_util.c
+++ b/drivers/hv/hv_util.c
@@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
set_channel_read_state(dev->channel, false);
- ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
- srv->util_cb, dev->channel);
- if (ret)
- goto error;
-
hv_set_drvdata(dev, srv);
+
/*
* Based on the host; initialize the framework and
* service version numbers we will negotiate.
@@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
hb_srv_version = HB_VERSION;
}
+ ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
+ srv->util_cb, dev->channel);
+ if (ret)
+ goto error;
+
return 0;
error:
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
2015-01-29 11:02 ` Dexuan Cui
@ 2015-01-29 13:12 ` Vitaly Kuznetsov
-1 siblings, 0 replies; 6+ messages in thread
From: Vitaly Kuznetsov @ 2015-01-29 13:12 UTC (permalink / raw)
To: Dexuan Cui
Cc: gregkh, linux-kernel, driverdev-devel, olaf, apw, jasowang, kys,
haiyangz
Dexuan Cui <decui@microsoft.com> writes:
> Before the line vmbus_open() returns, srv->util_cb can be already running
> and the variablies, like util_fw_version, are needed by the srv->util_cb.
>
> So we have to make sure the variables are initialized before the vmbus_open().
>
> CC: "K. Y. Srinivasan" <kys@microsoft.com>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
It is not said in the description but moving hv_set_drvdata() before
vmbus_open() make sense in case probe and remove can collide (can
they?).
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> drivers/hv/hv_util.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> index 3b9c9ef..c5be773 100644
> --- a/drivers/hv/hv_util.c
> +++ b/drivers/hv/hv_util.c
> @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
>
> set_channel_read_state(dev->channel, false);
>
> - ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> - srv->util_cb, dev->channel);
> - if (ret)
> - goto error;
> -
> hv_set_drvdata(dev, srv);
> +
> /*
> * Based on the host; initialize the framework and
> * service version numbers we will negotiate.
> @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
> hb_srv_version = HB_VERSION;
> }
>
> + ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> + srv->util_cb, dev->channel);
> + if (ret)
> + goto error;
> +
> return 0;
>
> error:
--
Vitaly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
@ 2015-01-29 13:12 ` Vitaly Kuznetsov
0 siblings, 0 replies; 6+ messages in thread
From: Vitaly Kuznetsov @ 2015-01-29 13:12 UTC (permalink / raw)
To: Dexuan Cui
Cc: olaf, gregkh, jasowang, driverdev-devel, linux-kernel, apw, haiyangz
Dexuan Cui <decui@microsoft.com> writes:
> Before the line vmbus_open() returns, srv->util_cb can be already running
> and the variablies, like util_fw_version, are needed by the srv->util_cb.
>
> So we have to make sure the variables are initialized before the vmbus_open().
>
> CC: "K. Y. Srinivasan" <kys@microsoft.com>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
It is not said in the description but moving hv_set_drvdata() before
vmbus_open() make sense in case probe and remove can collide (can
they?).
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> drivers/hv/hv_util.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> index 3b9c9ef..c5be773 100644
> --- a/drivers/hv/hv_util.c
> +++ b/drivers/hv/hv_util.c
> @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
>
> set_channel_read_state(dev->channel, false);
>
> - ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> - srv->util_cb, dev->channel);
> - if (ret)
> - goto error;
> -
> hv_set_drvdata(dev, srv);
> +
> /*
> * Based on the host; initialize the framework and
> * service version numbers we will negotiate.
> @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
> hb_srv_version = HB_VERSION;
> }
>
> + ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> + srv->util_cb, dev->channel);
> + if (ret)
> + goto error;
> +
> return 0;
>
> error:
--
Vitaly
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
2015-01-29 13:12 ` Vitaly Kuznetsov
@ 2015-01-30 4:26 ` Dexuan Cui
-1 siblings, 0 replies; 6+ messages in thread
From: Dexuan Cui @ 2015-01-30 4:26 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: gregkh, linux-kernel, driverdev-devel, olaf, apw, jasowang,
KY Srinivasan, Haiyang Zhang
> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Thursday, January 29, 2015 21:13 PM
> To: Dexuan Cui
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev-
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com; KY Srinivasan; Haiyang Zhang
> Subject: Re: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
>
> Dexuan Cui <decui@microsoft.com> writes:
>
> > Before the line vmbus_open() returns, srv->util_cb can be already running
> > and the variablies, like util_fw_version, are needed by the srv->util_cb.
> >
> > So we have to make sure the variables are initialized before the vmbus_open().
> >
> > CC: "K. Y. Srinivasan" <kys@microsoft.com>
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
>
> It is not said in the description but moving hv_set_drvdata() before
> vmbus_open() make sense in case probe and remove can collide (can
> they?).
I'm not so sure. In normal usages, the collision should be unlikely.
Anyway, the patch makes things better. :-)
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Thanks for the review!
Thanks,
-- Dexuan
> > ---
> > drivers/hv/hv_util.c | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> > index 3b9c9ef..c5be773 100644
> > --- a/drivers/hv/hv_util.c
> > +++ b/drivers/hv/hv_util.c
> > @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
> >
> > set_channel_read_state(dev->channel, false);
> >
> > - ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> > - srv->util_cb, dev->channel);
> > - if (ret)
> > - goto error;
> > -
> > hv_set_drvdata(dev, srv);
> > +
> > /*
> > * Based on the host; initialize the framework and
> > * service version numbers we will negotiate.
> > @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
> > hb_srv_version = HB_VERSION;
> > }
> >
> > + ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> > + srv->util_cb, dev->channel);
> > + if (ret)
> > + goto error;
> > +
> > return 0;
> >
> > error:
>
> --
> Vitaly
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
@ 2015-01-30 4:26 ` Dexuan Cui
0 siblings, 0 replies; 6+ messages in thread
From: Dexuan Cui @ 2015-01-30 4:26 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: olaf, gregkh, jasowang, driverdev-devel, linux-kernel, apw,
Haiyang Zhang
> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Thursday, January 29, 2015 21:13 PM
> To: Dexuan Cui
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev-
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com; KY Srinivasan; Haiyang Zhang
> Subject: Re: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
>
> Dexuan Cui <decui@microsoft.com> writes:
>
> > Before the line vmbus_open() returns, srv->util_cb can be already running
> > and the variablies, like util_fw_version, are needed by the srv->util_cb.
> >
> > So we have to make sure the variables are initialized before the vmbus_open().
> >
> > CC: "K. Y. Srinivasan" <kys@microsoft.com>
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
>
> It is not said in the description but moving hv_set_drvdata() before
> vmbus_open() make sense in case probe and remove can collide (can
> they?).
I'm not so sure. In normal usages, the collision should be unlikely.
Anyway, the patch makes things better. :-)
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Thanks for the review!
Thanks,
-- Dexuan
> > ---
> > drivers/hv/hv_util.c | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> > index 3b9c9ef..c5be773 100644
> > --- a/drivers/hv/hv_util.c
> > +++ b/drivers/hv/hv_util.c
> > @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
> >
> > set_channel_read_state(dev->channel, false);
> >
> > - ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> > - srv->util_cb, dev->channel);
> > - if (ret)
> > - goto error;
> > -
> > hv_set_drvdata(dev, srv);
> > +
> > /*
> > * Based on the host; initialize the framework and
> > * service version numbers we will negotiate.
> > @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
> > hb_srv_version = HB_VERSION;
> > }
> >
> > + ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> > + srv->util_cb, dev->channel);
> > + if (ret)
> > + goto error;
> > +
> > return 0;
> >
> > error:
>
> --
> Vitaly
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-30 4:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 11:02 [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place Dexuan Cui
2015-01-29 11:02 ` Dexuan Cui
2015-01-29 13:12 ` Vitaly Kuznetsov
2015-01-29 13:12 ` Vitaly Kuznetsov
2015-01-30 4:26 ` Dexuan Cui
2015-01-30 4:26 ` Dexuan Cui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.