All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
@ 2013-06-16 10:02 Stefan Weil
  2013-07-02 20:35 ` Stefan Weil
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Stefan Weil @ 2013-06-16 10:02 UTC (permalink / raw)
  To: Aneesh Kumar K.V; +Cc: Stefan Weil, qemu-devel

This leak was reported by cppcheck.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 fsdev/qemu-fsdev.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
index 6eaf36d..ccfec13 100644
--- a/fsdev/qemu-fsdev.c
+++ b/fsdev/qemu-fsdev.c
@@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
 
     if (fsle->fse.ops->parse_opts) {
         if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
+            g_free(fsle->fse.fsdev_id);
+            g_free(fsle);
             return -1;
         }
     }
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
  2013-06-16 10:02 [Qemu-devel] [PATCH] fsdev: Fix potential memory leak Stefan Weil
@ 2013-07-02 20:35 ` Stefan Weil
  2013-07-07 17:15   ` Aneesh Kumar K.V
  2013-07-04  4:54 ` M. Mohan Kumar
  2013-07-10 19:33 ` Anthony Liguori
  2 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2013-07-02 20:35 UTC (permalink / raw)
  To: Aneesh Kumar K.V; +Cc: qemu-devel

Am 16.06.2013 12:02, schrieb Stefan Weil:
> This leak was reported by cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  fsdev/qemu-fsdev.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
> index 6eaf36d..ccfec13 100644
> --- a/fsdev/qemu-fsdev.c
> +++ b/fsdev/qemu-fsdev.c
> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>  
>      if (fsle->fse.ops->parse_opts) {
>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
> +            g_free(fsle->fse.fsdev_id);
> +            g_free(fsle);
>              return -1;
>          }
>      }

Ping?

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
  2013-06-16 10:02 [Qemu-devel] [PATCH] fsdev: Fix potential memory leak Stefan Weil
  2013-07-02 20:35 ` Stefan Weil
@ 2013-07-04  4:54 ` M. Mohan Kumar
  2013-07-10 19:33 ` Anthony Liguori
  2 siblings, 0 replies; 6+ messages in thread
From: M. Mohan Kumar @ 2013-07-04  4:54 UTC (permalink / raw)
  To: Stefan Weil, Aneesh Kumar K.V; +Cc: qemu-devel

Stefan Weil <sw@weilnetz.de> writes:

> This leak was reported by cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: M. Mohan Kumar <mohan@in.ibm.com>
> ---
>  fsdev/qemu-fsdev.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
> index 6eaf36d..ccfec13 100644
> --- a/fsdev/qemu-fsdev.c
> +++ b/fsdev/qemu-fsdev.c
> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>
>      if (fsle->fse.ops->parse_opts) {
>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
> +            g_free(fsle->fse.fsdev_id);
> +            g_free(fsle);
>              return -1;
>          }
>      }
> -- 
> 1.7.10.4

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
  2013-07-02 20:35 ` Stefan Weil
@ 2013-07-07 17:15   ` Aneesh Kumar K.V
  2013-07-07 19:41     ` Stefan Weil
  0 siblings, 1 reply; 6+ messages in thread
From: Aneesh Kumar K.V @ 2013-07-07 17:15 UTC (permalink / raw)
  To: Stefan Weil, Anthony Liguori; +Cc: qemu-devel

Stefan Weil <sw@weilnetz.de> writes:

> Am 16.06.2013 12:02, schrieb Stefan Weil:
>> This leak was reported by cppcheck.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  fsdev/qemu-fsdev.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
>> index 6eaf36d..ccfec13 100644
>> --- a/fsdev/qemu-fsdev.c
>> +++ b/fsdev/qemu-fsdev.c
>> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>>  
>>      if (fsle->fse.ops->parse_opts) {
>>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
>> +            g_free(fsle->fse.fsdev_id);
>> +            g_free(fsle);
>>              return -1;
>>          }
>>      }
>
> Ping?

Both the error path result in Qemu terminating right ? Do we really care
about free in those case ?

-aneesh

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
  2013-07-07 17:15   ` Aneesh Kumar K.V
@ 2013-07-07 19:41     ` Stefan Weil
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-07-07 19:41 UTC (permalink / raw)
  To: Aneesh Kumar K.V; +Cc: Anthony Liguori, qemu-devel

Am 07.07.2013 19:15, schrieb Aneesh Kumar K.V:
> Stefan Weil <sw@weilnetz.de> writes:
>
>> Am 16.06.2013 12:02, schrieb Stefan Weil:
>>> This leak was reported by cppcheck.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>> ---
>>>  fsdev/qemu-fsdev.c |    2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
>>> index 6eaf36d..ccfec13 100644
>>> --- a/fsdev/qemu-fsdev.c
>>> +++ b/fsdev/qemu-fsdev.c
>>> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>>>  
>>>      if (fsle->fse.ops->parse_opts) {
>>>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
>>> +            g_free(fsle->fse.fsdev_id);
>>> +            g_free(fsle);
>>>              return -1;
>>>          }
>>>      }
>> Ping?
> Both the error path result in Qemu terminating right ? Do we really care
> about free in those case ?
>
> -aneesh


Yes, we do, because it simplifies code reviews if there are
as few as possible warnings from static code analysers.

It is also not immediately obvious that QEMU terminates
in the code which was patched here. Reviewers have
to grep and look in vl.c, too, to see this.

Therefore I'd appreciate if this and similar code could be
fixed (with low priority here).

Regards
Stefan W.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
  2013-06-16 10:02 [Qemu-devel] [PATCH] fsdev: Fix potential memory leak Stefan Weil
  2013-07-02 20:35 ` Stefan Weil
  2013-07-04  4:54 ` M. Mohan Kumar
@ 2013-07-10 19:33 ` Anthony Liguori
  2 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2013-07-10 19:33 UTC (permalink / raw)
  To: Stefan Weil, Aneesh Kumar K.V; +Cc: qemu-devel

Applied.  Thanks.

Regards,

Anthony Liguori

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-10 19:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-16 10:02 [Qemu-devel] [PATCH] fsdev: Fix potential memory leak Stefan Weil
2013-07-02 20:35 ` Stefan Weil
2013-07-07 17:15   ` Aneesh Kumar K.V
2013-07-07 19:41     ` Stefan Weil
2013-07-04  4:54 ` M. Mohan Kumar
2013-07-10 19:33 ` Anthony Liguori

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.