All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: Thomas Renninger <trenn@suse.de>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH] perf: add OMAP support for the new power events
Date: Thu, 10 Mar 2011 10:15:05 -0800	[thread overview]
Message-ID: <87k4g6deqe.fsf@ti.com> (raw)
In-Reply-To: <AANLkTikaQ69Rt9Q6vtm8F_S=qLftM=yqjrUcTqj2Rihm@mail.gmail.com> (Jean Pihet's message of "Thu, 10 Mar 2011 09:09:37 +0100")

Jean Pihet <jean.pihet@newoldbits.com> writes:

> On Thu, Mar 10, 2011 at 1:08 AM, Kevin Hilman <khilman@ti.com> wrote:
>> Jean Pihet <jean.pihet@newoldbits.com> writes:
>>
>>> The patch adds the new power management trace points for
>>> the OMAP architecture.
>>>
>>> The trace points are for:
>>> - default idle handler. Since the cpuidle framework is
>>>   instrumented in the generic way there is no need to
>>>   add trace points in the OMAP specific cpuidle handler;
>>> - cpufreq (DVFS),
>>
>> Minor: AFAICT, this patch doesn't instrument CPUfreq.
> The generic framework provides a cpu_frequency event. Furthermore the
> clock_set_rate events are reporting the various SoC clock rate
> changes.
> Indeed the changelog is not accurate enough. Is '- cpufreq (DVFS)
> events are covered by the generic cpu_frequency events and the SoC
> clock changes events' better?

I'd prefer to just leave this out as either way, I find it confusing
based on the content of this patch.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf: add OMAP support for the new power events
Date: Thu, 10 Mar 2011 10:15:05 -0800	[thread overview]
Message-ID: <87k4g6deqe.fsf@ti.com> (raw)
In-Reply-To: <AANLkTikaQ69Rt9Q6vtm8F_S=qLftM=yqjrUcTqj2Rihm@mail.gmail.com> (Jean Pihet's message of "Thu, 10 Mar 2011 09:09:37 +0100")

Jean Pihet <jean.pihet@newoldbits.com> writes:

> On Thu, Mar 10, 2011 at 1:08 AM, Kevin Hilman <khilman@ti.com> wrote:
>> Jean Pihet <jean.pihet@newoldbits.com> writes:
>>
>>> The patch adds the new power management trace points for
>>> the OMAP architecture.
>>>
>>> The trace points are for:
>>> - default idle handler. Since the cpuidle framework is
>>> ? instrumented in the generic way there is no need to
>>> ? add trace points in the OMAP specific cpuidle handler;
>>> - cpufreq (DVFS),
>>
>> Minor: AFAICT, this patch doesn't instrument CPUfreq.
> The generic framework provides a cpu_frequency event. Furthermore the
> clock_set_rate events are reporting the various SoC clock rate
> changes.
> Indeed the changelog is not accurate enough. Is '- cpufreq (DVFS)
> events are covered by the generic cpu_frequency events and the SoC
> clock changes events' better?

I'd prefer to just leave this out as either way, I find it confusing
based on the content of this patch.

Kevin

  reply	other threads:[~2011-03-10 18:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18 18:10 [PATCH] perf: add OMAP support for the new power events jean.pihet
2011-02-18 18:10 ` jean.pihet at newoldbits.com
2011-02-18 18:21 ` Santosh Shilimkar
2011-02-18 18:21   ` Santosh Shilimkar
2011-02-19 18:55 ` Santosh Shilimkar
2011-02-19 18:55   ` Santosh Shilimkar
2011-02-21  8:44   ` Jean Pihet
2011-02-21  8:44     ` Jean Pihet
2011-02-21  8:53     ` Santosh Shilimkar
2011-02-21  8:53       ` Santosh Shilimkar
2011-02-28 16:33       ` Jean Pihet
2011-02-28 16:33         ` Jean Pihet
2011-03-03  0:43 ` Kevin Hilman
2011-03-03  0:43   ` Kevin Hilman
2011-03-03 10:25 ` Jean Pihet
2011-03-03 10:25   ` Jean Pihet
2011-03-10  0:08   ` Kevin Hilman
2011-03-10  0:08     ` Kevin Hilman
2011-03-10  8:09     ` Jean Pihet
2011-03-10  8:09       ` Jean Pihet
2011-03-10 18:15       ` Kevin Hilman [this message]
2011-03-10 18:15         ` Kevin Hilman
2011-03-10  1:04   ` Paul Walmsley
2011-03-10  1:04     ` Paul Walmsley
2011-03-10  8:17     ` Jean Pihet
2011-03-10  8:17       ` Jean Pihet
  -- strict thread matches above, loose matches on Subject: below --
2011-01-24 14:20 jean.pihet
2011-01-24 14:55 ` Santosh Shilimkar
2011-01-26  9:49   ` Jean Pihet
2011-01-26 10:06     ` Santosh Shilimkar
2011-02-07 16:05       ` Jean Pihet
2011-02-07 16:12         ` Santosh Shilimkar
2011-02-10 21:02 ` Kevin Hilman
2011-02-18 18:14   ` Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k4g6deqe.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.