From: Cornelia Huck <cohuck@redhat.com> To: Parav Pandit <parav@nvidia.com>, "virtio-comment@lists.oasis-open.org" <virtio-comment@lists.oasis-open.org>, "mst@redhat.com" <mst@redhat.com>, "david.edmondson@oracle.com" <david.edmondson@oracle.com> Cc: "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>, "sburla@marvell.com" <sburla@marvell.com>, "jasowang@redhat.com" <jasowang@redhat.com>, Yishai Hadas <yishaih@nvidia.com>, Maor Gottlieb <maorg@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com> Subject: [virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access Date: Thu, 06 Jul 2023 18:47:29 +0200 [thread overview] Message-ID: <87leftugv2.fsf@redhat.com> (raw) In-Reply-To: <PH0PR12MB5481ED484C57428AD3D959C5DC2CA@PH0PR12MB5481.namprd12.prod.outlook.com> On Thu, Jul 06 2023, Parav Pandit <parav@nvidia.com> wrote: >> From: Cornelia Huck <cohuck@redhat.com> >> Sent: Thursday, July 6, 2023 12:28 PM >> >> On Thu, Jul 06 2023, Parav Pandit <parav@nvidia.com> wrote: >> >> > diff --git a/transport-pci-legacy-regs.tex >> > b/transport-pci-legacy-regs.tex new file mode 100644 index >> > 0000000..ceea28c >> > --- /dev/null >> > +++ b/transport-pci-legacy-regs.tex >> > @@ -0,0 +1,42 @@ >> > +\subsection{Legacy Interface: Group member device Configuration >> > +Region Access}\label{sec:Virtio Transport Options / Virtio Over PCI >> > +Bus / Legacy Interface: Group Member Device Configuration Region >> > +Access} >> > + >> > +The PCI owner device or the member device or both support driver >> > +notifications using >> >> What about >> >> "The PCI owner device, the member device, or both can choose to support..." ? >> > Fine too. > Any thing wrong in having or as above, so I don't write it next time? > Or that in current form reads better to me. Just a bare "support" does not really tell the reader if this is something that is required or optional. Dropping the first "or" makes it read better for me. > >> > +a notification region defined in \field{struct >> virtio_pci_legacy_notify_region}. (...) >> > +The group owner device or the group member device or both MAY support >> > +driver notifications region. >> >> Make this "a driver notification region"? >> > Notifications are generally more than one and spec has the section "driver notifications", so... I'd parse this as "a region for the purpose of notification" (and "notification region" is used above)... but in any case, we need the article here, I think. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com> To: Parav Pandit <parav@nvidia.com>, "virtio-comment@lists.oasis-open.org" <virtio-comment@lists.oasis-open.org>, "mst@redhat.com" <mst@redhat.com>, "david.edmondson@oracle.com" <david.edmondson@oracle.com> Cc: "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>, "sburla@marvell.com" <sburla@marvell.com>, "jasowang@redhat.com" <jasowang@redhat.com>, Yishai Hadas <yishaih@nvidia.com>, Maor Gottlieb <maorg@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com> Subject: [virtio-comment] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access Date: Thu, 06 Jul 2023 18:47:29 +0200 [thread overview] Message-ID: <87leftugv2.fsf@redhat.com> (raw) In-Reply-To: <PH0PR12MB5481ED484C57428AD3D959C5DC2CA@PH0PR12MB5481.namprd12.prod.outlook.com> On Thu, Jul 06 2023, Parav Pandit <parav@nvidia.com> wrote: >> From: Cornelia Huck <cohuck@redhat.com> >> Sent: Thursday, July 6, 2023 12:28 PM >> >> On Thu, Jul 06 2023, Parav Pandit <parav@nvidia.com> wrote: >> >> > diff --git a/transport-pci-legacy-regs.tex >> > b/transport-pci-legacy-regs.tex new file mode 100644 index >> > 0000000..ceea28c >> > --- /dev/null >> > +++ b/transport-pci-legacy-regs.tex >> > @@ -0,0 +1,42 @@ >> > +\subsection{Legacy Interface: Group member device Configuration >> > +Region Access}\label{sec:Virtio Transport Options / Virtio Over PCI >> > +Bus / Legacy Interface: Group Member Device Configuration Region >> > +Access} >> > + >> > +The PCI owner device or the member device or both support driver >> > +notifications using >> >> What about >> >> "The PCI owner device, the member device, or both can choose to support..." ? >> > Fine too. > Any thing wrong in having or as above, so I don't write it next time? > Or that in current form reads better to me. Just a bare "support" does not really tell the reader if this is something that is required or optional. Dropping the first "or" makes it read better for me. > >> > +a notification region defined in \field{struct >> virtio_pci_legacy_notify_region}. (...) >> > +The group owner device or the group member device or both MAY support >> > +driver notifications region. >> >> Make this "a driver notification region"? >> > Notifications are generally more than one and spec has the section "driver notifications", so... I'd parse this as "a region for the purpose of notification" (and "notification region" is used above)... but in any case, we need the article here, I think. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-07-06 16:47 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-06 4:17 [virtio-dev] [PATCH v10 0/4] admin: Access legacy registers using admin commands Parav Pandit 2023-07-06 4:17 ` [virtio-comment] " Parav Pandit 2023-07-06 4:17 ` [virtio-dev] [PATCH v10 1/4] admin: Split opcode table rows with a line Parav Pandit 2023-07-06 4:17 ` [virtio-comment] " Parav Pandit 2023-07-06 4:17 ` [virtio-dev] [PATCH v10 2/4] admin: Fix section numbering Parav Pandit 2023-07-06 4:17 ` [virtio-comment] " Parav Pandit 2023-07-06 13:39 ` [virtio-dev] " Cornelia Huck 2023-07-06 13:39 ` [virtio-comment] " Cornelia Huck 2023-07-06 4:17 ` [virtio-dev] [PATCH v10 3/4] admin: Add group member legacy register access commands Parav Pandit 2023-07-06 4:17 ` [virtio-comment] " Parav Pandit 2023-07-06 16:12 ` [virtio-dev] " Cornelia Huck 2023-07-06 16:12 ` [virtio-comment] " Cornelia Huck 2023-07-06 16:16 ` [virtio-dev] " Parav Pandit 2023-07-06 16:16 ` [virtio-comment] " Parav Pandit 2023-07-06 4:17 ` [virtio-dev] [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access Parav Pandit 2023-07-06 4:17 ` [virtio-comment] " Parav Pandit 2023-07-06 16:28 ` [virtio-dev] " Cornelia Huck 2023-07-06 16:28 ` [virtio-comment] " Cornelia Huck 2023-07-06 16:33 ` [virtio-dev] " Parav Pandit 2023-07-06 16:33 ` [virtio-comment] " Parav Pandit 2023-07-06 16:42 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 16:42 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 16:58 ` [virtio-dev] " Parav Pandit 2023-07-06 16:58 ` [virtio-comment] " Parav Pandit 2023-07-06 17:33 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 17:33 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 17:47 ` [virtio-dev] " Parav Pandit 2023-07-06 17:47 ` [virtio-comment] " Parav Pandit 2023-07-06 18:06 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 18:06 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 18:16 ` [virtio-dev] " Parav Pandit 2023-07-06 18:16 ` [virtio-comment] " Parav Pandit 2023-07-06 18:48 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 18:48 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 18:53 ` [virtio-dev] " Parav Pandit 2023-07-06 18:53 ` [virtio-comment] " Parav Pandit 2023-07-06 18:56 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 18:56 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 19:00 ` [virtio-dev] " Parav Pandit 2023-07-06 19:00 ` [virtio-comment] " Parav Pandit 2023-07-06 19:42 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 19:42 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 20:21 ` [virtio-dev] " Parav Pandit 2023-07-06 20:21 ` [virtio-comment] " Parav Pandit 2023-07-06 20:28 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 20:28 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 20:35 ` [virtio-dev] " Parav Pandit 2023-07-06 20:35 ` [virtio-comment] " Parav Pandit 2023-07-06 20:41 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 20:41 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 20:43 ` [virtio-dev] " Parav Pandit 2023-07-06 20:43 ` [virtio-comment] " Parav Pandit 2023-07-07 8:12 ` Cornelia Huck 2023-07-07 8:12 ` [virtio-dev] " Cornelia Huck 2023-07-07 8:32 ` Michael S. Tsirkin 2023-07-07 8:32 ` Michael S. Tsirkin 2023-07-06 17:38 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 17:38 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 16:47 ` Cornelia Huck [this message] 2023-07-06 16:47 ` [virtio-comment] " Cornelia Huck 2023-07-06 16:52 ` [virtio-dev] " Parav Pandit 2023-07-06 16:52 ` [virtio-comment] " Parav Pandit 2023-07-06 16:39 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 16:39 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 16:45 ` [virtio-dev] " Parav Pandit 2023-07-06 16:45 ` [virtio-comment] " Parav Pandit 2023-07-06 16:50 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 16:50 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 16:54 ` [virtio-dev] " Parav Pandit 2023-07-06 16:54 ` [virtio-comment] " Parav Pandit 2023-07-06 19:00 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 19:00 ` [virtio-comment] " Michael S. Tsirkin 2023-07-06 19:07 ` [virtio-dev] " Parav Pandit 2023-07-06 19:07 ` Parav Pandit 2023-07-06 19:59 ` [virtio-dev] " Michael S. Tsirkin 2023-07-06 19:59 ` Michael S. Tsirkin 2023-07-06 20:28 ` Parav Pandit 2023-07-06 20:28 ` [virtio-dev] " Parav Pandit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87leftugv2.fsf@redhat.com \ --to=cohuck@redhat.com \ --cc=david.edmondson@oracle.com \ --cc=jasowang@redhat.com \ --cc=maorg@nvidia.com \ --cc=mst@redhat.com \ --cc=parav@nvidia.com \ --cc=sburla@marvell.com \ --cc=shahafs@nvidia.com \ --cc=virtio-comment@lists.oasis-open.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=yishaih@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.