[Buildroot] [PATCH v2 3/4] package/polkit: improve sysv script

[Buildroot] [PATCH v2 3/4] package/polkit: improve sysv script

[Lang Daniel via buildroot]

As specified in the manual (18.5 The SNNfoo start script),
the name of the script should reflect the name of the daemon,
which in this case in polkitd.

Also removed the redundant reload case.

Signed-off-by: Daniel Lang <d.lang@abatec.at>
---
(no changes since v1)
---
 package/polkit/{S50polkit => S50polkitd} | 2 +-
 package/polkit/polkit.mk                 | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
 rename package/polkit/{S50polkit => S50polkitd} (97%)
 mode change 100755 => 100644

diff --git a/package/polkit/S50polkit b/package/polkit/S50polkitd
old mode 100755
new mode 100644
similarity index 97%
rename from package/polkit/S50polkit
rename to package/polkit/S50polkitd
index f07e2d613b..5810e780a0
--- a/package/polkit/S50polkit
+++ b/package/polkit/S50polkitd
@@ -40,7 +40,7 @@ restart() {
 }
 
 case "$1" in
-	start|stop|restart|reload)
+	start|stop|restart)
 		"$1";;
 	reload)
 		# Restart, since there is no true "reload" feature.
diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
index a8b371acf8..f94579a149 100644
--- a/package/polkit/polkit.mk
+++ b/package/polkit/polkit.mk
@@ -68,8 +68,8 @@ define POLKIT_INSTALL_INIT_SYSTEMD
 endef
 
 define POLKIT_INSTALL_INIT_SYSV
-	$(INSTALL) -D -m 0755 package/polkit/S50polkit \
-		$(TARGET_DIR)/etc/init.d/S50polkit
+	$(INSTALL) -D -m 0755 package/polkit/S50polkitd \
+		$(TARGET_DIR)/etc/init.d/S50polkitd
 endef
 
 $(eval $(meson-package))
-- 
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 3/4] package/polkit: improve sysv script

[Peter Korsgaard]

>>>>> "Lang" == Lang Daniel via buildroot <buildroot@buildroot.org> writes:

 > As specified in the manual (18.5 The SNNfoo start script),
 > the name of the script should reflect the name of the daemon,
 > which in this case in polkitd.

 > Also removed the redundant reload case.

Not only redundant, it would end up executing "reload", which doesn't
exist.

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot