From: Mattijs Korpershoek <mkorpershoek@baylibre.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent <parent.f@gmail.com>, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent <fparent@baylibre.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys Date: Thu, 21 Jul 2022 16:44:48 +0200 [thread overview] Message-ID: <87lesmh6e7.fsf@baylibre.com> (raw) In-Reply-To: <4084d7e6-e722-a4a7-1a34-c50983f7d93a@linaro.org> On Thu, Jul 21, 2022 at 15:51, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 21/07/2022 15:32, Mattijs Korpershoek wrote: >>>> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> index ca8ae40a73f7..03c9555849e5 100644 >>>> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> @@ -49,6 +49,12 @@ properties: >>>> maximum: 256 >>>> default: 16 >>>> >>>> + mediatek,double-keys: >>> >>> Do you think there could be another MT keypad version with triple-keys? >> >> Of all the SoC's i've worked on (MT8167, MT8183, MT8365, MT8195) I've >> never seen a "triple-keys" keypad. > > OK, but the binding you create now would be poor if MT comes with such > tripe-key feature later... ACK, I'll send a v2 to transform this into a uint32 property named mediatek,keys-per-group Thanks, Mattijs > > > Best regards, > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Mattijs Korpershoek <mkorpershoek@baylibre.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent <parent.f@gmail.com>, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent <fparent@baylibre.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys Date: Thu, 21 Jul 2022 16:44:48 +0200 [thread overview] Message-ID: <87lesmh6e7.fsf@baylibre.com> (raw) In-Reply-To: <4084d7e6-e722-a4a7-1a34-c50983f7d93a@linaro.org> On Thu, Jul 21, 2022 at 15:51, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 21/07/2022 15:32, Mattijs Korpershoek wrote: >>>> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> index ca8ae40a73f7..03c9555849e5 100644 >>>> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> @@ -49,6 +49,12 @@ properties: >>>> maximum: 256 >>>> default: 16 >>>> >>>> + mediatek,double-keys: >>> >>> Do you think there could be another MT keypad version with triple-keys? >> >> Of all the SoC's i've worked on (MT8167, MT8183, MT8365, MT8195) I've >> never seen a "triple-keys" keypad. > > OK, but the binding you create now would be poor if MT comes with such > tripe-key feature later... ACK, I'll send a v2 to transform this into a uint32 property named mediatek,keys-per-group Thanks, Mattijs > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-21 14:45 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-20 14:48 [PATCH v1 0/6] Input: mt6779-keypad - double keys support Mattijs Korpershoek 2022-07-20 14:48 ` Mattijs Korpershoek 2022-07-20 14:48 ` [PATCH v1 1/6] MAINTAINERS: input: add mattijs for mt6779-keypad Mattijs Korpershoek 2022-07-20 14:48 ` Mattijs Korpershoek 2022-07-20 14:48 ` [PATCH v1 2/6] dt-bindings: mediatek,mt6779-keypad: use unevaluatedProperties Mattijs Korpershoek 2022-07-20 14:48 ` Mattijs Korpershoek 2022-07-20 17:14 ` Krzysztof Kozlowski 2022-07-20 17:14 ` Krzysztof Kozlowski 2022-07-21 9:06 ` Mattijs Korpershoek 2022-07-21 9:06 ` Mattijs Korpershoek 2022-07-21 9:16 ` Krzysztof Kozlowski 2022-07-21 9:16 ` Krzysztof Kozlowski 2022-07-21 13:11 ` Mattijs Korpershoek 2022-07-21 13:11 ` Mattijs Korpershoek 2022-07-20 14:48 ` [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys Mattijs Korpershoek 2022-07-20 14:48 ` Mattijs Korpershoek 2022-07-20 17:26 ` Krzysztof Kozlowski 2022-07-20 17:26 ` Krzysztof Kozlowski 2022-07-21 13:32 ` Mattijs Korpershoek 2022-07-21 13:32 ` Mattijs Korpershoek 2022-07-21 13:51 ` Krzysztof Kozlowski 2022-07-21 13:51 ` Krzysztof Kozlowski 2022-07-21 14:44 ` Mattijs Korpershoek [this message] 2022-07-21 14:44 ` Mattijs Korpershoek 2022-07-21 8:40 ` AngeloGioacchino Del Regno 2022-07-21 8:40 ` AngeloGioacchino Del Regno 2022-07-21 13:34 ` Mattijs Korpershoek 2022-07-21 13:34 ` Mattijs Korpershoek 2022-07-20 14:48 ` [PATCH v1 4/6] Input: mt6779-keypad - support double keys matrix Mattijs Korpershoek 2022-07-20 14:48 ` Mattijs Korpershoek 2022-07-20 14:53 ` Matthias Brugger 2022-07-20 14:53 ` Matthias Brugger 2022-07-21 8:34 ` AngeloGioacchino Del Regno 2022-07-21 8:34 ` AngeloGioacchino Del Regno 2022-07-21 14:51 ` Mattijs Korpershoek 2022-07-21 14:51 ` Mattijs Korpershoek 2022-07-21 14:55 ` AngeloGioacchino Del Regno 2022-07-21 14:55 ` AngeloGioacchino Del Regno 2022-07-26 9:52 ` Mattijs Korpershoek 2022-07-26 9:52 ` Mattijs Korpershoek 2022-07-20 14:48 ` [PATCH v1 5/6] arm64: dts: mediatek: mt8183: add keyboard node Mattijs Korpershoek 2022-07-20 14:48 ` Mattijs Korpershoek 2022-07-21 8:41 ` AngeloGioacchino Del Regno 2022-07-21 8:41 ` AngeloGioacchino Del Regno 2022-07-20 14:48 ` [PATCH v1 6/6] arm64: dts: mediatek: mt8183-pumpkin: add keypad support Mattijs Korpershoek 2022-07-20 14:48 ` Mattijs Korpershoek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87lesmh6e7.fsf@baylibre.com \ --to=mkorpershoek@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=fparent@baylibre.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=parent.f@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.