From: Takashi Iwai <tiwai@suse.de>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
Vitaly Rodionov <vitaly.rodionov@cirrus.com>
Subject: Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading
Date: Fri, 20 May 2022 10:02:41 +0200 [thread overview]
Message-ID: <87leuwr5r2.wl-tiwai@suse.de> (raw)
In-Reply-To: <87mtfcr5v1.wl-tiwai@suse.de>
On Fri, 20 May 2022 10:00:18 +0200,
Takashi Iwai wrote:
>
> On Thu, 19 May 2022 19:47:36 +0200,
> Vitaly Rodionov wrote:
> >
> > From: Vitaly Rodionov <vitaly.rodionov@cirrus.com>
> >
> > This patch adds support for the CS35L41 DSP.
> > The DSP allows for extra features, such as running
> > speaker protection algorithms and hibernations.
> >
> > To utilize these features, the driver must load
> > firmware into the DSP, as well as various tuning
> > files which allow for cusomtization for specific
> > models.
>
> Wouldn't this sequence be required after S3/S4 resume?
> I thought cs35l41_hda_bind() is called only at the first binding.
OK, I see that the later patches in the series are about hibernation.
It might be good to mention that in this patch, though.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Vitaly Rodionov <vitaly.rodionov@cirrus.com>
Subject: Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading
Date: Fri, 20 May 2022 10:02:41 +0200 [thread overview]
Message-ID: <87leuwr5r2.wl-tiwai@suse.de> (raw)
In-Reply-To: <87mtfcr5v1.wl-tiwai@suse.de>
On Fri, 20 May 2022 10:00:18 +0200,
Takashi Iwai wrote:
>
> On Thu, 19 May 2022 19:47:36 +0200,
> Vitaly Rodionov wrote:
> >
> > From: Vitaly Rodionov <vitaly.rodionov@cirrus.com>
> >
> > This patch adds support for the CS35L41 DSP.
> > The DSP allows for extra features, such as running
> > speaker protection algorithms and hibernations.
> >
> > To utilize these features, the driver must load
> > firmware into the DSP, as well as various tuning
> > files which allow for cusomtization for specific
> > models.
>
> Wouldn't this sequence be required after S3/S4 resume?
> I thought cs35l41_hda_bind() is called only at the first binding.
OK, I see that the later patches in the series are about hibernation.
It might be good to mention that in this patch, though.
Takashi
next prev parent reply other threads:[~2022-05-20 8:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 17:47 [PATCH v3 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 01/17] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-20 7:50 ` Takashi Iwai
2022-05-20 7:50 ` Takashi Iwai
2022-05-20 7:55 ` Takashi Iwai
2022-05-20 7:55 ` Takashi Iwai
2022-05-19 17:47 ` [PATCH v3 02/17] ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 03/17] ALSA: hda: cs35l41: Save codec object inside component struct Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-20 8:00 ` Takashi Iwai
2022-05-20 8:00 ` Takashi Iwai
2022-05-20 8:02 ` Takashi Iwai [this message]
2022-05-20 8:02 ` Takashi Iwai
2022-05-19 17:47 ` [PATCH v3 05/17] ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 06/17] ALSA: hda: cs35l41: Support reading subsystem id from ACPI Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 07/17] ALSA: hda: cs35l41: Support multiple load paths for firmware Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 08/17] ALSA: hda: cs35l41: Support Speaker ID for laptops Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 09/17] ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 10/17] ASoC: cs35l41: Do not print error when waking from hibernation Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 11/17] ASoC: cs35l41: Add common cs35l41 enter hibernate function Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 12/17] ALSA: hda: cs35l41: Support Hibernation during Suspend Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 13/17] ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 14/17] ALSA: hda: hda_cs_dsp_ctl: Add fw id strings Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 15/17] ALSA: hda: cs35l41: Add defaulted values into dsp bypass config sequence Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-19 17:47 ` [PATCH v3 16/17] ALSA: hda: cs35l41: Support Firmware switching and reloading Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-05-20 8:08 ` Takashi Iwai
2022-05-20 8:08 ` Takashi Iwai
2022-05-19 17:47 ` [PATCH v3 17/17] ALSA: hda: cs35l41: Add module parameter to control firmware load Vitaly Rodionov
2022-05-19 17:47 ` Vitaly Rodionov
2022-06-07 10:54 ` (subset) [PATCH v3 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Mark Brown
2022-06-07 10:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leuwr5r2.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vitaly.rodionov@cirrus.com \
--cc=vitalyr@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.