* [PATCH] KVM/X86: Remove unneeded variable
@ 2021-12-19 15:03 Quanfa Fu
2021-12-20 9:27 ` Vitaly Kuznetsov
0 siblings, 1 reply; 2+ messages in thread
From: Quanfa Fu @ 2021-12-19 15:03 UTC (permalink / raw)
To: pbonzini, seanjc, vkuznets, wanpengli, jmattson, joro, tglx,
mingo, bp, dave.hansen, hpa
Cc: x86, linux-kernel, kvm, Quanfa Fu
Remove unneeded variable used to store return value.
No functional change intended.
Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
---
arch/x86/kvm/mmu/mmu.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index e2e1d012df22..7603db81b902 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -2553,16 +2553,13 @@ int kvm_mmu_unprotect_page(struct kvm *kvm, gfn_t gfn)
static int kvm_mmu_unprotect_page_virt(struct kvm_vcpu *vcpu, gva_t gva)
{
gpa_t gpa;
- int r;
if (vcpu->arch.mmu->direct_map)
return 0;
gpa = kvm_mmu_gva_to_gpa_read(vcpu, gva, NULL);
- r = kvm_mmu_unprotect_page(vcpu->kvm, gpa >> PAGE_SHIFT);
-
- return r;
+ return kvm_mmu_unprotect_page(vcpu->kvm, gpa >> PAGE_SHIFT);
}
static void kvm_unsync_page(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] KVM/X86: Remove unneeded variable
2021-12-19 15:03 [PATCH] KVM/X86: Remove unneeded variable Quanfa Fu
@ 2021-12-20 9:27 ` Vitaly Kuznetsov
0 siblings, 0 replies; 2+ messages in thread
From: Vitaly Kuznetsov @ 2021-12-20 9:27 UTC (permalink / raw)
To: Quanfa Fu
Cc: x86, linux-kernel, kvm, Quanfa Fu, pbonzini, seanjc, wanpengli,
jmattson, joro, tglx, mingo, bp, dave.hansen, hpa
Quanfa Fu <quanfafu@gmail.com> writes:
> Remove unneeded variable used to store return value.
>
> No functional change intended.
>
> Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
> ---
> arch/x86/kvm/mmu/mmu.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index e2e1d012df22..7603db81b902 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -2553,16 +2553,13 @@ int kvm_mmu_unprotect_page(struct kvm *kvm, gfn_t gfn)
> static int kvm_mmu_unprotect_page_virt(struct kvm_vcpu *vcpu, gva_t gva)
> {
> gpa_t gpa;
> - int r;
>
> if (vcpu->arch.mmu->direct_map)
> return 0;
>
> gpa = kvm_mmu_gva_to_gpa_read(vcpu, gva, NULL);
>
> - r = kvm_mmu_unprotect_page(vcpu->kvm, gpa >> PAGE_SHIFT);
> -
> - return r;
> + return kvm_mmu_unprotect_page(vcpu->kvm, gpa >> PAGE_SHIFT);
While on it, you could've switched to using gpa_to_gfn() here.
> }
>
> static void kvm_unsync_page(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-20 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-19 15:03 [PATCH] KVM/X86: Remove unneeded variable Quanfa Fu
2021-12-20 9:27 ` Vitaly Kuznetsov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.