[PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()

* [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
@ 2020-11-12  3:21 Chris Packham
  2020-11-12  8:02 ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Chris Packham @ 2020-11-12  3:21 UTC (permalink / raw)
  To: akpm, rppt, thomas.petazzoni, arnd, jason; +Cc: linux-kernel, Chris Packham

make coccicheck complains:

  ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111

It took some staring but I don't think there is a problem because the
file global `mbus_state` is passed mvebu_mbus_common_init() as the
`mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
are the same thing. But this is confusing for anyone reading the code
and one less complaint from coccicheck would be nice so lets fix it.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
I haven't included

Fixes: fddddb52a6c4 ("bus: introduce an Marvell EBU MBus driver")

because that commit is quite old and it's probably not worth bothering
the stable trees with what is essentially a no-op.

 drivers/bus/mvebu-mbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 2519ceede64b..dd9e7343a5e3 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -1111,7 +1111,7 @@ static int __init mvebu_mbus_common_init(struct mvebu_mbus_state *mbus,
 
 	mbus->sdramwins_base = ioremap(sdramwins_phys_base, sdramwins_size);
 	if (!mbus->sdramwins_base) {
-		iounmap(mbus_state.mbuswins_base);
+		iounmap(mbus->mbuswins_base);
 		return -ENOMEM;
 	}
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread