From: "Aurélien Aptel" <aaptel@suse.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin King <colin.king@canonical.com>,
samba-technical@lists.samba.org, Steve French <sfrench@samba.org>,
kernel-janitors@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: remove redundant assignment to variable rc
Date: Wed, 31 Jul 2019 17:34:39 +0200 [thread overview]
Message-ID: <87lfwerze8.fsf@suse.com> (raw)
In-Reply-To: <20190731122841.GA1974@kadam>
"Dan Carpenter" <dan.carpenter@oracle.com> writes:
> You're just turning off GCC's static analysis (and introducing false
> positives) when you do that. We have seen bugs caused by this and never
> seen any bugs prevented by this style.
You've never seen bugs prevented by initializing uninitialized
variables? Code can change overtime and I don't think coverity is
checked as often as it could be, meaning the var could end up being used
while uninitialized in the future.
Anyway I won't die on this hill, merge this if you prefer.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: "Aurélien Aptel" <aaptel@suse.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin King <colin.king@canonical.com>,
samba-technical@lists.samba.org, Steve French <sfrench@samba.org>,
kernel-janitors@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: remove redundant assignment to variable rc
Date: Wed, 31 Jul 2019 15:34:39 +0000 [thread overview]
Message-ID: <87lfwerze8.fsf@suse.com> (raw)
In-Reply-To: <20190731122841.GA1974@kadam>
"Dan Carpenter" <dan.carpenter@oracle.com> writes:
> You're just turning off GCC's static analysis (and introducing false
> positives) when you do that. We have seen bugs caused by this and never
> seen any bugs prevented by this style.
You've never seen bugs prevented by initializing uninitialized
variables? Code can change overtime and I don't think coverity is
checked as often as it could be, meaning the var could end up being used
while uninitialized in the future.
Anyway I won't die on this hill, merge this if you prefer.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-07-31 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 9:05 [PATCH] cifs: remove redundant assignment to variable rc Colin King
2019-07-31 9:05 ` Colin King
2019-07-31 10:09 ` Aurélien Aptel
2019-07-31 10:09 ` Aurélien Aptel
2019-07-31 12:28 ` Dan Carpenter
2019-07-31 12:28 ` Dan Carpenter
2019-07-31 15:34 ` Aurélien Aptel [this message]
2019-07-31 15:34 ` Aurélien Aptel
2019-07-31 15:54 ` Colin Ian King
2019-07-31 15:54 ` Colin Ian King
2019-08-01 17:00 ` Steve French
2019-08-01 17:00 ` Steve French
2019-08-01 8:03 ` Dan Carpenter
2019-08-01 8:03 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfwerze8.fsf@suse.com \
--to=aaptel@suse.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.