All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] picocom: bump to version 2.2
@ 2017-05-03 12:46 Baruch Siach
  2017-05-03 12:46 ` [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS Baruch Siach
  2017-05-03 15:24 ` [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Peter Korsgaard
  0 siblings, 2 replies; 9+ messages in thread
From: Baruch Siach @ 2017-05-03 12:46 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/picocom/picocom.hash | 2 +-
 package/picocom/picocom.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/picocom/picocom.hash b/package/picocom/picocom.hash
index 674b6209d3bd..16db03e10485 100644
--- a/package/picocom/picocom.hash
+++ b/package/picocom/picocom.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 6b152fc5f816eaef6b86336a4cec7cf1496b7c712061e5aea5a36f143a0b09ed  picocom-2.1.tar.gz
+sha256 3e3904158d675541f0fcfdcd1f671b38445338f536080f5de8d6674b5f33d4ce  picocom-2.2.tar.gz
diff --git a/package/picocom/picocom.mk b/package/picocom/picocom.mk
index 8e77f1d425c4..07bda0e745cd 100644
--- a/package/picocom/picocom.mk
+++ b/package/picocom/picocom.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PICOCOM_VERSION = 2.1
+PICOCOM_VERSION = 2.2
 PICOCOM_SITE = $(call github,npat-efault,picocom,$(PICOCOM_VERSION))
 PICOCOM_LICENSE = GPL-2.0+
 PICOCOM_LICENSE_FILES = LICENSE.txt
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
  2017-05-03 12:46 [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Baruch Siach
@ 2017-05-03 12:46 ` Baruch Siach
  2017-05-03 14:22   ` Thomas Petazzoni
  2017-05-03 15:25   ` Peter Korsgaard
  2017-05-03 15:24 ` [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Peter Korsgaard
  1 sibling, 2 replies; 9+ messages in thread
From: Baruch Siach @ 2017-05-03 12:46 UTC (permalink / raw)
  To: buildroot

This allows a static build of picocom when BR2_STATIC_LIBS=y but the toolchain
provides static and shared libraries.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/picocom/picocom.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/picocom/picocom.mk b/package/picocom/picocom.mk
index 07bda0e745cd..4e25556f4c55 100644
--- a/package/picocom/picocom.mk
+++ b/package/picocom/picocom.mk
@@ -10,7 +10,8 @@ PICOCOM_LICENSE = GPL-2.0+
 PICOCOM_LICENSE_FILES = LICENSE.txt
 
 define PICOCOM_BUILD_CMDS
-	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		LDFLAGS="$(TARGET_LDFLAGS)" -C $(@D)
 endef
 
 define PICOCOM_INSTALL_TARGET_CMDS
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
  2017-05-03 12:46 ` [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS Baruch Siach
@ 2017-05-03 14:22   ` Thomas Petazzoni
  2017-05-03 14:28     ` Baruch Siach
  2017-05-03 15:25   ` Peter Korsgaard
  1 sibling, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2017-05-03 14:22 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed,  3 May 2017 15:46:35 +0300, Baruch Siach wrote:
> This allows a static build of picocom when BR2_STATIC_LIBS=y but the toolchain
> provides static and shared libraries.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/picocom/picocom.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/picocom/picocom.mk b/package/picocom/picocom.mk
> index 07bda0e745cd..4e25556f4c55 100644
> --- a/package/picocom/picocom.mk
> +++ b/package/picocom/picocom.mk
> @@ -10,7 +10,8 @@ PICOCOM_LICENSE = GPL-2.0+
>  PICOCOM_LICENSE_FILES = LICENSE.txt
>  
>  define PICOCOM_BUILD_CMDS
> -	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
> +		LDFLAGS="$(TARGET_LDFLAGS)" -C $(@D)

We already pass LDFLAGS in $(TARGET_CONFIGURE_OPTS). Should we pass
$(TARGET_CONFIGURE_OPTS) on the right hand side of $(MAKE) ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
  2017-05-03 14:22   ` Thomas Petazzoni
@ 2017-05-03 14:28     ` Baruch Siach
  0 siblings, 0 replies; 9+ messages in thread
From: Baruch Siach @ 2017-05-03 14:28 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

On Wed, May 03, 2017 at 04:22:44PM +0200, Thomas Petazzoni wrote:
> On Wed,  3 May 2017 15:46:35 +0300, Baruch Siach wrote:
> > This allows a static build of picocom when BR2_STATIC_LIBS=y but the toolchain
> > provides static and shared libraries.
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  package/picocom/picocom.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/package/picocom/picocom.mk b/package/picocom/picocom.mk
> > index 07bda0e745cd..4e25556f4c55 100644
> > --- a/package/picocom/picocom.mk
> > +++ b/package/picocom/picocom.mk
> > @@ -10,7 +10,8 @@ PICOCOM_LICENSE = GPL-2.0+
> >  PICOCOM_LICENSE_FILES = LICENSE.txt
> >  
> >  define PICOCOM_BUILD_CMDS
> > -	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
> > +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
> > +		LDFLAGS="$(TARGET_LDFLAGS)" -C $(@D)
> 
> We already pass LDFLAGS in $(TARGET_CONFIGURE_OPTS). Should we pass
> $(TARGET_CONFIGURE_OPTS) on the right hand side of $(MAKE) ?

That would overwrite CPPFLAGS that picocom Makefile uses for some seemingly 
useful macros.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] picocom: bump to version 2.2
  2017-05-03 12:46 [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Baruch Siach
  2017-05-03 12:46 ` [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS Baruch Siach
@ 2017-05-03 15:24 ` Peter Korsgaard
  1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2017-05-03 15:24 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
  2017-05-03 12:46 ` [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS Baruch Siach
  2017-05-03 14:22   ` Thomas Petazzoni
@ 2017-05-03 15:25   ` Peter Korsgaard
  2017-05-03 17:00     ` Baruch Siach
  1 sibling, 1 reply; 9+ messages in thread
From: Peter Korsgaard @ 2017-05-03 15:25 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > This allows a static build of picocom when BR2_STATIC_LIBS=y but the toolchain
 > provides static and shared libraries.

 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.

Is this only an issue for picocom 2.2, or also something we should
backport for the 2017.02.x branch?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
  2017-05-03 15:25   ` Peter Korsgaard
@ 2017-05-03 17:00     ` Baruch Siach
  2017-05-03 19:29       ` Peter Korsgaard
  0 siblings, 1 reply; 9+ messages in thread
From: Baruch Siach @ 2017-05-03 17:00 UTC (permalink / raw)
  To: buildroot

Hi Peter,

On Wed, May 03, 2017 at 05:25:52PM +0200, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> 
>  > This allows a static build of picocom when BR2_STATIC_LIBS=y but the toolchain
>  > provides static and shared libraries.
> 
>  > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> Committed, thanks.
> 
> Is this only an issue for picocom 2.2, or also something we should
> backport for the 2017.02.x branch?

Version 2.1 is also affected. But I'm not sure the issue is bad enough for a 
backport.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
  2017-05-03 17:00     ` Baruch Siach
@ 2017-05-03 19:29       ` Peter Korsgaard
  2017-05-05 19:35         ` Peter Korsgaard
  0 siblings, 1 reply; 9+ messages in thread
From: Peter Korsgaard @ 2017-05-03 19:29 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

Hi,

 >> Committed, thanks.
 >> 
 >> Is this only an issue for picocom 2.2, or also something we should
 >> backport for the 2017.02.x branch?

 > Version 2.1 is also affected. But I'm not sure the issue is bad enough for a 
 > backport.

Ok, thanks.

I think the risk of it breaking something is quite low, and it does fix
possible use cases, so it is imho a candidate for a backport.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
  2017-05-03 19:29       ` Peter Korsgaard
@ 2017-05-05 19:35         ` Peter Korsgaard
  0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2017-05-05 19:35 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
 > Hi,

 >>> Committed, thanks.
 >>> 
 >>> Is this only an issue for picocom 2.2, or also something we should
 >>> backport for the 2017.02.x branch?

 >> Version 2.1 is also affected. But I'm not sure the issue is bad enough for a 
 >> backport.

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-05-05 19:35 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 12:46 [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Baruch Siach
2017-05-03 12:46 ` [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS Baruch Siach
2017-05-03 14:22   ` Thomas Petazzoni
2017-05-03 14:28     ` Baruch Siach
2017-05-03 15:25   ` Peter Korsgaard
2017-05-03 17:00     ` Baruch Siach
2017-05-03 19:29       ` Peter Korsgaard
2017-05-05 19:35         ` Peter Korsgaard
2017-05-03 15:24 ` [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.