From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org, gang.wei@intel.com,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] tpm_crb: request and relinquish locality 0
Date: Fri, 24 Mar 2017 11:25:57 -0700 [thread overview]
Message-ID: <87lgru7cqy.fsf@redhat.com> (raw)
In-Reply-To: <20170324101032.13496-1-jarkko.sakkinen@iki.fi>
Jarkko Sakkinen @ 2017-03-24 10:10 GMT:
> This commit adds support for requesting and relinquishing locality 0 in
> tpm_crb for the course of command transmission.
>
> In order to achieve this, two new callbacks are added to struct
> tpm_class_ops:
>
> - request_locality
> - relinquish_locality
>
> With CRB interface you first set either requestAccess or relinquish bit
> from TPM_LOC_CTRL_x register and then wait for locAssigned and
> tpmRegValidSts bits to be set in the TPM_LOC_STATE_x register.
>
> The reason why were are doing this is to make sure that the driver
> will work properly with Intel TXT that uses locality 2. There's no
> explicit guarantee that it would relinquish this locality. In more
> general sense this commit enables tpm_crb to be a well behaving
> citizen in a multi locality environment.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Tested-by: Jerry Snitselaar <jsnitsel@redhat.com>
Tested on kabylake system that was hitting issues with earlier
iteration. Still don't have platform to test it dealing with
multi-locality enviroment.
WARNING: multiple messages have this Message-ID (diff)
From: jsnitsel@redhat.com (Jerry Snitselaar)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v4] tpm_crb: request and relinquish locality 0
Date: Fri, 24 Mar 2017 11:25:57 -0700 [thread overview]
Message-ID: <87lgru7cqy.fsf@redhat.com> (raw)
In-Reply-To: <20170324101032.13496-1-jarkko.sakkinen@iki.fi>
Jarkko Sakkinen @ 2017-03-24 10:10 GMT:
> This commit adds support for requesting and relinquishing locality 0 in
> tpm_crb for the course of command transmission.
>
> In order to achieve this, two new callbacks are added to struct
> tpm_class_ops:
>
> - request_locality
> - relinquish_locality
>
> With CRB interface you first set either requestAccess or relinquish bit
> from TPM_LOC_CTRL_x register and then wait for locAssigned and
> tpmRegValidSts bits to be set in the TPM_LOC_STATE_x register.
>
> The reason why were are doing this is to make sure that the driver
> will work properly with Intel TXT that uses locality 2. There's no
> explicit guarantee that it would relinquish this locality. In more
> general sense this commit enables tpm_crb to be a well behaving
> citizen in a multi locality environment.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Tested-by: Jerry Snitselaar <jsnitsel@redhat.com>
Tested on kabylake system that was hitting issues with earlier
iteration. Still don't have platform to test it dealing with
multi-locality enviroment.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jerry Snitselaar <jsnitsel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jarkko Sakkinen <jarkko.sakkinen-X3B1VOXEql0@public.gmane.org>
Cc: open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
gang.wei-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4] tpm_crb: request and relinquish locality 0
Date: Fri, 24 Mar 2017 11:25:57 -0700 [thread overview]
Message-ID: <87lgru7cqy.fsf@redhat.com> (raw)
In-Reply-To: <20170324101032.13496-1-jarkko.sakkinen-X3B1VOXEql0@public.gmane.org>
Jarkko Sakkinen @ 2017-03-24 10:10 GMT:
> This commit adds support for requesting and relinquishing locality 0 in
> tpm_crb for the course of command transmission.
>
> In order to achieve this, two new callbacks are added to struct
> tpm_class_ops:
>
> - request_locality
> - relinquish_locality
>
> With CRB interface you first set either requestAccess or relinquish bit
> from TPM_LOC_CTRL_x register and then wait for locAssigned and
> tpmRegValidSts bits to be set in the TPM_LOC_STATE_x register.
>
> The reason why were are doing this is to make sure that the driver
> will work properly with Intel TXT that uses locality 2. There's no
> explicit guarantee that it would relinquish this locality. In more
> general sense this commit enables tpm_crb to be a well behaving
> citizen in a multi locality environment.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Reviewed-by: Jerry Snitselaar <jsnitsel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Tested-by: Jerry Snitselaar <jsnitsel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Tested on kabylake system that was hitting issues with earlier
iteration. Still don't have platform to test it dealing with
multi-locality enviroment.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-03-24 18:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 10:10 [PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen
2017-03-24 10:10 ` Jarkko Sakkinen
2017-03-24 10:10 ` Jarkko Sakkinen
2017-03-24 10:19 ` Jarkko Sakkinen
2017-03-24 10:19 ` Jarkko Sakkinen
2017-03-24 10:19 ` Jarkko Sakkinen
2017-03-25 12:21 ` Jerry Snitselaar
2017-03-25 12:21 ` Jerry Snitselaar
2017-03-25 19:50 ` Jarkko Sakkinen
2017-03-25 19:50 ` Jarkko Sakkinen
2017-03-24 18:25 ` Jerry Snitselaar [this message]
2017-03-24 18:25 ` Jerry Snitselaar
2017-03-24 18:25 ` Jerry Snitselaar
2017-03-25 19:52 ` Jarkko Sakkinen
2017-03-25 19:52 ` Jarkko Sakkinen
2017-03-25 19:52 ` Jarkko Sakkinen
2017-03-26 10:52 ` Jarkko Sakkinen
2017-03-26 10:52 ` Jarkko Sakkinen
2017-03-26 10:52 ` Jarkko Sakkinen
2017-03-26 16:39 ` Jerry Snitselaar
2017-03-26 16:39 ` Jerry Snitselaar
2017-03-26 19:51 ` Jarkko Sakkinen
2017-03-26 19:51 ` Jarkko Sakkinen
2017-03-26 22:42 ` Jerry Snitselaar
2017-03-26 22:42 ` Jerry Snitselaar
2017-03-26 22:42 ` Jerry Snitselaar
2017-03-27 5:17 ` Jarkko Sakkinen
2017-03-27 5:17 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgru7cqy.fsf@redhat.com \
--to=jsnitsel@redhat.com \
--cc=gang.wei@intel.com \
--cc=jarkko.sakkinen@iki.fi \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.