* [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12
@ 2013-08-05 18:11 Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 1/7] ARM: keystone: drop useless HAVE_SCHED_CLOCK Santosh Shilimkar
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Here are few non-critical fixes, cleanups for the Keystone SOCs
targeted for 3.12 merge window.
Brief summary of changes:
- Drop unused HAVE_SCHED_CLOCK config option
- Remove now redundant keystone_cpu_smc() call
- Update the smc code to remove dsb and r12 usage
- Convert device tree to use #include and GIC bindings
- Update the MAINTAINER file.
Boot tested on Kesytone 2 EVM.
Paul Bolle (1):
ARM: keystone: drop useless HAVE_SCHED_CLOCK
Santosh Shilimkar (5):
ARM: Keystone: No need to preserve r12 across smc call
ARM: keystone: Drop the un-necessary dsb from keystone_cpu_smc()
ARM: keystone: use #include to include skeleton.dtsi
ARM: Keystone: Convert device tree file to use IRQ defines
MAINTAINERS: add TI Keystone ARM platform
Sudeep KarkadaNagesha (1):
ARM: keystone: remove redundant smp_init_cpus definition
MAINTAINERS | 6 ++++++
arch/arm/boot/dts/keystone.dts | 29 ++++++++++++++++++-----------
arch/arm/mach-keystone/Kconfig | 1 -
arch/arm/mach-keystone/platsmp.c | 1 -
arch/arm/mach-keystone/smc.S | 5 ++---
5 files changed, 26 insertions(+), 16 deletions(-)
Regards,
Santosh
--
1.7.9.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH 1/7] ARM: keystone: drop useless HAVE_SCHED_CLOCK
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
@ 2013-08-05 18:11 ` Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 2/7] ARM: keystone: remove redundant smp_init_cpus definition Santosh Shilimkar
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
From: Paul Bolle <pebolle@tiscali.nl>
The Kconfig symbol HAVE_SCHED_CLOCK got removed in v3.4,
with commit 6905a65879b5 ("ARM: Make the sched_clock
framework mandatory"). But a select statement for it popped up again
through commit 828989ad87af ("ARM: keystone: Add minimal TI Keystone
platform support"). Drop that statement, as it is useless.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
[santosh.shilimkar at ti.com: Minor edit in the subject]
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-keystone/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
index 51a50e9..366d1a3 100644
--- a/arch/arm/mach-keystone/Kconfig
+++ b/arch/arm/mach-keystone/Kconfig
@@ -7,7 +7,6 @@ config ARCH_KEYSTONE
select HAVE_SMP
select CLKSRC_MMIO
select GENERIC_CLOCKEVENTS
- select HAVE_SCHED_CLOCK
select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_ERRATA_798181 if SMP
help
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH 2/7] ARM: keystone: remove redundant smp_init_cpus definition
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 1/7] ARM: keystone: drop useless HAVE_SCHED_CLOCK Santosh Shilimkar
@ 2013-08-05 18:11 ` Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 3/7] ARM: Keystone: No need to preserve r12 across smc call Santosh Shilimkar
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
From: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
arm_dt_init_cpu_maps is called before smp_init_cpus. It makes the
platform/SoC definition of smp_init_cpus unnecessary.
Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-keystone/platsmp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-keystone/platsmp.c b/arch/arm/mach-keystone/platsmp.c
index 14378e3..c122961 100644
--- a/arch/arm/mach-keystone/platsmp.c
+++ b/arch/arm/mach-keystone/platsmp.c
@@ -38,6 +38,5 @@ static int keystone_smp_boot_secondary(unsigned int cpu,
}
struct smp_operations keystone_smp_ops __initdata = {
- .smp_init_cpus = arm_dt_init_cpu_maps,
.smp_boot_secondary = keystone_smp_boot_secondary,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH 3/7] ARM: Keystone: No need to preserve r12 across smc call
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 1/7] ARM: keystone: drop useless HAVE_SCHED_CLOCK Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 2/7] ARM: keystone: remove redundant smp_init_cpus definition Santosh Shilimkar
@ 2013-08-05 18:11 ` Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 4/7] ARM: keystone: Drop the un-necessary dsb from keystone_cpu_smc() Santosh Shilimkar
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Register r12 is caller-save, so no need preserve it keystone_cpu_smc().
Reported-by: Dave Martin <dave.martin@linaro.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-keystone/smc.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-keystone/smc.S b/arch/arm/mach-keystone/smc.S
index 9b9e4f7..5bb5176 100644
--- a/arch/arm/mach-keystone/smc.S
+++ b/arch/arm/mach-keystone/smc.S
@@ -22,8 +22,8 @@
* Return: Non zero value on failure
*/
ENTRY(keystone_cpu_smc)
- stmfd sp!, {r4-r12, lr}
+ stmfd sp!, {r4-r11, lr}
smc #0
dsb
- ldmfd sp!, {r4-r12, pc}
+ ldmfd sp!, {r4-r11, pc}
ENDPROC(keystone_cpu_smc)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH 4/7] ARM: keystone: Drop the un-necessary dsb from keystone_cpu_smc()
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
` (2 preceding siblings ...)
2013-08-05 18:11 ` [RESEND PATCH 3/7] ARM: Keystone: No need to preserve r12 across smc call Santosh Shilimkar
@ 2013-08-05 18:11 ` Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 5/7] ARM: keystone: use #include to include skeleton.dtsi Santosh Shilimkar
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
This was added because of some legacy reasons from OMAP SOCs but
after testing and verifying with the keystone hardware folks, the
dsb in keystone_cpu_smc() is not necessary.
So drop it.
Reported-by: Dave Martin <dave.martin@linaro.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-keystone/smc.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-keystone/smc.S b/arch/arm/mach-keystone/smc.S
index 5bb5176..d15de81 100644
--- a/arch/arm/mach-keystone/smc.S
+++ b/arch/arm/mach-keystone/smc.S
@@ -24,6 +24,5 @@
ENTRY(keystone_cpu_smc)
stmfd sp!, {r4-r11, lr}
smc #0
- dsb
ldmfd sp!, {r4-r11, pc}
ENDPROC(keystone_cpu_smc)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH 5/7] ARM: keystone: use #include to include skeleton.dtsi
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
` (3 preceding siblings ...)
2013-08-05 18:11 ` [RESEND PATCH 4/7] ARM: keystone: Drop the un-necessary dsb from keystone_cpu_smc() Santosh Shilimkar
@ 2013-08-05 18:11 ` Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 6/7] ARM: Keystone: Convert device tree file to use IRQ defines Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 7/7] MAINTAINERS: add TI Keystone ARM platform Santosh Shilimkar
6 siblings, 0 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Replace /include/ (dtc) with #include (C pre-processor) to
include skeleton.dtsi
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/boot/dts/keystone.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/keystone.dts b/arch/arm/boot/dts/keystone.dts
index 1334b42..612ba8c 100644
--- a/arch/arm/boot/dts/keystone.dts
+++ b/arch/arm/boot/dts/keystone.dts
@@ -7,7 +7,7 @@
*/
/dts-v1/;
-/include/ "skeleton.dtsi"
+#include "skeleton.dtsi"
/ {
model = "Texas Instruments Keystone 2 SoC";
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH 6/7] ARM: Keystone: Convert device tree file to use IRQ defines
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
` (4 preceding siblings ...)
2013-08-05 18:11 ` [RESEND PATCH 5/7] ARM: keystone: use #include to include skeleton.dtsi Santosh Shilimkar
@ 2013-08-05 18:11 ` Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 7/7] MAINTAINERS: add TI Keystone ARM platform Santosh Shilimkar
6 siblings, 0 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Use the GIC and standard IRQ binding defines in all IRQ specifiers.
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/boot/dts/keystone.dts | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/keystone.dts b/arch/arm/boot/dts/keystone.dts
index 612ba8c..a68e34b 100644
--- a/arch/arm/boot/dts/keystone.dts
+++ b/arch/arm/boot/dts/keystone.dts
@@ -7,6 +7,8 @@
*/
/dts-v1/;
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
#include "skeleton.dtsi"
/ {
@@ -67,18 +69,23 @@
timer {
compatible = "arm,armv7-timer";
- interrupts = <1 13 0xf08>,
- <1 14 0xf08>,
- <1 11 0xf08>,
- <1 10 0x308>;
+ interrupts =
+ <GIC_PPI 13
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 14
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 11
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 10
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
};
pmu {
compatible = "arm,cortex-a15-pmu";
- interrupts = <0 20 0xf01>,
- <0 21 0xf01>,
- <0 22 0xf01>,
- <0 23 0xf01>;
+ interrupts = <GIC_SPI 20 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 21 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 22 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 23 IRQ_TYPE_EDGE_RISING>;
};
soc {
@@ -100,7 +107,7 @@
reg-io-width = <4>;
reg = <0x02530c00 0x100>;
clock-frequency = <133120000>;
- interrupts = <0 277 0xf01>;
+ interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;
};
uart1: serial at 02531000 {
@@ -110,7 +117,7 @@
reg-io-width = <4>;
reg = <0x02531000 0x100>;
clock-frequency = <133120000>;
- interrupts = <0 280 0xf01>;
+ interrupts = <GIC_SPI 280 IRQ_TYPE_EDGE_RISING>;
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH 7/7] MAINTAINERS: add TI Keystone ARM platform
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
` (5 preceding siblings ...)
2013-08-05 18:11 ` [RESEND PATCH 6/7] ARM: Keystone: Convert device tree file to use IRQ defines Santosh Shilimkar
@ 2013-08-05 18:11 ` Santosh Shilimkar
2013-08-07 17:49 ` Kevin Hilman
6 siblings, 1 reply; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-05 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Adding maintainer for arch/arm/mach-keystone/
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index bf61e04..b24a96e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -965,6 +965,12 @@ M: Lennert Buytenhek <kernel@wantstofly.org>
L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S: Maintained
+ARM/TEXAS INSTRUMENT KEYSTONE ARCHITECTURE
+M: Santosh Shilimkar <santosh.shilimkar@ti.com>
+L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
+S: Maintained
+F: arch/arm/mach-keystone/
+
ARM/LOGICPD PXA270 MACHINE SUPPORT
M: Lennert Buytenhek <kernel@wantstofly.org>
L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH 7/7] MAINTAINERS: add TI Keystone ARM platform
2013-08-05 18:11 ` [RESEND PATCH 7/7] MAINTAINERS: add TI Keystone ARM platform Santosh Shilimkar
@ 2013-08-07 17:49 ` Kevin Hilman
2013-08-07 18:50 ` Santosh Shilimkar
0 siblings, 1 reply; 10+ messages in thread
From: Kevin Hilman @ 2013-08-07 17:49 UTC (permalink / raw)
To: linux-arm-kernel
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> Adding maintainer for arch/arm/mach-keystone/
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Since I'm colleting some MAINTAINERS changes, I applied this one to
arm-soc/fixes.
The rest of the series looks good to me. Are you still waiting for any
more feedback? If not, are you planning to send a pull request? or
I could just apply 1-6 for fixes-non-critical.
Kevin
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH 7/7] MAINTAINERS: add TI Keystone ARM platform
2013-08-07 17:49 ` Kevin Hilman
@ 2013-08-07 18:50 ` Santosh Shilimkar
0 siblings, 0 replies; 10+ messages in thread
From: Santosh Shilimkar @ 2013-08-07 18:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 07 August 2013 01:49 PM, Kevin Hilman wrote:
> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>
>> Adding maintainer for arch/arm/mach-keystone/
>>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Since I'm colleting some MAINTAINERS changes, I applied this one to
> arm-soc/fixes.
>
Thanks
> The rest of the series looks good to me. Are you still waiting for any
> more feedback? If not, are you planning to send a pull request? or
> I could just apply 1-6 for fixes-non-critical.
>
I will send a pull request dropping the last patch which you already
applied.
Regards,
Santosh
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-08-07 18:50 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-05 18:11 [RESEND PATCH 0/7] ARM: keystone: Few non-critical fixes, cleanups for 3.12 Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 1/7] ARM: keystone: drop useless HAVE_SCHED_CLOCK Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 2/7] ARM: keystone: remove redundant smp_init_cpus definition Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 3/7] ARM: Keystone: No need to preserve r12 across smc call Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 4/7] ARM: keystone: Drop the un-necessary dsb from keystone_cpu_smc() Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 5/7] ARM: keystone: use #include to include skeleton.dtsi Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 6/7] ARM: Keystone: Convert device tree file to use IRQ defines Santosh Shilimkar
2013-08-05 18:11 ` [RESEND PATCH 7/7] MAINTAINERS: add TI Keystone ARM platform Santosh Shilimkar
2013-08-07 17:49 ` Kevin Hilman
2013-08-07 18:50 ` Santosh Shilimkar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.