[Buildroot] [PATCH v3 0/5] Configure default wifi through kconfig

[Buildroot] [PATCH v3 0/5] Configure default wifi through kconfig

[Angelo Compagnucci]

This series was born while adding support for a board and feeling the
necessity to have the networking options available in .config.
I understand that something like that could be done by adding an
overlay, but it requires a lot of boilerplate only to be able to connect
to a wifi network.

Angelo Compagnucci (5):
  system: adding options for configuring wifi
  package/wpa_supplicant: configure wifi on systemv when enabled
  package/wpa_supplicant: configure wifi on systemd when enabled
  package/ifupdown-scripts: add wifi configuration when enabled
  package/initscripts: add service to load kernel modules at boot

 package/ifupdown-scripts/ifupdown-scripts.mk |  2 +
 package/initscripts/init.d/S11modules        | 59 ++++++++++++++++++++
 package/wpa_supplicant/wpa_supplicant.mk     | 24 ++++++++
 system/Config.in                             | 16 ++++++
 4 files changed, 101 insertions(+)
 create mode 100644 package/initscripts/init.d/S11modules

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi

[Angelo Compagnucci]

These options can be used by packages to configure a wifi card
to connect at boot.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
 system/Config.in | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/system/Config.in b/system/Config.in
index 888c24ce81..9a5bdb2932 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -418,6 +418,21 @@ comment "automatic network configuration via DHCP needs ifupdown or busybox or n
 	depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN || \
 		BR2_PACKAGE_SYSTEMD_NETWORKD || BR2_PACKAGE_NETIFRC)
 
+config BR2_SYSTEM_CONNECT_WIFI
+	bool "Connect to a default wifi access point"
+	default n
+	depends on BR2_PACKAGE_WPA_SUPPLICANT
+
+config BR2_SYSTEM_CONNECT_WIFI_SSID
+	string "Access point SSID"
+	default ""
+	depends on BR2_SYSTEM_CONNECT_WIFI
+
+config BR2_SYSTEM_CONNECT_WIFI_PASSWORD
+	string "Access point password"
+	default ""
+	depends on BR2_SYSTEM_CONNECT_WIFI
+
 endif # BR2_ROOTFS_SKELETON_DEFAULT
 
 config BR2_SYSTEM_DEFAULT_PATH
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 2/5] package/wpa_supplicant: configure wifi on systemv when enabled

[Angelo Compagnucci]

Configure a default basic wifi setup able to automatically connect to
the selected access point.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
 package/wpa_supplicant/wpa_supplicant.mk | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index afcd6502e3..09971654fe 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -264,6 +264,19 @@ define WPA_SUPPLICANT_INSTALL_IFUP_SCRIPTS
 endef
 endif
 
+ifeq ($(BR2_SYSTEM_CONNECT_WIFI),y)
+define WPA_SUPPLICANT_ENABLE_WIFI
+	$(SED) '/network={/,/}/d' $(TARGET_DIR)/etc/wpa_supplicant.conf; \
+	(	echo "network={"; \
+		echo "  scan_ssid=1"; \
+		echo "  key_mgmt=WPA-PSK"; \
+		echo "  ssid=\"$(BR2_SYSTEM_CONNECT_WIFI_SSID)\""; \
+		echo "  psk=\"$(BR2_SYSTEM_CONNECT_WIFI_PASSWORD)\""; \
+		echo "}"; \
+	) >> $(TARGET_DIR)/etc/wpa_supplicant.conf
+endef
+endif
+
 define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
 	$(INSTALL) -m 0755 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/wpa_supplicant \
 		$(TARGET_DIR)/usr/sbin/wpa_supplicant
@@ -275,6 +288,7 @@ define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
 	$(WPA_SUPPLICANT_INSTALL_WPA_CLIENT_SO)
 	$(WPA_SUPPLICANT_INSTALL_IFUP_SCRIPTS)
 	$(WPA_SUPPLICANT_ENABLE_CTRL_IFACE)
+	$(WPA_SUPPLICANT_ENABLE_WIFI)
 endef
 
 define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 3/5] package/wpa_supplicant: configure wifi on systemd when enabled

[Angelo Compagnucci]

Configure a default basic wifi setup able to automatically connect
to the selected access point.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
 package/wpa_supplicant/wpa_supplicant.mk | 10 ++++++++++
 system/Config.in                         |  1 +
 2 files changed, 11 insertions(+)

diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index 09971654fe..157d45ee7f 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -275,6 +275,15 @@ define WPA_SUPPLICANT_ENABLE_WIFI
 		echo "}"; \
 	) >> $(TARGET_DIR)/etc/wpa_supplicant.conf
 endef
+define WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/wpa_supplicant/
+	ln -sf ../wpa_supplicant.conf \
+		$(TARGET_DIR)/etc/wpa_supplicant/wpa_supplicant-$(BR2_SYSTEM_DHCP).conf
+endef
+define WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD_PRESET
+	$(HOST_DIR)/bin/systemctl --root=$(TARGET_DIR) preset wpa_supplicant\@$(BR2_SYSTEM_DHCP).service
+endef
+SYSTEMD_ROOTFS_PRE_CMD_HOOKS += WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD_PRESET
 endif
 
 define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
@@ -302,6 +311,7 @@ define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
 		$(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-wired@.service
 	$(INSTALL) -D -m 644 $(WPA_SUPPLICANT_PKGDIR)/50-wpa_supplicant.preset \
 		$(TARGET_DIR)/usr/lib/systemd/system-preset/50-wpa_supplicant.preset
+	$(WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD)
 endef
 
 $(eval $(generic-package))
diff --git a/system/Config.in b/system/Config.in
index 9a5bdb2932..084340b1a4 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -422,6 +422,7 @@ config BR2_SYSTEM_CONNECT_WIFI
 	bool "Connect to a default wifi access point"
 	default n
 	depends on BR2_PACKAGE_WPA_SUPPLICANT
+	select BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE if BR2_PACKAGE_SYSTEMD
 
 config BR2_SYSTEM_CONNECT_WIFI_SSID
 	string "Access point SSID"
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 4/5] package/ifupdown-scripts: add wifi configuration when enabled

[Angelo Compagnucci]

Add a proper wpa-conf line to the interfaces files to let the system
bringup the wifi interface and the related wpa supplicant.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
Changes:
v3:
* add "|| true" lo let the command exit without error when
  BR2_SYSTEM_CONNECT_WIFI is empty (me)

 package/ifupdown-scripts/ifupdown-scripts.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk
index 5ef032142c..ebaf234143 100644
--- a/package/ifupdown-scripts/ifupdown-scripts.mk
+++ b/package/ifupdown-scripts/ifupdown-scripts.mk
@@ -28,6 +28,8 @@ define IFUPDOWN_SCRIPTS_DHCP
 		echo "  pre-up /etc/network/nfs_check"; \
 		echo "  wait-delay 15"; \
 		echo "  hostname \$$(hostname)"; \
+		test -n "$(BR2_SYSTEM_CONNECT_WIFI)" && \
+			echo "  wpa-conf /etc/wpa_supplicant.conf" || true; \
 	) >> $(TARGET_DIR)/etc/network/interfaces
 endef
 define IFUPDOWN_SCRIPTS_DHCP_OPENRC
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 5/5] package/initscripts: add service to load kernel modules at boot

[Angelo Compagnucci]

In cases where no hotplug is available (by choice or by the lack of a
proper hotplug method for a device), this service can be used to load
kernel module drivers by reading the /etc/modules file.
The modules files matches the one used by systemd, which in turn has
a builtin mechanism to load a module at boot, therefore making systemv
init on par with systemd features.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
Changes

v2:
* Moved script to initscripts (Arnout)
* Moved script to S11modules, after S10[mu]dev (Andreas)
* Use /etc/modules-load.d/ to share the same setup with systemd (me)

 package/initscripts/init.d/S11modules | 59 +++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 package/initscripts/init.d/S11modules

diff --git a/package/initscripts/init.d/S11modules b/package/initscripts/init.d/S11modules
new file mode 100644
index 0000000000..3937945596
--- /dev/null
+++ b/package/initscripts/init.d/S11modules
@@ -0,0 +1,59 @@
+#!/bin/sh
+
+MODULES="*.conf"
+MODULES_DIR="/etc/modules-load.d"
+
+[ -z "$(ls -A ${MODULES_DIR}/${MODULES} 2> /dev/null)" ] && exit 0
+
+load_unload() {
+	for module_file in $(ls -1 ${MODULES_DIR}); do
+		while read module args; do
+
+			case "$module" in
+				""|"#"*) continue ;;
+			esac
+
+			if [ "$1" = "load" ]; then
+				modprobe -q ${module} ${args} >/dev/null && \
+					printf ' %s success,' "$module" ||
+					printf ' %s failed,' "$module"
+			else
+				rmmod ${module} >/dev/null
+			fi
+
+		done < ${MODULES_DIR}/${module_file}
+	done
+}
+
+start() {
+	printf 'Starting modules:'
+
+	load_unload load
+
+	echo ' OK'
+}
+
+stop() {
+	printf 'Stopping modules:'
+
+	load_unload unload
+
+	echo 'OK'
+}
+
+restart() {
+	stop
+	sleep 1
+	start
+}
+
+case "$1" in
+	start|stop|restart)
+		"$1";;
+	reload)
+		# Restart, since there is no true "reload" feature.
+		restart;;
+	*)
+		echo "Usage: $0 {start|stop|restart|reload}"
+		exit 1
+esac
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi

[Peter Korsgaard]

>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:

 > These options can be used by packages to configure a wifi card
 > to connect at boot.

 > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
 > ---
 >  system/Config.in | 15 +++++++++++++++
 >  1 file changed, 15 insertions(+)

 > diff --git a/system/Config.in b/system/Config.in
 > index 888c24ce81..9a5bdb2932 100644
 > --- a/system/Config.in
 > +++ b/system/Config.in
 > @@ -418,6 +418,21 @@ comment "automatic network configuration via DHCP needs ifupdown or busybox or n
 >  	depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN || \
 >  		BR2_PACKAGE_SYSTEMD_NETWORKD || BR2_PACKAGE_NETIFRC)
 
 > +config BR2_SYSTEM_CONNECT_WIFI
 > +	bool "Connect to a default wifi access point"
 > +	default n

'n' is default, so drop that. This doesn't really do anything unless the
user also configures BR2_SYSTEM_DHCP="wlan0", right?

I must say I am not really convinced. This is only useful for quite
specific setups (E.G. a lot more specific than BR2_SYSTEM_DHCP which we
use in a number of defconfigs) and hard codes a number of things (like
WPA-PSK that may or may not make sense in the future).

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 3/5] package/wpa_supplicant: configure wifi on systemd when enabled

[Peter Korsgaard]

>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:

 > Configure a default basic wifi setup able to automatically connect
 > to the selected access point.

 > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
 > ---
 >  package/wpa_supplicant/wpa_supplicant.mk | 10 ++++++++++
 >  system/Config.in                         |  1 +
 >  2 files changed, 11 insertions(+)

 > diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
 > index 09971654fe..157d45ee7f 100644
 > --- a/package/wpa_supplicant/wpa_supplicant.mk
 > +++ b/package/wpa_supplicant/wpa_supplicant.mk
 > @@ -275,6 +275,15 @@ define WPA_SUPPLICANT_ENABLE_WIFI
 >  		echo "}"; \
 >  	) >> $(TARGET_DIR)/etc/wpa_supplicant.conf
 >  endef
 > +define WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD
 > +	$(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/wpa_supplicant/
 > +	ln -sf ../wpa_supplicant.conf \
 > +		$(TARGET_DIR)/etc/wpa_supplicant/wpa_supplicant-$(BR2_SYSTEM_DHCP).conf

How do you know BR2_SYSTEM_DHCP is set to something sensible here?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 4/5] package/ifupdown-scripts: add wifi configuration when enabled

[Peter Korsgaard]

>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:

 > Add a proper wpa-conf line to the interfaces files to let the system
 > bringup the wifi interface and the related wpa supplicant.

 > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
 > ---
 > Changes:
 > v3:
 > * add "|| true" lo let the command exit without error when
 >   BR2_SYSTEM_CONNECT_WIFI is empty (me)

 >  package/ifupdown-scripts/ifupdown-scripts.mk | 2 ++
 >  1 file changed, 2 insertions(+)

 > diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk
 > index 5ef032142c..ebaf234143 100644
 > --- a/package/ifupdown-scripts/ifupdown-scripts.mk
 > +++ b/package/ifupdown-scripts/ifupdown-scripts.mk
 > @@ -28,6 +28,8 @@ define IFUPDOWN_SCRIPTS_DHCP
 >  		echo "  pre-up /etc/network/nfs_check"; \
 >  		echo "  wait-delay 15"; \
 >  		echo "  hostname \$$(hostname)"; \
 > +		test -n "$(BR2_SYSTEM_CONNECT_WIFI)" && \
 > +			echo "  wpa-conf /etc/wpa_supplicant.conf" || true; \
 >  	) >> $(TARGET_DIR)/etc/network/interfaces

Maybe we should do this unconditionally if we overwrite
/etc/network/interfaces and wpa_supplicant is enabled?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 5/5] package/initscripts: add service to load kernel modules at boot

[Peter Korsgaard]

>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:

 > In cases where no hotplug is available (by choice or by the lack of a
 > proper hotplug method for a device), this service can be used to load
 > kernel module drivers by reading the /etc/modules file.
 > The modules files matches the one used by systemd, which in turn has
 > a builtin mechanism to load a module at boot, therefore making systemv
 > init on par with systemd features.

 > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
 > ---
 > Changes

 > v2:
 > * Moved script to initscripts (Arnout)
 > * Moved script to S11modules, after S10[mu]dev (Andreas)
 > * Use /etc/modules-load.d/ to share the same setup with systemd (me)

 >  package/initscripts/init.d/S11modules | 59 +++++++++++++++++++++++++++
 >  1 file changed, 59 insertions(+)
 >  create mode 100644 package/initscripts/init.d/S11modules

 > diff --git a/package/initscripts/init.d/S11modules b/package/initscripts/init.d/S11modules
 > new file mode 100644
 > index 0000000000..3937945596
 > --- /dev/null
 > +++ b/package/initscripts/init.d/S11modules
 > @@ -0,0 +1,59 @@
 > +#!/bin/sh
 > +
 > +MODULES="*.conf"
 > +MODULES_DIR="/etc/modules-load.d"
 > +
 > +[ -z "$(ls -A ${MODULES_DIR}/${MODULES} 2> /dev/null)" ] && exit 0

The commit message talks about /etc/modules, but you are reading from
/etc/modules-load.d/*.conf?

How about supporting both /etc/modules and this directory instead?


 > +
 > +load_unload() {
 > +	for module_file in $(ls -1 ${MODULES_DIR}); do

And here you take all files in /etc/modules-load.d, even if they don't
have a .conf extension?


> +			esac
 > +
 > +			if [ "$1" = "load" ]; then
 > +				modprobe -q ${module} ${args} >/dev/null && \
 > +					printf ' %s success,' "$module" ||
 > +					printf ' %s failed,' "$module"

success/failed are quite long strings, how about only printing the
module name on success and a big scary FAIL like we do elsewhere on
failures?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi

[Angelo Compagnucci]

[-- Attachment #1.1: Type: text/plain, Size: 2372 bytes --]

On Sun, Sep 18, 2022 at 11:57 AM Peter Korsgaard <peter@korsgaard.com>
wrote:

> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
>
>  > These options can be used by packages to configure a wifi card
>  > to connect at boot.
>
>  > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>  > ---
>  >  system/Config.in | 15 +++++++++++++++
>  >  1 file changed, 15 insertions(+)
>
>  > diff --git a/system/Config.in b/system/Config.in
>  > index 888c24ce81..9a5bdb2932 100644
>  > --- a/system/Config.in
>  > +++ b/system/Config.in
>  > @@ -418,6 +418,21 @@ comment "automatic network configuration via DHCP
> needs ifupdown or busybox or n
>  >      depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN || \
>  >              BR2_PACKAGE_SYSTEMD_NETWORKD || BR2_PACKAGE_NETIFRC)
>
>  > +config BR2_SYSTEM_CONNECT_WIFI
>  > +    bool "Connect to a default wifi access point"
>  > +    default n
>
> 'n' is default, so drop that.


Right.


> This doesn't really do anything unless the
> user also configures BR2_SYSTEM_DHCP="wlan0", right?
>

Right.


>
> I must say I am not really convinced. This is only useful for quite
> specific setups (E.G. a lot more specific than BR2_SYSTEM_DHCP which we
> use in a number of defconfigs) and hard codes a number of things (like
> WPA-PSK that may or may not make sense in the future).
>

This is what we have now on several readme.txt on how to connect to a wifi

WiFi
====

 # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf
   (type password and enter)
 # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B
 # udhcpc -i wlan0

I don't think this is nice.

I'd like to see something like that:

WiFi
====

# Enable BR2_SYSTEM_CONNECT_WIFI configure option
# Set the Wifi SSID with the option BR2_SYSTEM_CONNECT_WIFI_SSID
# Set the password with the option BR2_SYSTEM_CONNECT_WIFI_PASSWORD

Nicer and easier. I know that the wpa-psk could change in the feature, but
then we can change to whatever default mechanism will be in place at that
moment.


>
> --
> Bye, Peter Korsgaard
>


-- 

Angelo Compagnucci

Software Engineer

angelo@amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

[-- Attachment #1.2: Type: text/html, Size: 7524 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 3/5] package/wpa_supplicant: configure wifi on systemd when enabled

[Angelo Compagnucci]

[-- Attachment #1.1: Type: text/plain, Size: 1713 bytes --]

On Sun, Sep 18, 2022 at 12:00 PM Peter Korsgaard <peter@korsgaard.com>
wrote:

> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
>
>  > Configure a default basic wifi setup able to automatically connect
>  > to the selected access point.
>
>  > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>  > ---
>  >  package/wpa_supplicant/wpa_supplicant.mk | 10 ++++++++++
>  >  system/Config.in                         |  1 +
>  >  2 files changed, 11 insertions(+)
>
>  > diff --git a/package/wpa_supplicant/wpa_supplicant.mk
> b/package/wpa_supplicant/wpa_supplicant.mk
>  > index 09971654fe..157d45ee7f 100644
>  > --- a/package/wpa_supplicant/wpa_supplicant.mk
>  > +++ b/package/wpa_supplicant/wpa_supplicant.mk
>  > @@ -275,6 +275,15 @@ define WPA_SUPPLICANT_ENABLE_WIFI
>  >              echo "}"; \
>  >      ) >> $(TARGET_DIR)/etc/wpa_supplicant.conf
>  >  endef
>  > +define WPA_SUPPLICANT_WIFI_INSTALL_INIT_SYSTEMD
>  > +    $(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/wpa_supplicant/
>  > +    ln -sf ../wpa_supplicant.conf \
>  > +
> $(TARGET_DIR)/etc/wpa_supplicant/wpa_supplicant-$(BR2_SYSTEM_DHCP).conf
>
> How do you know BR2_SYSTEM_DHCP is set to something sensible here?
>

Not enforced, but if a user put a nonexistent interface, that file simply
won't work. It is up to the user knowing which interface he wants to enable
dhcp onto.


>
> --
> Bye, Peter Korsgaard
>


-- 

Angelo Compagnucci

Software Engineer

angelo@amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

[-- Attachment #1.2: Type: text/html, Size: 6691 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 4/5] package/ifupdown-scripts: add wifi configuration when enabled

[Angelo Compagnucci]

[-- Attachment #1.1: Type: text/plain, Size: 2115 bytes --]

On Sun, Sep 18, 2022 at 12:03 PM Peter Korsgaard <peter@korsgaard.com>
wrote:

> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
>
>  > Add a proper wpa-conf line to the interfaces files to let the system
>  > bringup the wifi interface and the related wpa supplicant.
>
>  > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>  > ---
>  > Changes:
>  > v3:
>  > * add "|| true" lo let the command exit without error when
>  >   BR2_SYSTEM_CONNECT_WIFI is empty (me)
>
>  >  package/ifupdown-scripts/ifupdown-scripts.mk | 2 ++
>  >  1 file changed, 2 insertions(+)
>
>  > diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk
> b/package/ifupdown-scripts/ifupdown-scripts.mk
>  > index 5ef032142c..ebaf234143 100644
>  > --- a/package/ifupdown-scripts/ifupdown-scripts.mk
>  > +++ b/package/ifupdown-scripts/ifupdown-scripts.mk
>  > @@ -28,6 +28,8 @@ define IFUPDOWN_SCRIPTS_DHCP
>  >              echo "  pre-up /etc/network/nfs_check"; \
>  >              echo "  wait-delay 15"; \
>  >              echo "  hostname \$$(hostname)"; \
>  > +            test -n "$(BR2_SYSTEM_CONNECT_WIFI)" && \
>  > +                    echo "  wpa-conf /etc/wpa_supplicant.conf" ||
> true; \
>  >      ) >> $(TARGET_DIR)/etc/network/interfaces
>
> Maybe we should do this unconditionally if we overwrite
> /etc/network/interfaces and wpa_supplicant is enabled?
>

Not entirely sure to understand this comment. We need to enable the
"wpa-conf" line only when a user enables BR2_SYSTEM_CONNECT_WIFI.

If a user overwrites /etc/network/interfaces in a overlay, he must ensure
it is compiling also wpa_supplicant.

Are suggesting to add code somewhere to check if a user enabled "wpa-conf"
line in his own overlay and then enable wpa_supplicant package for him?


> --
> Bye, Peter Korsgaard
>


-- 

Angelo Compagnucci

Software Engineer

angelo@amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

[-- Attachment #1.2: Type: text/html, Size: 7249 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 5/5] package/initscripts: add service to load kernel modules at boot

[Angelo Compagnucci]

[-- Attachment #1.1: Type: text/plain, Size: 2863 bytes --]

On Sun, Sep 18, 2022 at 12:10 PM Peter Korsgaard <peter@korsgaard.com>
wrote:

> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
>
>  > In cases where no hotplug is available (by choice or by the lack of a
>  > proper hotplug method for a device), this service can be used to load
>  > kernel module drivers by reading the /etc/modules file.
>  > The modules files matches the one used by systemd, which in turn has
>  > a builtin mechanism to load a module at boot, therefore making systemv
>  > init on par with systemd features.
>
>  > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>  > ---
>  > Changes
>
>  > v2:
>  > * Moved script to initscripts (Arnout)
>  > * Moved script to S11modules, after S10[mu]dev (Andreas)
>  > * Use /etc/modules-load.d/ to share the same setup with systemd (me)
>
>  >  package/initscripts/init.d/S11modules | 59 +++++++++++++++++++++++++++
>  >  1 file changed, 59 insertions(+)
>  >  create mode 100644 package/initscripts/init.d/S11modules
>
>  > diff --git a/package/initscripts/init.d/S11modules
> b/package/initscripts/init.d/S11modules
>  > new file mode 100644
>  > index 0000000000..3937945596
>  > --- /dev/null
>  > +++ b/package/initscripts/init.d/S11modules
>  > @@ -0,0 +1,59 @@
>  > +#!/bin/sh
>  > +
>  > +MODULES="*.conf"
>  > +MODULES_DIR="/etc/modules-load.d"
>  > +
>  > +[ -z "$(ls -A ${MODULES_DIR}/${MODULES} 2> /dev/null)" ] && exit 0
>
> The commit message talks about /etc/modules, but you are reading from
> /etc/modules-load.d/*.conf?
>

Yes, right, commit message must be fixed.


> How about supporting both /etc/modules and this directory instead?
>

It is doable, but if we are on par with systemd I cannot see why adding
/etc/modules. The same goal can be obtained easily dropping a file in
/etc/modules-load.d/ .


>
>
>  > +
>  > +load_unload() {
>  > +    for module_file in $(ls -1 ${MODULES_DIR}); do
>
> And here you take all files in /etc/modules-load.d, even if they don't
> have a .conf extension?
>

Nice catch.


>
> > +                     esac
>  > +
>  > +                    if [ "$1" = "load" ]; then
>  > +                            modprobe -q ${module} ${args} >/dev/null
> && \
>  > +                                    printf ' %s success,' "$module" ||
>  > +                                    printf ' %s failed,' "$module"
>
> success/failed are quite long strings, how about only printing the
> module name on success and a big scary FAIL like we do elsewhere on
> failures?
>

Nice suggestion.


>
> --
> Bye, Peter Korsgaard
>


-- 

Angelo Compagnucci

Software Engineer

angelo@amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

[-- Attachment #1.2: Type: text/html, Size: 8288 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi

[Andreas Ziegler]

Hi Angelo, Peter, *,

On 2022-10-03 15:42, Angelo Compagnucci wrote:
> On Sun, Sep 18, 2022 at 11:57 AM Peter Korsgaard <peter@korsgaard.com>
> wrote:
> 
>> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
>> 
>>  > These options can be used by packages to configure a wifi card
>>  > to connect at boot.
>> 
>>  > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>>  > ---
>>  >  system/Config.in | 15 +++++++++++++++
>>  >  1 file changed, 15 insertions(+)
>> 
>>  > diff --git a/system/Config.in b/system/Config.in
>>  > index 888c24ce81..9a5bdb2932 100644
>>  > --- a/system/Config.in
>>  > +++ b/system/Config.in
>>  > @@ -418,6 +418,21 @@ comment "automatic network configuration via 
>> DHCP
>> needs ifupdown or busybox or n
>>  >      depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN || \
>>  >              BR2_PACKAGE_SYSTEMD_NETWORKD || BR2_PACKAGE_NETIFRC)
>> 
>>  > +config BR2_SYSTEM_CONNECT_WIFI
>>  > +    bool "Connect to a default wifi access point"
>>  > +    default n

Depending on BR2_SYSTEM_DHCP would remove some unwanted side effects:

+config BR2_SYSTEM_CONNECT_WIFI
+    bool "Connect to a default wifi access point"
+    depends on BR2_SYSTEM_DHCP != "" && BR2_PACKAGE_WPA_SUPPLICANT

Kind regards,
Andreas

>> 
>> 'n' is default, so drop that.
> 
> 
> Right.
> 
> 
>> This doesn't really do anything unless the
>> user also configures BR2_SYSTEM_DHCP="wlan0", right?
>> 
> 
> Right.
> 
> 
>> 
>> I must say I am not really convinced. This is only useful for quite
>> specific setups (E.G. a lot more specific than BR2_SYSTEM_DHCP which 
>> we
>> use in a number of defconfigs) and hard codes a number of things (like
>> WPA-PSK that may or may not make sense in the future).
>> 
> 
> This is what we have now on several readme.txt on how to connect to a 
> wifi
> 
> WiFi
> ====
> 
>  # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf
>    (type password and enter)
>  # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B
>  # udhcpc -i wlan0
> 
> I don't think this is nice.
> 
> I'd like to see something like that:
> 
> WiFi
> ====
> 
> # Enable BR2_SYSTEM_CONNECT_WIFI configure option
> # Set the Wifi SSID with the option BR2_SYSTEM_CONNECT_WIFI_SSID
> # Set the password with the option BR2_SYSTEM_CONNECT_WIFI_PASSWORD
> 
> Nicer and easier. I know that the wpa-psk could change in the feature, 
> but
> then we can change to whatever default mechanism will be in place at 
> that
> moment.
> 
> 
>> 
>> --
>> Bye, Peter Korsgaard
>> 
> 
> 
> --
> 
> Angelo Compagnucci
> 
> Software Engineer
> 
> angelo@amarulasolutions.com
> __________________________________
> Amarula Solutions SRL
> 
> Via le Canevare 30, 31100 Treviso, Veneto, IT
> 
> T. +39 (0)42 243 5310
> info@amarulasolutions.com
> 
> www.amarulasolutions.com
> [`as] https://www.amarulasolutions.com|
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi

[Angelo Compagnucci]

[-- Attachment #1.1: Type: text/plain, Size: 3437 bytes --]

On Tue, Oct 4, 2022 at 11:05 AM Andreas Ziegler <br015@umbiko.net> wrote:

> Hi Angelo, Peter, *,
>
> On 2022-10-03 15:42, Angelo Compagnucci wrote:
> > On Sun, Sep 18, 2022 at 11:57 AM Peter Korsgaard <peter@korsgaard.com>
> > wrote:
> >
> >> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com>
> writes:
> >>
> >>  > These options can be used by packages to configure a wifi card
> >>  > to connect at boot.
> >>
> >>  > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> >>  > ---
> >>  >  system/Config.in | 15 +++++++++++++++
> >>  >  1 file changed, 15 insertions(+)
> >>
> >>  > diff --git a/system/Config.in b/system/Config.in
> >>  > index 888c24ce81..9a5bdb2932 100644
> >>  > --- a/system/Config.in
> >>  > +++ b/system/Config.in
> >>  > @@ -418,6 +418,21 @@ comment "automatic network configuration via
> >> DHCP
> >> needs ifupdown or busybox or n
> >>  >      depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN || \
> >>  >              BR2_PACKAGE_SYSTEMD_NETWORKD || BR2_PACKAGE_NETIFRC)
> >>
> >>  > +config BR2_SYSTEM_CONNECT_WIFI
> >>  > +    bool "Connect to a default wifi access point"
> >>  > +    default n
>
> Depending on BR2_SYSTEM_DHCP would remove some unwanted side effects:
>
> +config BR2_SYSTEM_CONNECT_WIFI
> +    bool "Connect to a default wifi access point"
> +    depends on BR2_SYSTEM_DHCP != "" && BR2_PACKAGE_WPA_SUPPLICANT
>

Nice indeed!


>
> Kind regards,
> Andreas
>
> >>
> >> 'n' is default, so drop that.
> >
> >
> > Right.
> >
> >
> >> This doesn't really do anything unless the
> >> user also configures BR2_SYSTEM_DHCP="wlan0", right?
> >>
> >
> > Right.
> >
> >
> >>
> >> I must say I am not really convinced. This is only useful for quite
> >> specific setups (E.G. a lot more specific than BR2_SYSTEM_DHCP which
> >> we
> >> use in a number of defconfigs) and hard codes a number of things (like
> >> WPA-PSK that may or may not make sense in the future).
> >>
> >
> > This is what we have now on several readme.txt on how to connect to a
> > wifi
> >
> > WiFi
> > ====
> >
> >  # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf
> >    (type password and enter)
> >  # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B
> >  # udhcpc -i wlan0
> >
> > I don't think this is nice.
> >
> > I'd like to see something like that:
> >
> > WiFi
> > ====
> >
> > # Enable BR2_SYSTEM_CONNECT_WIFI configure option
> > # Set the Wifi SSID with the option BR2_SYSTEM_CONNECT_WIFI_SSID
> > # Set the password with the option BR2_SYSTEM_CONNECT_WIFI_PASSWORD
> >
> > Nicer and easier. I know that the wpa-psk could change in the feature,
> > but
> > then we can change to whatever default mechanism will be in place at
> > that
> > moment.
> >
> >
> >>
> >> --
> >> Bye, Peter Korsgaard
> >>
> >
> >
> > --
> >
> > Angelo Compagnucci
> >
> > Software Engineer
> >
> > angelo@amarulasolutions.com
> > __________________________________
> > Amarula Solutions SRL
> >
> > Via le Canevare 30, 31100 Treviso, Veneto, IT
> >
> > T. +39 (0)42 243 5310
> > info@amarulasolutions.com
> >
> > www.amarulasolutions.com
> > [`as] https://www.amarulasolutions.com|
>


-- 

Angelo Compagnucci

Software Engineer

angelo@amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

[-- Attachment #1.2: Type: text/html, Size: 9139 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot