From: Alistair Popple <apopple@nvidia.com> To: Felix Kuehling <felix.kuehling@amd.com> Cc: Matthew Wilcox <willy@infradead.org>, Alex Sierra <alex.sierra@amd.com>, jgg@nvidia.com, david@redhat.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH v1 1/3] mm: split vm_normal_pages for LRU and non-LRU handling Date: Thu, 17 Mar 2022 13:50:37 +1100 [thread overview] Message-ID: <87mthp8f2g.fsf@nvdebian.thelocal> (raw) In-Reply-To: <651099d6-21ae-16a6-e500-a87002468cda@amd.com> [-- Attachment #1: Type: text/plain, Size: 2861 bytes --] Felix Kuehling <felix.kuehling@amd.com> writes: > Am 2022-03-10 um 14:25 schrieb Matthew Wilcox: >> On Thu, Mar 10, 2022 at 11:26:31AM -0600, Alex Sierra wrote: >>> @@ -606,7 +606,7 @@ static void print_bad_pte(struct vm_area_struct *vma, unsigned long addr, >>> * PFNMAP mappings in order to support COWable mappings. >>> * >>> */ >>> -struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> +struct page *vm_normal_any_page(struct vm_area_struct *vma, unsigned long addr, >>> pte_t pte) >>> { >>> unsigned long pfn = pte_pfn(pte); >>> @@ -620,8 +620,6 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> return NULL; >>> if (is_zero_pfn(pfn)) >>> return NULL; >>> - if (pte_devmap(pte)) >>> - return NULL; >>> print_bad_pte(vma, addr, pte, NULL); >>> return NULL; >> ... what? >> >> Haven't you just made it so that a devmap page always prints a bad PTE >> message, and then returns NULL anyway? > > Yeah, that was stupid. :/ I think the long-term goal was to get rid of > pte_devmap. But for now, as long as we have pte_special with pte_devmap, > we'll need a special case to handle that like a normal page. > > I only see the PFN_DEV|PFN_MAP flags set in a few places: drivers/dax/device.c, > drivers/nvdimm/pmem.c, fs/fuse/virtio_fs.c. I guess we need to test at least one > of them for this patch series to make sure we're not breaking them. > > >> >> Surely this should be: >> >> if (pte_devmap(pte)) >> - return NULL; >> + return pfn_to_page(pfn); >> >> or maybe >> >> + goto check_pfn; >> >> But I don't know about that highest_memmap_pfn check. > > Looks to me like it should work. highest_memmap_pfn gets updated in > memremap_pages -> pagemap_range -> move_pfn_range_to_zone -> > memmap_init_range. FWIW the previous version of this feature which was removed in 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support") had a similar comparison with highest_memmap_pfn: if (likely(pfn <= highest_memmap_pfn)) { struct page *page = pfn_to_page(pfn); if (is_device_public_page(page)) { if (with_public_device) return page; return NULL; } } > Regards, > Felix > > >> >>> @@ -661,6 +659,22 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> return pfn_to_page(pfn); >>> } >>> +/* >>> + * vm_normal_lru_page -- This function gets the "struct page" associated >>> + * with a pte only for page cache and anon page. These pages are LRU handled. >>> + */ >>> +struct page *vm_normal_lru_page(struct vm_area_struct *vma, unsigned long addr, >>> + pte_t pte) >> It seems a shame to add a new function without proper kernel-doc. >>
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <apopple@nvidia.com> To: Felix Kuehling <felix.kuehling@amd.com> Cc: Alex Sierra <alex.sierra@amd.com>, rcampbell@nvidia.com, david@redhat.com, dri-devel@lists.freedesktop.org, Matthew Wilcox <willy@infradead.org>, linux-xfs@vger.kernel.org, linux-mm@kvack.org, jglisse@redhat.com, amd-gfx@lists.freedesktop.org, jgg@nvidia.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, hch@lst.de Subject: Re: [PATCH v1 1/3] mm: split vm_normal_pages for LRU and non-LRU handling Date: Thu, 17 Mar 2022 13:50:37 +1100 [thread overview] Message-ID: <87mthp8f2g.fsf@nvdebian.thelocal> (raw) In-Reply-To: <651099d6-21ae-16a6-e500-a87002468cda@amd.com> [-- Attachment #1: Type: text/plain, Size: 2861 bytes --] Felix Kuehling <felix.kuehling@amd.com> writes: > Am 2022-03-10 um 14:25 schrieb Matthew Wilcox: >> On Thu, Mar 10, 2022 at 11:26:31AM -0600, Alex Sierra wrote: >>> @@ -606,7 +606,7 @@ static void print_bad_pte(struct vm_area_struct *vma, unsigned long addr, >>> * PFNMAP mappings in order to support COWable mappings. >>> * >>> */ >>> -struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> +struct page *vm_normal_any_page(struct vm_area_struct *vma, unsigned long addr, >>> pte_t pte) >>> { >>> unsigned long pfn = pte_pfn(pte); >>> @@ -620,8 +620,6 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> return NULL; >>> if (is_zero_pfn(pfn)) >>> return NULL; >>> - if (pte_devmap(pte)) >>> - return NULL; >>> print_bad_pte(vma, addr, pte, NULL); >>> return NULL; >> ... what? >> >> Haven't you just made it so that a devmap page always prints a bad PTE >> message, and then returns NULL anyway? > > Yeah, that was stupid. :/ I think the long-term goal was to get rid of > pte_devmap. But for now, as long as we have pte_special with pte_devmap, > we'll need a special case to handle that like a normal page. > > I only see the PFN_DEV|PFN_MAP flags set in a few places: drivers/dax/device.c, > drivers/nvdimm/pmem.c, fs/fuse/virtio_fs.c. I guess we need to test at least one > of them for this patch series to make sure we're not breaking them. > > >> >> Surely this should be: >> >> if (pte_devmap(pte)) >> - return NULL; >> + return pfn_to_page(pfn); >> >> or maybe >> >> + goto check_pfn; >> >> But I don't know about that highest_memmap_pfn check. > > Looks to me like it should work. highest_memmap_pfn gets updated in > memremap_pages -> pagemap_range -> move_pfn_range_to_zone -> > memmap_init_range. FWIW the previous version of this feature which was removed in 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support") had a similar comparison with highest_memmap_pfn: if (likely(pfn <= highest_memmap_pfn)) { struct page *page = pfn_to_page(pfn); if (is_device_public_page(page)) { if (with_public_device) return page; return NULL; } } > Regards, > Felix > > >> >>> @@ -661,6 +659,22 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >>> return pfn_to_page(pfn); >>> } >>> +/* >>> + * vm_normal_lru_page -- This function gets the "struct page" associated >>> + * with a pte only for page cache and anon page. These pages are LRU handled. >>> + */ >>> +struct page *vm_normal_lru_page(struct vm_area_struct *vma, unsigned long addr, >>> + pte_t pte) >> It seems a shame to add a new function without proper kernel-doc. >>
next prev parent reply other threads:[~2022-03-17 2:53 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-10 17:26 [PATCH v1 0/3] split vm_normal_pages for LRU and non-LRU handling Alex Sierra 2022-03-10 17:26 ` Alex Sierra 2022-03-10 17:26 ` [PATCH v1 1/3] mm: " Alex Sierra 2022-03-10 17:26 ` Alex Sierra 2022-03-10 19:25 ` Matthew Wilcox 2022-03-10 19:25 ` Matthew Wilcox 2022-03-10 21:58 ` Felix Kuehling 2022-03-10 21:58 ` Felix Kuehling 2022-03-17 2:50 ` Alistair Popple [this message] 2022-03-17 2:50 ` Alistair Popple 2022-03-11 9:16 ` David Hildenbrand 2022-03-11 9:16 ` David Hildenbrand 2022-03-11 17:08 ` Felix Kuehling 2022-03-11 17:08 ` Felix Kuehling 2022-03-17 2:54 ` Alistair Popple 2022-03-17 2:54 ` Alistair Popple 2022-03-17 8:13 ` David Hildenbrand 2022-03-17 8:13 ` David Hildenbrand 2022-03-17 13:25 ` Jason Gunthorpe 2022-03-17 13:25 ` Jason Gunthorpe 2022-03-10 17:26 ` [PATCH v1 2/3] tools: add more gup configs to hmm_gup selftests Alex Sierra 2022-03-10 17:26 ` Alex Sierra 2022-03-10 17:26 ` [PATCH v1 3/3] tools: add selftests to hmm for COW in device memory Alex Sierra 2022-03-10 17:26 ` Alex Sierra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87mthp8f2g.fsf@nvdebian.thelocal \ --to=apopple@nvidia.com \ --cc=akpm@linux-foundation.org \ --cc=alex.sierra@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=david@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=felix.kuehling@amd.com \ --cc=hch@lst.de \ --cc=jgg@nvidia.com \ --cc=jglisse@redhat.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=rcampbell@nvidia.com \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.