All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Anilkumar Kolli <akolli@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 11/11] ath11k: add qcn9074 pci device support
Date: Tue, 16 Feb 2021 18:36:48 +0200	[thread overview]
Message-ID: <87mtw4q89r.fsf@codeaurora.org> (raw)
In-Reply-To: <1612946530-28504-12-git-send-email-akolli@codeaurora.org> (Anilkumar Kolli's message of "Wed, 10 Feb 2021 14:12:10 +0530")

Anilkumar Kolli <akolli@codeaurora.org> writes:

> QCN9074 is PCI based 11ax radio.
> 	- has 2G/5G/6G variants.
> 	- has NSS 2x2 and 4x4 variants.
>
> QCN9074 uses 45MB of HOST DDR memory, target requests host memory in
> segments, each segment is of 2MB size and is physcial contiguous and
> use static window configuration.
>
> Below QMI issues are seen with QCN9074,
> Issue 1:
>  ath11k_pci 0000:06:00.0: qmi failed memory request, err = -110
>  ath11k_pci 0000:06:00.0: qmi failed to respond fw mem req:-110
> Issue 2:
>  ath11k_pci 0000:06:00.0: firmware crashed: MHI_CB_SYS_ERROR
>  ath11k_pci 0000:06:00.0: qmi failed set mode request, mode: 0, err = -110
>  ath11k_pci 0000:06:00.0: qmi failed to send wlan fw mode:-110

I clarified the commit log to mention that QCN9074 is not fully working
yet.

> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1.r2-00012-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath11k/pci.c | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c
> index 70dcb80475b1..259a39e59a91 100644
> --- a/drivers/net/wireless/ath/ath11k/pci.c
> +++ b/drivers/net/wireless/ath/ath11k/pci.c
> @@ -34,10 +34,12 @@
>   */
>  #define ACCESS_ALWAYS_OFF 0xFE0
>  
> -#define QCA6390_DEVICE_ID		0x1101
> +#define QCA6390_DEVICE_ID              0x1101

Here you convert tabs to spaces, I fixed them back.

> +#define QCN9074_DEVICE_ID              0x1104

And modified this to use tabs as well.

>  static const struct pci_device_id ath11k_pci_id_table[] = {
>  	{ PCI_VDEVICE(QCOM, QCA6390_DEVICE_ID) },
> +	{ PCI_VDEVICE(QCOM, QCN9074_DEVICE_ID) },

I removed this and added a comment instead. Let's add the pci id once
the device is fully working.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Anilkumar Kolli <akolli@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 11/11] ath11k: add qcn9074 pci device support
Date: Tue, 16 Feb 2021 18:36:48 +0200	[thread overview]
Message-ID: <87mtw4q89r.fsf@codeaurora.org> (raw)
In-Reply-To: <1612946530-28504-12-git-send-email-akolli@codeaurora.org> (Anilkumar Kolli's message of "Wed, 10 Feb 2021 14:12:10 +0530")

Anilkumar Kolli <akolli@codeaurora.org> writes:

> QCN9074 is PCI based 11ax radio.
> 	- has 2G/5G/6G variants.
> 	- has NSS 2x2 and 4x4 variants.
>
> QCN9074 uses 45MB of HOST DDR memory, target requests host memory in
> segments, each segment is of 2MB size and is physcial contiguous and
> use static window configuration.
>
> Below QMI issues are seen with QCN9074,
> Issue 1:
>  ath11k_pci 0000:06:00.0: qmi failed memory request, err = -110
>  ath11k_pci 0000:06:00.0: qmi failed to respond fw mem req:-110
> Issue 2:
>  ath11k_pci 0000:06:00.0: firmware crashed: MHI_CB_SYS_ERROR
>  ath11k_pci 0000:06:00.0: qmi failed set mode request, mode: 0, err = -110
>  ath11k_pci 0000:06:00.0: qmi failed to send wlan fw mode:-110

I clarified the commit log to mention that QCN9074 is not fully working
yet.

> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1.r2-00012-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath11k/pci.c | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c
> index 70dcb80475b1..259a39e59a91 100644
> --- a/drivers/net/wireless/ath/ath11k/pci.c
> +++ b/drivers/net/wireless/ath/ath11k/pci.c
> @@ -34,10 +34,12 @@
>   */
>  #define ACCESS_ALWAYS_OFF 0xFE0
>  
> -#define QCA6390_DEVICE_ID		0x1101
> +#define QCA6390_DEVICE_ID              0x1101

Here you convert tabs to spaces, I fixed them back.

> +#define QCN9074_DEVICE_ID              0x1104

And modified this to use tabs as well.

>  static const struct pci_device_id ath11k_pci_id_table[] = {
>  	{ PCI_VDEVICE(QCOM, QCA6390_DEVICE_ID) },
> +	{ PCI_VDEVICE(QCOM, QCN9074_DEVICE_ID) },

I removed this and added a comment instead. Let's add the pci id once
the device is fully working.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2021-02-16 16:37 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  8:41 [PATCH 00/11] ath11k: Add support for QCN9074 Anilkumar Kolli
2021-02-10  8:41 ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 01/11] ath11k: Refactor ath11k_msi_config Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-17  9:38   ` Kalle Valo
2021-02-17  9:38   ` Kalle Valo
2021-02-10  8:42 ` [PATCH 02/11] ath11k: Move qmi service_ins_id to hw_params Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 03/11] ath11k: qmi: increase the number of fw segments Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 04/11] ath11k: Update memory segment count for qcn9074 Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 05/11] ath11k: Add qcn9074 mhi controller config Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 06/11] ath11k: add static window support for register access Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-16 16:45   ` Kalle Valo
2021-02-16 16:45     ` Kalle Valo
2021-02-17  2:28     ` akolli
2021-02-17  2:28       ` akolli
2021-02-17  9:28       ` Kalle Valo
2021-02-17  9:28         ` Kalle Valo
2022-03-28 16:44   ` Hamdi Issam
2022-03-28 16:44     ` Hamdi Issam
2022-06-23 10:44     ` Karthikeyan Periyasamy (QUIC)
2022-06-23 10:44       ` Karthikeyan Periyasamy (QUIC)
2021-02-10  8:42 ` [PATCH 07/11] ath11k: add hal support for QCN9074 Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 08/11] ath11k: add data path " Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 09/11] ath11k: add CE interrupt " Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 10/11] ath11k: add extended " Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-10  8:42 ` [PATCH 11/11] ath11k: add qcn9074 pci device support Anilkumar Kolli
2021-02-10  8:42   ` Anilkumar Kolli
2021-02-16 16:36   ` Kalle Valo [this message]
2021-02-16 16:36     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtw4q89r.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=akolli@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.