* [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
@ 2020-12-09 21:16 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2020-12-09 21:16 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Sean Paul, Rodrigo Vivi
From: Sean Paul <seanpaul@chromium.org>
No need to spam syslog/console when we can ignore/fix the flag.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
index 4346bc1a747a..27dc2dad6809 100644
--- a/drivers/gpu/drm/i915/display/intel_tc.c
+++ b/drivers/gpu/drm/i915/display/intel_tc.c
@@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
mask |= BIT(TC_PORT_LEGACY);
/* The sink can be connected only in a single mode. */
- if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
+ if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
tc_port_fixup_legacy_flag(dig_port, mask);
return mask;
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
@ 2020-12-09 21:16 ` Sean Paul
0 siblings, 0 replies; 8+ messages in thread
From: Sean Paul @ 2020-12-09 21:16 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Sean Paul
From: Sean Paul <seanpaul@chromium.org>
No need to spam syslog/console when we can ignore/fix the flag.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
index 4346bc1a747a..27dc2dad6809 100644
--- a/drivers/gpu/drm/i915/display/intel_tc.c
+++ b/drivers/gpu/drm/i915/display/intel_tc.c
@@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
mask |= BIT(TC_PORT_LEGACY);
/* The sink can be connected only in a single mode. */
- if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
+ if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
tc_port_fixup_legacy_flag(dig_port, mask);
return mask;
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/tc: Only WARN once for bogus tc port flag
2020-12-09 21:16 ` [Intel-gfx] " Sean Paul
(?)
@ 2020-12-09 22:14 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-12-09 22:14 UTC (permalink / raw)
To: Sean Paul; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 3084 bytes --]
== Series Details ==
Series: drm/i915/display/tc: Only WARN once for bogus tc port flag
URL : https://patchwork.freedesktop.org/series/84745/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9465 -> Patchwork_19096
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/index.html
Known issues
------------
Here are the changes found in Patchwork_19096 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +22 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#2283])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][5] ([i915#1888]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (43 -> 40)
------------------------------
Missing (3): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9465 -> Patchwork_19096
CI-20190529: 20190529
CI_DRM_9465: 5e7767ff97719d9a32ce4f69757d2f4ee1164baa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5885: d99f644b1868b9c92435b05ebfafa230721cd677 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19096: 001794061234a00203cc9bf68771f83a1763ee3b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
001794061234 drm/i915/display/tc: Only WARN once for bogus tc port flag
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/index.html
[-- Attachment #1.2: Type: text/html, Size: 3872 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/tc: Only WARN once for bogus tc port flag
2020-12-09 21:16 ` [Intel-gfx] " Sean Paul
(?)
(?)
@ 2020-12-09 23:49 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-12-09 23:49 UTC (permalink / raw)
To: Sean Paul; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 13939 bytes --]
== Series Details ==
Series: drm/i915/display/tc: Only WARN once for bogus tc port flag
URL : https://patchwork.freedesktop.org/series/84745/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9465_full -> Patchwork_19096_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19096_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-contexts:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([i915#118] / [i915#95])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-glk8/igt@gem_exec_whisper@basic-contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-glk2/igt@gem_exec_whisper@basic-contexts.html
* igt@kms_big_joiner@basic:
- shard-apl: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2705])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-apl4/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer:
- shard-skl: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111304])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl6/igt@kms_ccs@pipe-c-missing-ccs-buffer.html
* igt@kms_chamelium@hdmi-hpd:
- shard-skl: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl6/igt@kms_chamelium@hdmi-hpd.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-apl: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-apl4/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#54]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-64x64-sliding:
- shard-apl: NOTRUN -> [SKIP][9] ([fdo#109271]) +36 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-apl4/igt@kms_cursor_crc@pipe-d-cursor-64x64-sliding.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][10] -> [FAIL][11] ([i915#96])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][12] -> [FAIL][13] ([i915#2370])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271]) +34 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl6/igt@kms_flip@2x-flip-vs-panning-vs-hang.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-apl: NOTRUN -> [FAIL][17] ([i915#2641])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-apl4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#1188])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#108145] / [i915#265])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_scaling@scaler-with-pixel-format@pipe-a-scaler-with-pixel-format:
- shard-tglb: [PASS][22] -> [INCOMPLETE][23] ([i915#2473])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-tglb8/igt@kms_plane_scaling@scaler-with-pixel-format@pipe-a-scaler-with-pixel-format.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-tglb2/igt@kms_plane_scaling@scaler-with-pixel-format@pipe-a-scaler-with-pixel-format.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][24] -> [SKIP][25] ([fdo#109642] / [fdo#111068])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-iclb2/igt@kms_psr2_su@page_flip.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-iclb4/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][26] -> [SKIP][27] ([fdo#109441]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-iclb2/igt@kms_psr@psr2_dpms.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-iclb4/igt@kms_psr@psr2_dpms.html
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][28] ([IGT#2])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-apl4/igt@kms_sysfs_edid_timing.html
#### Possible fixes ####
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [DMESG-WARN][29] ([i915#118] / [i915#95]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-glk7/igt@gem_exec_whisper@basic-fds-forked-all.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-glk5/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][31] ([i915#2597]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-tglb3/igt@kms_async_flips@test-time-stamp.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-random:
- shard-skl: [FAIL][33] ([i915#54]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][35] ([i915#2346] / [i915#533]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [FAIL][37] ([i915#2598]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [FAIL][39] ([i915#2122]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [INCOMPLETE][41] ([i915#198]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl5/igt@kms_flip@flip-vs-suspend@c-edp1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl6/igt@kms_flip@flip-vs-suspend@c-edp1.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][43] ([fdo#108145] / [i915#265]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-iclb3/igt@kms_psr@psr2_cursor_plane_move.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [INCOMPLETE][47] ([i915#1731] / [i915#198]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl2/igt@sysfs_heartbeat_interval@mixed@vcs0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl2/igt@sysfs_heartbeat_interval@mixed@vcs0.html
#### Warnings ####
* igt@runner@aborted:
- shard-tglb: ([FAIL][49], [FAIL][50], [FAIL][51]) ([i915#1602] / [i915#1814] / [i915#2295] / [i915#2722]) -> ([FAIL][52], [FAIL][53], [FAIL][54]) ([i915#1602] / [i915#1814] / [i915#2295] / [i915#2426] / [i915#2722])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-tglb2/igt@runner@aborted.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-tglb7/igt@runner@aborted.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-tglb8/igt@runner@aborted.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-tglb2/igt@runner@aborted.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-tglb2/igt@runner@aborted.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-tglb5/igt@runner@aborted.html
- shard-skl: [FAIL][55] ([i915#2295] / [i915#2722] / [i915#483]) -> [FAIL][56] ([i915#2295] / [i915#2722])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9465/shard-skl9/igt@runner@aborted.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/shard-skl4/igt@runner@aborted.html
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2473]: https://gitlab.freedesktop.org/drm/intel/issues/2473
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#2641]: https://gitlab.freedesktop.org/drm/intel/issues/2641
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9465 -> Patchwork_19096
CI-20190529: 20190529
CI_DRM_9465: 5e7767ff97719d9a32ce4f69757d2f4ee1164baa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5885: d99f644b1868b9c92435b05ebfafa230721cd677 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19096: 001794061234a00203cc9bf68771f83a1763ee3b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19096/index.html
[-- Attachment #1.2: Type: text/html, Size: 16862 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
2020-12-09 21:16 ` [Intel-gfx] " Sean Paul
@ 2020-12-09 23:56 ` Rodrigo Vivi
-1 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2020-12-09 23:56 UTC (permalink / raw)
To: Sean Paul; +Cc: intel-gfx, Sean Paul, dri-devel
On Wed, Dec 09, 2020 at 04:16:36PM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> No need to spam syslog/console when we can ignore/fix the flag.
besides that we are calling from multiple places anyway..
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index 4346bc1a747a..27dc2dad6809 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
> mask |= BIT(TC_PORT_LEGACY);
>
> /* The sink can be connected only in a single mode. */
> - if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
> + if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
> tc_port_fixup_legacy_flag(dig_port, mask);
>
> return mask;
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
@ 2020-12-09 23:56 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2020-12-09 23:56 UTC (permalink / raw)
To: Sean Paul; +Cc: intel-gfx, Sean Paul, dri-devel
On Wed, Dec 09, 2020 at 04:16:36PM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> No need to spam syslog/console when we can ignore/fix the flag.
besides that we are calling from multiple places anyway..
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index 4346bc1a747a..27dc2dad6809 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
> mask |= BIT(TC_PORT_LEGACY);
>
> /* The sink can be connected only in a single mode. */
> - if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
> + if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
> tc_port_fixup_legacy_flag(dig_port, mask);
>
> return mask;
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
2020-12-09 23:56 ` [Intel-gfx] " Rodrigo Vivi
@ 2020-12-11 13:18 ` Jani Nikula
-1 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2020-12-11 13:18 UTC (permalink / raw)
To: Rodrigo Vivi, Sean Paul; +Cc: intel-gfx, Sean Paul, dri-devel
On Wed, 09 Dec 2020, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Dec 09, 2020 at 04:16:36PM -0500, Sean Paul wrote:
>> From: Sean Paul <seanpaul@chromium.org>
>>
>> No need to spam syslog/console when we can ignore/fix the flag.
>
> besides that we are calling from multiple places anyway..
>
>>
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
>> index 4346bc1a747a..27dc2dad6809 100644
>> --- a/drivers/gpu/drm/i915/display/intel_tc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
>> @@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
>> mask |= BIT(TC_PORT_LEGACY);
>>
>> /* The sink can be connected only in a single mode. */
>> - if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
>> + if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
>> tc_port_fixup_legacy_flag(dig_port, mask);
>>
>> return mask;
>> --
>> Sean Paul, Software Engineer, Google / Chromium OS
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
@ 2020-12-11 13:18 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2020-12-11 13:18 UTC (permalink / raw)
To: Rodrigo Vivi, Sean Paul; +Cc: intel-gfx, Sean Paul, dri-devel
On Wed, 09 Dec 2020, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Dec 09, 2020 at 04:16:36PM -0500, Sean Paul wrote:
>> From: Sean Paul <seanpaul@chromium.org>
>>
>> No need to spam syslog/console when we can ignore/fix the flag.
>
> besides that we are calling from multiple places anyway..
>
>>
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
>> index 4346bc1a747a..27dc2dad6809 100644
>> --- a/drivers/gpu/drm/i915/display/intel_tc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
>> @@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
>> mask |= BIT(TC_PORT_LEGACY);
>>
>> /* The sink can be connected only in a single mode. */
>> - if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
>> + if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
>> tc_port_fixup_legacy_flag(dig_port, mask);
>>
>> return mask;
>> --
>> Sean Paul, Software Engineer, Google / Chromium OS
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-11 13:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 21:16 [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag Sean Paul
2020-12-09 21:16 ` [Intel-gfx] " Sean Paul
2020-12-09 22:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-12-09 23:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-09 23:56 ` [PATCH] " Rodrigo Vivi
2020-12-09 23:56 ` [Intel-gfx] " Rodrigo Vivi
2020-12-11 13:18 ` Jani Nikula
2020-12-11 13:18 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.