[Buildroot] [PATCH 0/3] package/kodi: fix build in minimal config (branch yem/fixes)

[Buildroot] [PATCH 0/3] package/kodi: fix build in minimal config (branch yem/fixes)

[Yann E. MORIN]

Hello All!

With a minimal configuration, Kodi fails to build because of a missing
autopoint, so this series adds the missing dependency to host-gettext.

In the way, it also brings two fixes to gettext-tiny.

Failing defconfig:
    BR2_arm=y
    BR2_cortex_a7=y
    BR2_TOOLCHAIN_EXTERNAL=y
    BR2_INIT_NONE=y
    BR2_SYSTEM_BIN_SH_NONE=y
    # BR2_PACKAGE_BUSYBOX is not set
    BR2_PACKAGE_KODI=y
    BR2_PACKAGE_RPI_USERLAND=y
    BR2_PACKAGE_PYTHON=y
    BR2_PACKAGE_PYTHON_PY_ONLY=y
    # BR2_TARGET_ROOTFS_TAR is not set

Error message:
    [  2%] Performing autoreconf step for 'libcpluff'
    autoreconf: Entering directory `.'
    autoreconf: running: autopoint --force
    Can't exec "autopoint": No such file or directory at [...]/host/share/autoconf/Auto4te/FileUtils.pm line 345.
    autoreconf: failed to run autopoint: No such file or directory
    autoreconf: autopoint is needed because this package uses Gettext
    make[4]: *** [CMakeFiles/libcpluff.dir/build.make:121: build/cpluff/src/libcpluff-stamp/libcpluff-autoreconf] Error 1
    make[3]: *** [CMakeFiles/Makefile2:615: CMakeFiles/libcpluff.dir/all] Error 2


Regards,
Yann E. MORIN.


The following changes since commit 6d588b718de3cc17aee95462fd356933c6470006

  package/kodi: drop readline dependency (2019-11-14 18:37:10 +0100)


are available in the git repository at:

  git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to 9a12e61152e7f9944e986aa9f1c7483750e767c2

  package/kodi: add missing host-gettext dependency (2019-11-14 20:09:21 +0100)


----------------------------------------------------------------
Yann E. MORIN (3):
      package/gettext-tiny: fix prefix in autopoint
      package/gettext-tiny: fix gettext wrapper
      package/kodi: add missing host-gettext dependency

 package/gettext-tiny/gettext-tiny.mk | 1 +
 package/gettext-tiny/gettext-wrapper | 2 +-
 package/kodi/kodi.mk                 | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/3] package/gettext-tiny: fix prefix in autopoint

[Yann E. MORIN]

gettext-tiny also installs a fake autopoint, but it still needs to be
pointed at the m4 macros, which the template autopoint expects to be in
@datadir@, where datadir is the traditional autotools datadir, derived
from datarootdir, itself derived from prefix.

So, pass prefix so all the locations are properly pointing to HOST_DIR,
instead of the default /usr/local.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Vadim Kochan <vadim4j@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/gettext-tiny/gettext-tiny.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/gettext-tiny/gettext-tiny.mk b/package/gettext-tiny/gettext-tiny.mk
index 23a9d9a057..6ee6269e09 100644
--- a/package/gettext-tiny/gettext-tiny.mk
+++ b/package/gettext-tiny/gettext-tiny.mk
@@ -52,6 +52,7 @@ HOST_GETTEXT_TINY_POST_PATCH_HOOKS += HOST_GETTEXT_TINY_COPY_EXTRA_FILES
 define HOST_GETTEXT_TINY_BUILD_CMDS
 	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) \
 		$(HOST_CONFIGURE_OPTS) \
+		prefix=$(HOST_DIR) \
 		CFLAGS="$(HOST_CFLAGS) -fPIC" \
 		LIBINTL=NONE
 
-- 
2.20.1

[Buildroot] [PATCH 2/3] package/gettext-tiny: fix gettext wrapper

[Yann E. MORIN]

When a textdomain is specified, we ignore it twice: we shift args, and
we printf ${2}, which would yield an empty printf.

Fix that by not shifting, and just printf ${2}; this is nicer.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Vadim Kochan <vadim4j@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/gettext-tiny/gettext-wrapper | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gettext-tiny/gettext-wrapper b/package/gettext-tiny/gettext-wrapper
index 3791a3a1aa..11424824c3 100644
--- a/package/gettext-tiny/gettext-wrapper
+++ b/package/gettext-tiny/gettext-wrapper
@@ -19,6 +19,6 @@ done
 case ${#} in
     (0)   printf "missing arguments\n" >&2; return 1;;
     (1)   printf "%s" "${1}";;
-    (2)   shift; printf "%s" "${2}";;
+    (2)   printf "%s" "${2}";;
     (*)   printf "too many arguments\n" >&2; return 1;;
 esac
-- 
2.20.1

[Buildroot] [PATCH 3/3] package/kodi: add missing host-gettext dependency

[Yann E. MORIN]

A sub-component of Kodi (cpluff) needs to be autoreconf-ed, and uses
gettext, so calls to autopoint.

Add a dependency to host-gettext to bring an appropriate variant that
provides autotpoint (gettext-tiny's autopoint works like a charm, for
the curious).

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/kodi/kodi.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index 49728e464b..ceab5d5c0b 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -19,6 +19,7 @@ KODI_DEPENDENCIES = \
 	freetype \
 	gnutls \
 	host-gawk \
+	host-gettext \
 	host-gperf \
 	host-kodi-jsonschemabuilder \
 	host-kodi-texturepacker \
-- 
2.20.1

[Buildroot] [PATCH 0/3] package/kodi: fix build in minimal config (branch yem/fixes)

[Thomas Petazzoni]

On Thu, 14 Nov 2019 20:22:07 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Yann E. MORIN (3):
>       package/gettext-tiny: fix prefix in autopoint
>       package/gettext-tiny: fix gettext wrapper
>       package/kodi: add missing host-gettext dependency

Thanks, series applied to master. However, I've extended a bit the
commit log of PATCH 3/3 with some details from your cover letter (the
error log).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/3] package/gettext-tiny: fix prefix in autopoint

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > gettext-tiny also installs a fake autopoint, but it still needs to be
 > pointed at the m4 macros, which the template autopoint expects to be in
 > @datadir@, where datadir is the traditional autotools datadir, derived
 > from datarootdir, itself derived from prefix.

 > So, pass prefix so all the locations are properly pointing to HOST_DIR,
 > instead of the default /usr/local.

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Vadim Kochan <vadim4j@gmail.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2019.08.x (not in 2019.02.x), thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/3] package/gettext-tiny: fix gettext wrapper

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > When a textdomain is specified, we ignore it twice: we shift args, and
 > we printf ${2}, which would yield an empty printf.

 > Fix that by not shifting, and just printf ${2}; this is nicer.

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Vadim Kochan <vadim4j@gmail.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2019.08.x (not in 2019.02.x), thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 3/3] package/kodi: add missing host-gettext dependency

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > A sub-component of Kodi (cpluff) needs to be autoreconf-ed, and uses
 > gettext, so calls to autopoint.

 > Add a dependency to host-gettext to bring an appropriate variant that
 > provides autotpoint (gettext-tiny's autopoint works like a charm, for
 > the curious).

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
 > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Committed to 2019.02.x and 2019.08.x, thanks.

-- 
Bye, Peter Korsgaard