* [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password
@ 2019-02-05 9:45 Peter Korsgaard
2019-02-05 9:45 ` [Buildroot] [PATCH 2/3] support/testing: test_dropbear.py: add test for ssh connection to localhost Peter Korsgaard
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Peter Korsgaard @ 2019-02-05 9:45 UTC (permalink / raw)
To: buildroot
The password is used in multiple places, so add a constant for it instead of
hardcoding it multiple times.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
support/testing/tests/package/test_dropbear.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/support/testing/tests/package/test_dropbear.py b/support/testing/tests/package/test_dropbear.py
index 8f7f1fee82..2a7a1bd8af 100644
--- a/support/testing/tests/package/test_dropbear.py
+++ b/support/testing/tests/package/test_dropbear.py
@@ -4,14 +4,15 @@ import infra.basetest
class TestDropbear(infra.basetest.BRTest):
+ passwd = "testpwd"
config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
"""
- BR2_TARGET_GENERIC_ROOT_PASSWD="testpwd"
+ BR2_TARGET_GENERIC_ROOT_PASSWD="{}"
BR2_SYSTEM_DHCP="eth0"
BR2_PACKAGE_DROPBEAR=y
BR2_TARGET_ROOTFS_CPIO=y
# BR2_TARGET_ROOTFS_TAR is not set
- """
+ """.format(passwd)
def test_run(self):
img = os.path.join(self.builddir, "images", "rootfs.cpio")
@@ -20,7 +21,7 @@ class TestDropbear(infra.basetest.BRTest):
options=["-initrd", img,
"-net", "nic",
"-net", "user,hostfwd=tcp::2222-:22"])
- self.emulator.login("testpwd")
+ self.emulator.login(self.passwd)
cmd = "netstat -ltn 2>/dev/null | grep 0.0.0.0:22"
_, exit_code = self.emulator.run(cmd)
self.assertEqual(exit_code, 0)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/3] support/testing: test_dropbear.py: add test for ssh connection to localhost
2019-02-05 9:45 [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password Peter Korsgaard
@ 2019-02-05 9:45 ` Peter Korsgaard
2019-02-05 18:04 ` Peter Korsgaard
2019-02-05 9:45 ` [Buildroot] [PATCH 3/3] support/testing: test_dropbear.py: drop ssh port forward to the host Peter Korsgaard
2019-02-05 18:04 ` [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2019-02-05 9:45 UTC (permalink / raw)
To: buildroot
Use sshpass to pass the password on the command line.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
support/testing/tests/package/test_dropbear.py | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/support/testing/tests/package/test_dropbear.py b/support/testing/tests/package/test_dropbear.py
index 2a7a1bd8af..ad0f89316c 100644
--- a/support/testing/tests/package/test_dropbear.py
+++ b/support/testing/tests/package/test_dropbear.py
@@ -10,6 +10,7 @@ class TestDropbear(infra.basetest.BRTest):
BR2_TARGET_GENERIC_ROOT_PASSWD="{}"
BR2_SYSTEM_DHCP="eth0"
BR2_PACKAGE_DROPBEAR=y
+ BR2_PACKAGE_SSHPASS=y
BR2_TARGET_ROOTFS_CPIO=y
# BR2_TARGET_ROOTFS_TAR is not set
""".format(passwd)
@@ -25,6 +26,7 @@ class TestDropbear(infra.basetest.BRTest):
cmd = "netstat -ltn 2>/dev/null | grep 0.0.0.0:22"
_, exit_code = self.emulator.run(cmd)
self.assertEqual(exit_code, 0)
- # Would be useful to try to login through SSH here, through
- # localhost:2222, though it is not easy to pass the ssh
- # password on the command line.
+
+ cmd = "sshpass -p {} ssh -y localhost /bin/true".format(self.passwd)
+ _, exit_code = self.emulator.run(cmd)
+ self.assertEqual(exit_code, 0)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/3] support/testing: test_dropbear.py: drop ssh port forward to the host
2019-02-05 9:45 [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password Peter Korsgaard
2019-02-05 9:45 ` [Buildroot] [PATCH 2/3] support/testing: test_dropbear.py: add test for ssh connection to localhost Peter Korsgaard
@ 2019-02-05 9:45 ` Peter Korsgaard
2019-02-05 18:04 ` Peter Korsgaard
2019-02-05 18:04 ` [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2019-02-05 9:45 UTC (permalink / raw)
To: buildroot
It is not used and may conflict with other services running on port 2222 on
the host machine.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
support/testing/tests/package/test_dropbear.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/testing/tests/package/test_dropbear.py b/support/testing/tests/package/test_dropbear.py
index ad0f89316c..bfec8701f2 100644
--- a/support/testing/tests/package/test_dropbear.py
+++ b/support/testing/tests/package/test_dropbear.py
@@ -21,7 +21,7 @@ class TestDropbear(infra.basetest.BRTest):
kernel="builtin",
options=["-initrd", img,
"-net", "nic",
- "-net", "user,hostfwd=tcp::2222-:22"])
+ "-net", "user"])
self.emulator.login(self.passwd)
cmd = "netstat -ltn 2>/dev/null | grep 0.0.0.0:22"
_, exit_code = self.emulator.run(cmd)
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password
2019-02-05 9:45 [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password Peter Korsgaard
2019-02-05 9:45 ` [Buildroot] [PATCH 2/3] support/testing: test_dropbear.py: add test for ssh connection to localhost Peter Korsgaard
2019-02-05 9:45 ` [Buildroot] [PATCH 3/3] support/testing: test_dropbear.py: drop ssh port forward to the host Peter Korsgaard
@ 2019-02-05 18:04 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2019-02-05 18:04 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> The password is used in multiple places, so add a constant for it instead of
> hardcoding it multiple times.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/3] support/testing: test_dropbear.py: add test for ssh connection to localhost
2019-02-05 9:45 ` [Buildroot] [PATCH 2/3] support/testing: test_dropbear.py: add test for ssh connection to localhost Peter Korsgaard
@ 2019-02-05 18:04 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2019-02-05 18:04 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Use sshpass to pass the password on the command line.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/3] support/testing: test_dropbear.py: drop ssh port forward to the host
2019-02-05 9:45 ` [Buildroot] [PATCH 3/3] support/testing: test_dropbear.py: drop ssh port forward to the host Peter Korsgaard
@ 2019-02-05 18:04 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2019-02-05 18:04 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> It is not used and may conflict with other services running on port 2222 on
> the host machine.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-05 18:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 9:45 [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password Peter Korsgaard
2019-02-05 9:45 ` [Buildroot] [PATCH 2/3] support/testing: test_dropbear.py: add test for ssh connection to localhost Peter Korsgaard
2019-02-05 18:04 ` Peter Korsgaard
2019-02-05 9:45 ` [Buildroot] [PATCH 3/3] support/testing: test_dropbear.py: drop ssh port forward to the host Peter Korsgaard
2019-02-05 18:04 ` Peter Korsgaard
2019-02-05 18:04 ` [Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.