* [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs
@ 2018-12-03 18:37 ` Stefan Wahren
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2018-12-03 18:37 UTC (permalink / raw)
To: Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt,
Arnd Bergmann, olof, gregkh
Cc: bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel,
arm, Stefan Wahren, stable
The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
introduced a wifi power sequence. Unfortunately the polarity of the reset
GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and
later in 3 B+. This wasn't discovered before since the power sequence
takes only effect in case the relevant MMC driver is compiled as a module.
Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
Cc: stable@vger.kernel.org
Reported-by: Matthias Lueschner <lueschem@gmail.com>
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
Hi, i like to have this included in 4.20 if possible.
Stefan
arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
index 4adb85e..9376224 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
@@ -31,7 +31,7 @@
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
- reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
};
};
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
index c318bcb..89e6fd5 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
@@ -26,7 +26,7 @@
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
- reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs
@ 2018-12-03 18:37 ` Stefan Wahren
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2018-12-03 18:37 UTC (permalink / raw)
To: Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt,
Arnd Bergmann, olof, gregkh
Cc: Stefan Wahren, stable, arm, bcm-kernel-feedback-list,
linux-rpi-kernel, linux-arm-kernel
The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
introduced a wifi power sequence. Unfortunately the polarity of the reset
GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and
later in 3 B+. This wasn't discovered before since the power sequence
takes only effect in case the relevant MMC driver is compiled as a module.
Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
Cc: stable@vger.kernel.org
Reported-by: Matthias Lueschner <lueschem@gmail.com>
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
Hi, i like to have this included in 4.20 if possible.
Stefan
arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
index 4adb85e..9376224 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
@@ -31,7 +31,7 @@
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
- reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
};
};
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
index c318bcb..89e6fd5 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
@@ -26,7 +26,7 @@
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
- reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
};
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs
2018-12-03 18:37 ` Stefan Wahren
@ 2018-12-03 18:59 ` Eric Anholt
-1 siblings, 0 replies; 6+ messages in thread
From: Eric Anholt @ 2018-12-03 18:59 UTC (permalink / raw)
To: Stefan Wahren, Florian Fainelli, Ray Jui, Scott Branden,
Arnd Bergmann, olof, gregkh
Cc: bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel,
arm, Stefan Wahren, stable
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
> The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> introduced a wifi power sequence. Unfortunately the polarity of the reset
> GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and
> later in 3 B+. This wasn't discovered before since the power sequence
> takes only effect in case the relevant MMC driver is compiled as a module.
>
> Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> Cc: stable@vger.kernel.org
> Reported-by: Matthias Lueschner <lueschem@gmail.com>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>
> Hi, i like to have this included in 4.20 if possible.
Reviewed-by: Eric Anholt <eric@anholt.net>
Florian, would you be able to pick this directly to a -fixes branch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs
@ 2018-12-03 18:59 ` Eric Anholt
0 siblings, 0 replies; 6+ messages in thread
From: Eric Anholt @ 2018-12-03 18:59 UTC (permalink / raw)
To: Stefan Wahren, Florian Fainelli, Ray Jui, Scott Branden,
Arnd Bergmann, olof, gregkh
Cc: Stefan Wahren, stable, arm, bcm-kernel-feedback-list,
linux-rpi-kernel, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 882 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
> The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> introduced a wifi power sequence. Unfortunately the polarity of the reset
> GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and
> later in 3 B+. This wasn't discovered before since the power sequence
> takes only effect in case the relevant MMC driver is compiled as a module.
>
> Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> Cc: stable@vger.kernel.org
> Reported-by: Matthias Lueschner <lueschem@gmail.com>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>
> Hi, i like to have this included in 4.20 if possible.
Reviewed-by: Eric Anholt <eric@anholt.net>
Florian, would you be able to pick this directly to a -fixes branch?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs
2018-12-03 18:37 ` Stefan Wahren
@ 2018-12-03 19:51 ` Florian Fainelli
-1 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2018-12-03 19:51 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Ray Jui, Scott Branden,
Eric Anholt, Arnd Bergmann, olof, gregkh
Cc: linux-rpi-kernel, linux-arm-kernel, arm, stable
On Mon, 3 Dec 2018 19:37:08 +0100, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> introduced a wifi power sequence. Unfortunately the polarity of the reset
> GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and
> later in 3 B+. This wasn't discovered before since the power sequence
> takes only effect in case the relevant MMC driver is compiled as a module.
>
> Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> Cc: stable@vger.kernel.org
> Reported-by: Matthias Lueschner <lueschem@gmail.com>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Applied to devicetree/fixes, thanks!
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs
@ 2018-12-03 19:51 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2018-12-03 19:51 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Ray Jui, Scott Branden,
Eric Anholt, Arnd Bergmann, olof, gregkh
Cc: stable, arm, linux-rpi-kernel, linux-arm-kernel
On Mon, 3 Dec 2018 19:37:08 +0100, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> introduced a wifi power sequence. Unfortunately the polarity of the reset
> GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and
> later in 3 B+. This wasn't discovered before since the power sequence
> takes only effect in case the relevant MMC driver is compiled as a module.
>
> Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> Cc: stable@vger.kernel.org
> Reported-by: Matthias Lueschner <lueschem@gmail.com>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Applied to devicetree/fixes, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-03 19:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 18:37 [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs Stefan Wahren
2018-12-03 18:37 ` Stefan Wahren
2018-12-03 18:59 ` Eric Anholt
2018-12-03 18:59 ` Eric Anholt
2018-12-03 19:51 ` Florian Fainelli
2018-12-03 19:51 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.