All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>,
	Deepak Rawat <drawat@vmware.com>
Cc: igt-dev@lists.freedesktop.org, thellstrom@vmware.com,
	linux-graphics-maintainer@vmware.com,
	intel-gfx@lists.freedesktop.org, syeh@vmware.com
Subject: Re: [PATCH i-g-t 1/5] lib/igt_vmwgfx: Add vmwgfx device
Date: Thu, 06 Sep 2018 13:54:29 +0300	[thread overview]
Message-ID: <87musuzyje.fsf@intel.com> (raw)
In-Reply-To: <20180906084233.34swc4kmzxzcc77r@platvala-desk.ger.corp.intel.com>

On Thu, 06 Sep 2018, Petri Latvala <petri.latvala@intel.com> wrote:
> On Wed, Sep 05, 2018 at 05:03:46PM -0700, Deepak Rawat wrote:
>> Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests.
>> 
>> Signed-off-by: Deepak Rawat <drawat@vmware.com>
>> ---
>>  lib/drmtest.c | 9 ++++++++-
>>  lib/drmtest.h | 3 +++
>>  2 files changed, 11 insertions(+), 1 deletion(-)
>> 
>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>> index bfa2e0f0..563d5b8b 100644
>> --- a/lib/drmtest.c
>> +++ b/lib/drmtest.c
>> @@ -105,6 +105,11 @@ bool is_i915_device(int fd)
>>  	return __is_device(fd, "i915");
>>  }
>>  
>> +bool is_vmwgfx_device(int fd)
>> +{
>> +	return __is_device(fd, "vmwg");
>> +}
>> +
>>  static bool has_known_intel_chipset(int fd)
>>  {
>>  	struct drm_i915_getparam gp;
>> @@ -205,7 +210,7 @@ static const struct module {
>>  	{ DRIVER_VC4, "vc4" },
>>  	{ DRIVER_VGEM, "vgem" },
>>  	{ DRIVER_VIRTIO, "virtio-gpu" },
>> -	{ DRIVER_VIRTIO, "virtio_gpu" },
>> +	{ DRIVER_VMWGFX, "vmwgfx" },
>>  	{}
>
>
> Don't remove the second virtio-gpu line, there's a reason for it.
>
> .... we should probably add a comment there.

Don't keep us in suspense!

Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>,
	Deepak Rawat <drawat@vmware.com>
Cc: igt-dev@lists.freedesktop.org, thellstrom@vmware.com,
	linux-graphics-maintainer@vmware.com,
	intel-gfx@lists.freedesktop.org, syeh@vmware.com
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/5] lib/igt_vmwgfx: Add vmwgfx device
Date: Thu, 06 Sep 2018 13:54:29 +0300	[thread overview]
Message-ID: <87musuzyje.fsf@intel.com> (raw)
In-Reply-To: <20180906084233.34swc4kmzxzcc77r@platvala-desk.ger.corp.intel.com>

On Thu, 06 Sep 2018, Petri Latvala <petri.latvala@intel.com> wrote:
> On Wed, Sep 05, 2018 at 05:03:46PM -0700, Deepak Rawat wrote:
>> Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests.
>> 
>> Signed-off-by: Deepak Rawat <drawat@vmware.com>
>> ---
>>  lib/drmtest.c | 9 ++++++++-
>>  lib/drmtest.h | 3 +++
>>  2 files changed, 11 insertions(+), 1 deletion(-)
>> 
>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>> index bfa2e0f0..563d5b8b 100644
>> --- a/lib/drmtest.c
>> +++ b/lib/drmtest.c
>> @@ -105,6 +105,11 @@ bool is_i915_device(int fd)
>>  	return __is_device(fd, "i915");
>>  }
>>  
>> +bool is_vmwgfx_device(int fd)
>> +{
>> +	return __is_device(fd, "vmwg");
>> +}
>> +
>>  static bool has_known_intel_chipset(int fd)
>>  {
>>  	struct drm_i915_getparam gp;
>> @@ -205,7 +210,7 @@ static const struct module {
>>  	{ DRIVER_VC4, "vc4" },
>>  	{ DRIVER_VGEM, "vgem" },
>>  	{ DRIVER_VIRTIO, "virtio-gpu" },
>> -	{ DRIVER_VIRTIO, "virtio_gpu" },
>> +	{ DRIVER_VMWGFX, "vmwgfx" },
>>  	{}
>
>
> Don't remove the second virtio-gpu line, there's a reason for it.
>
> .... we should probably add a comment there.

Don't keep us in suspense!

Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-09-06 10:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06  0:03 [PATCH i-g-t 0/5] vmwgfx as a new driver for igt-gpu-tools Deepak Rawat
2018-09-06  0:03 ` [igt-dev] " Deepak Rawat
2018-09-06  0:03 ` [PATCH i-g-t 1/5] lib/igt_vmwgfx: Add vmwgfx device Deepak Rawat
2018-09-06  0:03   ` [igt-dev] " Deepak Rawat
2018-09-06  8:42   ` Petri Latvala
2018-09-06  8:42     ` [igt-dev] " Petri Latvala
2018-09-06 10:54     ` Jani Nikula [this message]
2018-09-06 10:54       ` [igt-dev] [Intel-gfx] " Jani Nikula
2018-09-06  0:03 ` [PATCH i-g-t 2/5] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers Deepak Rawat
2018-09-06  0:03   ` [igt-dev] " Deepak Rawat
2018-09-06  8:49   ` Chris Wilson
2018-09-06  8:49     ` Chris Wilson
2018-09-06  0:03 ` [PATCH i-g-t 3/5] tests/kms: Don't check crtc state for vmwgfx legacy set_crtc Deepak Rawat
2018-09-06  0:03   ` [Intel-gfx] " Deepak Rawat
2018-09-06  8:54   ` [igt-dev] " Chris Wilson
2018-09-06  8:54     ` [Intel-gfx] " Chris Wilson
2018-09-06  0:03 ` [PATCH i-g-t 4/5] lib/igt_fb: Check for stride before creating cairo surface Deepak Rawat
2018-09-06  0:03   ` [igt-dev] " Deepak Rawat
2018-09-06  8:58   ` Chris Wilson
2018-09-06  8:58     ` [igt-dev] [Intel-gfx] " Chris Wilson
2018-09-06 22:24     ` Deepak Singh Rawat
2018-09-06 22:24       ` [igt-dev] [Intel-gfx] " Deepak Singh Rawat
2018-09-06  0:03 ` [PATCH i-g-t 5/5] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Deepak Rawat
2018-09-06  0:03   ` Deepak Rawat
2018-09-06 10:10 ` [igt-dev] ✓ Fi.CI.BAT: success for vmwgfx as a new driver for igt-gpu-tools Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87musuzyje.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=drawat@vmware.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=petri.latvala@intel.com \
    --cc=syeh@vmware.com \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.