All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Timur Kristóf" <timur.kristof@gmail.com>
Cc: Ryan Hsu <ryanhsu@codeaurora.org>,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: Update the phymode along with bandwidth change request
Date: Tue, 12 Jun 2018 14:40:37 +0300	[thread overview]
Message-ID: <87muw0cjwq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <944989ec907b98716f252524cf55e41807965253.camel@gmail.com> ("Timur \=\?utf-8\?Q\?Krist\=C3\=B3f\=22's\?\= message of "Mon, 11 Jun 2018 18:05:53 +0200")

Timur Krist=C3=B3f <timur.kristof@gmail.com> writes:

> On Fri, 2018-06-08 at 11:32 -0700, Ryan Hsu wrote:
>> In the case of Station connects to AP with narrower bandwidth at
>> beginning.
>> And later the AP changes the bandwidth to winder bandwidth, the AP
>> will
>> beacon with wider bandwidth IE, eg VHT20->VHT40->VHT80 or VHT40-
>> >VHT80.
>>=20
>> Since the supported BANDWIDTH will be limited by the PHYMODE, so
>> while
>> Station receives the bandwidth change request, it will also need to
>> reconfigure the PHYMODE setting to firmware instead of just
>> configuring
>> the BANDWIDTH info, otherwise it'll trigger a firmware crash with
>> non-support bandwidth.
>>=20
>> The issue was observed in WLAN.RM.4.4.1-00051-QCARMSWP-1, QCA6174
>> with
>> below scenario.

[...]

> I can confirm that this patch works on my machine, and prevents the
> crash previously caused by changing the bandwidth.

Great, thanks a lot for working on this. I'll add your Tested-by to the
commit log.

> Can it be accepted, or is there anything I can help with, to get it
> accepted?

Strangely I can't find Timur's version of the patch from patchwork:

https://patchwork.kernel.org/project/linux-wireless/list/?state=3D*

Maybe it got dropped due to some UTF-8 problems? patchwork is known to
be problematic with UTF-8.

Anyway, I'll queue Ryan's v2 to 4.18. It first goes to the pending
branch for build testing and from there to ath-current branch.

--=20
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Timur Kristóf" <timur.kristof@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Ryan Hsu <ryanhsu@codeaurora.org>
Subject: Re: [PATCH v2] ath10k: Update the phymode along with bandwidth change request
Date: Tue, 12 Jun 2018 14:40:37 +0300	[thread overview]
Message-ID: <87muw0cjwq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <944989ec907b98716f252524cf55e41807965253.camel@gmail.com> ("Timur \=\?utf-8\?Q\?Krist\=C3\=B3f\=22's\?\= message of "Mon, 11 Jun 2018 18:05:53 +0200")

Timur Kristóf <timur.kristof@gmail.com> writes:

> On Fri, 2018-06-08 at 11:32 -0700, Ryan Hsu wrote:
>> In the case of Station connects to AP with narrower bandwidth at
>> beginning.
>> And later the AP changes the bandwidth to winder bandwidth, the AP
>> will
>> beacon with wider bandwidth IE, eg VHT20->VHT40->VHT80 or VHT40-
>> >VHT80.
>> 
>> Since the supported BANDWIDTH will be limited by the PHYMODE, so
>> while
>> Station receives the bandwidth change request, it will also need to
>> reconfigure the PHYMODE setting to firmware instead of just
>> configuring
>> the BANDWIDTH info, otherwise it'll trigger a firmware crash with
>> non-support bandwidth.
>> 
>> The issue was observed in WLAN.RM.4.4.1-00051-QCARMSWP-1, QCA6174
>> with
>> below scenario.

[...]

> I can confirm that this patch works on my machine, and prevents the
> crash previously caused by changing the bandwidth.

Great, thanks a lot for working on this. I'll add your Tested-by to the
commit log.

> Can it be accepted, or is there anything I can help with, to get it
> accepted?

Strangely I can't find Timur's version of the patch from patchwork:

https://patchwork.kernel.org/project/linux-wireless/list/?state=*

Maybe it got dropped due to some UTF-8 problems? patchwork is known to
be problematic with UTF-8.

Anyway, I'll queue Ryan's v2 to 4.18. It first goes to the pending
branch for build testing and from there to ath-current branch.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-06-12 11:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 18:32 [PATCH v2] ath10k: Update the phymode along with bandwidth change request Ryan Hsu
2018-06-08 18:32 ` Ryan Hsu
2018-06-11 16:05 ` Timur Kristóf
2018-06-11 16:05   ` Timur Kristóf
2018-06-12 11:40   ` Kalle Valo [this message]
2018-06-12 11:40     ` Kalle Valo
2018-06-12 12:21     ` Timur Kristóf
2018-06-12 12:21       ` Timur Kristóf
2018-06-13 10:00       ` Kalle Valo
2018-06-13 10:00         ` Kalle Valo
2018-06-14  9:07 ` Kalle Valo
2018-06-14  9:07   ` Kalle Valo
2018-06-15  0:16   ` Ryan Hsu
2018-06-15  0:16     ` Ryan Hsu
2018-06-28  9:28 ` [v2] " Kalle Valo
2018-06-28  9:28 ` Kalle Valo
     [not found] ` <20180628092800.6517B608C8@smtp.codeaurora.org>
2018-06-30 13:56   ` Timur Kristóf
2018-06-30 13:56     ` Timur Kristóf
2018-06-30 17:32     ` Kalle Valo
2018-06-30 17:32       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muw0cjwq.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ryanhsu@codeaurora.org \
    --cc=timur.kristof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.