[Qemu-devel] [PATCH v3] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet

* [Qemu-devel] [PATCH v3] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet
@ 2017-02-08 17:57 Thomas Huth
  2017-02-09  7:27 ` Markus Armbruster
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2017-02-08 17:57 UTC (permalink / raw)
  To: Alistair Francis, qemu-devel; +Cc: qemu-trivial, Markus Armbruster

The "or-irq" device needs to be wired up in source code, there is no
way the user can make any real use of this device with the "-device"
parameter or the "device_add" monitor command yet.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 v3: Another update to the patch description and comment

 hw/core/or-irq.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c
index 1ac090d..1485d5b 100644
--- a/hw/core/or-irq.c
+++ b/hw/core/or-irq.c
@@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data)
     dc->props = or_irq_properties;
     dc->realize = or_irq_realize;
     dc->vmsd = &vmstate_or_irq;
+
+    /* Reason: Needs to be wired up to work, e.g. see stm32f205_soc.c */
+    dc->cannot_instantiate_with_device_add_yet = true;
 }
 
 static const TypeInfo or_irq_type_info = {
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread