All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
@ 2016-09-11 13:57 Adrien Vergé
  2016-09-12  9:54 ` ✗ Fi.CI.BAT: warning for " Patchwork
  2016-09-13  9:34   ` Jani Nikula
  0 siblings, 2 replies; 4+ messages in thread
From: Adrien Vergé @ 2016-09-11 13:57 UTC (permalink / raw)
  To: Ville Syrjälä, Daniel Vetter, Jani Nikula, David Airlie
  Cc: intel-gfx, dri-devel, linux-kernel, Adrien Vergé

On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166),
the screen is tiled in many 480×320 screens (like a mosaic) since v4.7.
This laptop is simply unusable.

I have bisected the cause to commit a05628195a0d ("drm/i915: Get
panel_type from OpRegion panel details").

Like for Skylake, it seems that using the OpRegion panel type (here, 0)
causes the problem, whereas the VBT panel type (here, 7) gives a normal
display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from
OpRegion on SKL") for background on this Skylake fix.

This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips.

Tested-by: Adrien Vergé <adrienverge@gmail.com>
Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
---
 drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index adca262..94e2db7 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
 		return -ENODEV;
 	}
 
+	/*
+	 * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the
+	 * OpRegion panel type (0) results in tiled ("mosaic") display bug,
+	 * whereas the VBT panel type (7) gives a normal display.
+	 * Let's ignore the OpRegion panel type for this chip.
+	 */
+	if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
+		DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
+		return -ENODEV;
+	}
+
 	return ret - 1;
 }
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
  2016-09-11 13:57 [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile Adrien Vergé
@ 2016-09-12  9:54 ` Patchwork
  2016-09-13  9:34   ` Jani Nikula
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-09-12  9:54 UTC (permalink / raw)
  To: Adrien Vergé; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
URL   : https://patchwork.freedesktop.org/series/12322/
State : warning

== Summary ==

Series 12322v1 drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
https://patchwork.freedesktop.org/api/1.0/series/12322/revisions/1/mbox/

Test drv_module_reload_basic:
                pass       -> SKIP       (fi-skl-6260u)
Test kms_cursor_legacy:
        Subgroup basic-cursor-vs-flip-varying-size:
                fail       -> PASS       (fi-bsw-n3050)

fi-bdw-5557u     total:254  pass:239  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:254  pass:208  dwarn:0   dfail:0   fail:0   skip:46 
fi-byt-n2820     total:254  pass:212  dwarn:0   dfail:0   fail:1   skip:41 
fi-hsw-4770k     total:254  pass:232  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:254  pass:228  dwarn:0   dfail:0   fail:0   skip:26 
fi-ilk-650       total:254  pass:184  dwarn:0   dfail:0   fail:2   skip:68 
fi-ivb-3520m     total:254  pass:223  dwarn:0   dfail:0   fail:0   skip:31 
fi-ivb-3770      total:254  pass:223  dwarn:0   dfail:0   fail:0   skip:31 
fi-skl-6260u     total:254  pass:239  dwarn:0   dfail:0   fail:0   skip:15 
fi-skl-6700hq    total:254  pass:227  dwarn:0   dfail:0   fail:1   skip:26 
fi-skl-6700k     total:254  pass:225  dwarn:1   dfail:0   fail:0   skip:28 
fi-snb-2520m     total:254  pass:209  dwarn:0   dfail:0   fail:0   skip:45 
fi-snb-2600      total:254  pass:209  dwarn:0   dfail:0   fail:0   skip:45 

Results at /archive/results/CI_IGT_test/Patchwork_2510/

bef9c1f4afe24cfff578d386bde349add65673eb drm-intel-nightly: 2016y-09m-12d-08h-35m-02s UTC integration manifest
178ee09 drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
  2016-09-11 13:57 [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile Adrien Vergé
@ 2016-09-13  9:34   ` Jani Nikula
  2016-09-13  9:34   ` Jani Nikula
  1 sibling, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-09-13  9:34 UTC (permalink / raw)
  To: Adrien Vergé, Ville Syrjälä, Daniel Vetter, David Airlie
  Cc: intel-gfx, dri-devel, linux-kernel, Adrien Vergé

On Sun, 11 Sep 2016, Adrien Vergé <adrienverge@gmail.com> wrote:
> On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166),
> the screen is tiled in many 480×320 screens (like a mosaic) since v4.7.
> This laptop is simply unusable.
>
> I have bisected the cause to commit a05628195a0d ("drm/i915: Get
> panel_type from OpRegion panel details").
>
> Like for Skylake, it seems that using the OpRegion panel type (here, 0)
> causes the problem, whereas the VBT panel type (here, 7) gives a normal
> display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from
> OpRegion on SKL") for background on this Skylake fix.
>
> This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips.

Please try this patch [1] instead, and reply to it if it works for you.

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com

>
> Tested-by: Adrien Vergé <adrienverge@gmail.com>
> Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
> ---
>  drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index adca262..94e2db7 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
>  		return -ENODEV;
>  	}
>  
> +	/*
> +	 * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the
> +	 * OpRegion panel type (0) results in tiled ("mosaic") display bug,
> +	 * whereas the VBT panel type (7) gives a normal display.
> +	 * Let's ignore the OpRegion panel type for this chip.
> +	 */
> +	if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
> +		DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> +		return -ENODEV;
> +	}
> +
>  	return ret - 1;
>  }

-- 
Jani Nikula, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile
@ 2016-09-13  9:34   ` Jani Nikula
  0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-09-13  9:34 UTC (permalink / raw)
  To: Ville Syrjälä, Daniel Vetter, David Airlie
  Cc: intel-gfx, dri-devel, linux-kernel, Adrien Vergé

On Sun, 11 Sep 2016, Adrien Vergé <adrienverge@gmail.com> wrote:
> On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166),
> the screen is tiled in many 480×320 screens (like a mosaic) since v4.7.
> This laptop is simply unusable.
>
> I have bisected the cause to commit a05628195a0d ("drm/i915: Get
> panel_type from OpRegion panel details").
>
> Like for Skylake, it seems that using the OpRegion panel type (here, 0)
> causes the problem, whereas the VBT panel type (here, 7) gives a normal
> display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from
> OpRegion on SKL") for background on this Skylake fix.
>
> This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips.

Please try this patch [1] instead, and reply to it if it works for you.

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com

>
> Tested-by: Adrien Vergé <adrienverge@gmail.com>
> Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
> ---
>  drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index adca262..94e2db7 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
>  		return -ENODEV;
>  	}
>  
> +	/*
> +	 * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the
> +	 * OpRegion panel type (0) results in tiled ("mosaic") display bug,
> +	 * whereas the VBT panel type (7) gives a normal display.
> +	 * Let's ignore the OpRegion panel type for this chip.
> +	 */
> +	if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
> +		DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> +		return -ENODEV;
> +	}
> +
>  	return ret - 1;
>  }

-- 
Jani Nikula, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-13  9:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-11 13:57 [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile Adrien Vergé
2016-09-12  9:54 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-09-13  9:34 ` [PATCH] " Jani Nikula
2016-09-13  9:34   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.