All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	paul@pwsan.com, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH 3/7] OMAP3: beagle-board: Use the omap_hwmod_name_get_dev API
Date: Wed, 31 Aug 2011 15:24:46 -0700	[thread overview]
Message-ID: <87mxep8bip.fsf@ti.com> (raw)
In-Reply-To: <1314026347-21623-4-git-send-email-b-cousson@ti.com> (Benoit Cousson's message of "Mon, 22 Aug 2011 17:19:03 +0200")

Benoit Cousson <b-cousson@ti.com> writes:

> Replace the multiple omap2_get_XXX_device APIs with the new
> omap_hwmod_name_get_dev that uses the hwmod name to get the proper
> device.
>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 3ae16b4..dab16e0 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -493,8 +493,8 @@ static void __init beagle_opp_init(void)
>  	if (cpu_is_omap3630()) {
>  		struct device *mpu_dev, *iva_dev;
>  
> -		mpu_dev = omap2_get_mpuss_device();
> -		iva_dev = omap2_get_iva_device();
> +		mpu_dev = omap_hwmod_name_get_dev("mpu");
> +		iva_dev = omap_hwmod_name_get_dev("iva");
>  
>  		if (!mpu_dev || !iva_dev) {
>  			pr_err("%s: Aiee.. no mpu/dsp devices? %p %p\n",

Looks fine.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] OMAP3: beagle-board: Use the omap_hwmod_name_get_dev API
Date: Wed, 31 Aug 2011 15:24:46 -0700	[thread overview]
Message-ID: <87mxep8bip.fsf@ti.com> (raw)
In-Reply-To: <1314026347-21623-4-git-send-email-b-cousson@ti.com> (Benoit Cousson's message of "Mon, 22 Aug 2011 17:19:03 +0200")

Benoit Cousson <b-cousson@ti.com> writes:

> Replace the multiple omap2_get_XXX_device APIs with the new
> omap_hwmod_name_get_dev that uses the hwmod name to get the proper
> device.
>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 3ae16b4..dab16e0 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -493,8 +493,8 @@ static void __init beagle_opp_init(void)
>  	if (cpu_is_omap3630()) {
>  		struct device *mpu_dev, *iva_dev;
>  
> -		mpu_dev = omap2_get_mpuss_device();
> -		iva_dev = omap2_get_iva_device();
> +		mpu_dev = omap_hwmod_name_get_dev("mpu");
> +		iva_dev = omap_hwmod_name_get_dev("iva");
>  
>  		if (!mpu_dev || !iva_dev) {
>  			pr_err("%s: Aiee.. no mpu/dsp devices? %p %p\n",

Looks fine.

Kevin

  reply	other threads:[~2011-08-31 22:24 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 15:19 [PATCH 0/7] OMAP: omap_device cleanup before device-tree integration Benoit Cousson
2011-08-22 15:19 ` Benoit Cousson
2011-08-22 15:19 ` [PATCH 1/7] OMAP: PM: omap_device: add omap_hwmod_name_get_odev Benoit Cousson
2011-08-22 15:19   ` Benoit Cousson
2011-08-31 22:20   ` Kevin Hilman
2011-08-31 22:20     ` Kevin Hilman
2011-09-01 11:48     ` Cousson, Benoit
2011-09-01 11:48       ` Cousson, Benoit
2011-09-01 20:44       ` Menon, Nishanth
2011-09-01 20:44         ` Menon, Nishanth
2011-09-26 18:18   ` Kevin Hilman
2011-09-26 18:18     ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 2/7] OMAP: PM: omap_device: add few quick access functions Benoit Cousson
2011-08-22 15:19   ` Benoit Cousson
2011-08-31 22:23   ` Kevin Hilman
2011-08-31 22:23     ` Kevin Hilman
2011-09-01 11:55     ` Cousson, Benoit
2011-09-01 11:55       ` Cousson, Benoit
2011-09-01 14:55       ` Kevin Hilman
2011-09-01 14:55         ` Kevin Hilman
2011-09-02 12:39     ` Cousson, Benoit
2011-09-02 12:39       ` Cousson, Benoit
2011-08-22 15:19 ` [PATCH 3/7] OMAP3: beagle-board: Use the omap_hwmod_name_get_dev API Benoit Cousson
2011-08-22 15:19   ` Benoit Cousson
2011-08-31 22:24   ` Kevin Hilman [this message]
2011-08-31 22:24     ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 4/7] OMAP2+: pm: Use hwmod name instead of dev pointer Benoit Cousson
2011-08-22 15:19   ` Benoit Cousson
2011-08-31 22:24   ` Kevin Hilman
2011-08-31 22:24     ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 5/7] OMAP2+: pm: Remove static devices variable for mpu, dsp, iva and l3 PM Benoit Cousson
2011-08-22 15:19   ` Benoit Cousson
2011-08-31 22:25   ` Kevin Hilman
2011-08-31 22:25     ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 6/7] OMAP: omap_device: Create a default omap_device_pm_latency Benoit Cousson
2011-08-22 15:19   ` Benoit Cousson
2011-08-31 22:30   ` Kevin Hilman
2011-08-31 22:30     ` Kevin Hilman
2011-08-22 15:19 ` [PATCH 7/7] OMAP2+: devices: Remove all omap_device_pm_latency structures Benoit Cousson
2011-08-22 15:19   ` Benoit Cousson
2011-08-31 22:31   ` Kevin Hilman
2011-08-31 22:31     ` Kevin Hilman
2011-09-01 11:59     ` Cousson, Benoit
2011-09-01 11:59       ` Cousson, Benoit
2011-09-01 16:28 ` [PATCH 0/7] OMAP: omap_device cleanup before device-tree integration Kevin Hilman
2011-09-01 16:28   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxep8bip.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.