From: Kevin Hilman <khilman@ti.com> To: Jarkko Nikula <jhnikula@gmail.com> Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/6] OMAP: McBSP: use existing macros for converting between devices Date: Fri, 05 Aug 2011 07:57:54 -0700 [thread overview] Message-ID: <87mxfnucr1.fsf@ti.com> (raw) In-Reply-To: <20110805090244.f6e5f65a6829138d929bd4a9@gmail.com> (Jarkko Nikula's message of "Fri, 5 Aug 2011 09:02:44 +0300") Jarkko Nikula <jhnikula@gmail.com> writes: > Hi Kevin > > On Thu, 4 Aug 2011 08:45:10 -0700 > Kevin Hilman <khilman@ti.com> wrote: > >> For converting from struct device to platform_device, and from >> platform_device to struct omap_device, there are existing macros. Use >> them instead of manual use of container_of(). >> >> Signed-off-by: Kevin Hilman <khilman@ti.com> >> --- >> arch/arm/plat-omap/mcbsp.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c >> index 3c1fbdc..47016f7 100644 >> --- a/arch/arm/plat-omap/mcbsp.c >> +++ b/arch/arm/plat-omap/mcbsp.c >> @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); >> #ifdef CONFIG_ARCH_OMAP3 >> static struct omap_device *find_omap_device_by_dev(struct device *dev) >> { >> - struct platform_device *pdev = container_of(dev, >> - struct platform_device, dev); >> - return container_of(pdev, struct omap_device, pdev); >> + struct platform_device *pdev = to_platform_device(dev); >> + >> + return to_omap_device(pdev); >> } >> > I have a better alternative (that removes these unused lines) here: > > http://marc.info/?l=linux-omap&m=130951039226392&w=2 Indeed, that's a much better alternative. I didn't bother to check if th resulting omap_device pointer was actually used. > I'm fine if you need to take my patch if there's urgent need to modify > these lines or otherwise I can carry it when sending an updated version > of my earlier McBSP cleanup set. Yeah, yours is a better patch and we should take that one. Feel free to add Acked-by: Kevin Hilman <khilman@ti.com> I'll include it in my series for reference also (because I need it due to modifying how platform_device is contained within an omap_device) but yours will probably make it upstream first since I'm about to go offline for ~2 weeks. Thanks, Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/6] OMAP: McBSP: use existing macros for converting between devices Date: Fri, 05 Aug 2011 07:57:54 -0700 [thread overview] Message-ID: <87mxfnucr1.fsf@ti.com> (raw) In-Reply-To: <20110805090244.f6e5f65a6829138d929bd4a9@gmail.com> (Jarkko Nikula's message of "Fri, 5 Aug 2011 09:02:44 +0300") Jarkko Nikula <jhnikula@gmail.com> writes: > Hi Kevin > > On Thu, 4 Aug 2011 08:45:10 -0700 > Kevin Hilman <khilman@ti.com> wrote: > >> For converting from struct device to platform_device, and from >> platform_device to struct omap_device, there are existing macros. Use >> them instead of manual use of container_of(). >> >> Signed-off-by: Kevin Hilman <khilman@ti.com> >> --- >> arch/arm/plat-omap/mcbsp.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c >> index 3c1fbdc..47016f7 100644 >> --- a/arch/arm/plat-omap/mcbsp.c >> +++ b/arch/arm/plat-omap/mcbsp.c >> @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); >> #ifdef CONFIG_ARCH_OMAP3 >> static struct omap_device *find_omap_device_by_dev(struct device *dev) >> { >> - struct platform_device *pdev = container_of(dev, >> - struct platform_device, dev); >> - return container_of(pdev, struct omap_device, pdev); >> + struct platform_device *pdev = to_platform_device(dev); >> + >> + return to_omap_device(pdev); >> } >> > I have a better alternative (that removes these unused lines) here: > > http://marc.info/?l=linux-omap&m=130951039226392&w=2 Indeed, that's a much better alternative. I didn't bother to check if th resulting omap_device pointer was actually used. > I'm fine if you need to take my patch if there's urgent need to modify > these lines or otherwise I can carry it when sending an updated version > of my earlier McBSP cleanup set. Yeah, yours is a better patch and we should take that one. Feel free to add Acked-by: Kevin Hilman <khilman@ti.com> I'll include it in my series for reference also (because I need it due to modifying how platform_device is contained within an omap_device) but yours will probably make it upstream first since I'm about to go offline for ~2 weeks. Thanks, Kevin
next prev parent reply other threads:[~2011-08-05 14:57 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-04 15:45 [PATCH 0/6] OMAP: misc. PM-related fixes for v3.1-rc Kevin Hilman 2011-08-04 15:45 ` Kevin Hilman 2011-08-04 15:45 ` [PATCH 1/6] OMAP2+: Kconfig: don't select PM in OMAP2PLUS_TYPICAL Kevin Hilman 2011-08-04 15:45 ` Kevin Hilman 2011-08-04 15:45 ` [PATCH 2/6] OMAP3+: SR: ensure pm-runtime callbacks can be invoked with IRQs disabled Kevin Hilman 2011-08-04 15:45 ` Kevin Hilman 2011-08-04 15:45 ` [PATCH 3/6] OMAP1: enable GENERIC_IRQ_CHIP Kevin Hilman 2011-08-04 15:45 ` Kevin Hilman 2011-08-04 15:45 ` [PATCH 4/6] OMAP3: beagle: don't touch omap_device internals Kevin Hilman 2011-08-04 15:45 ` Kevin Hilman 2011-08-04 15:45 ` [PATCH 5/6] OMAP2+: PM: SmartReflex: use put_sync_suspend for IRQ-safe disabling Kevin Hilman 2011-08-04 15:45 ` Kevin Hilman 2011-08-04 15:45 ` [PATCH 6/6] OMAP: McBSP: use existing macros for converting between devices Kevin Hilman 2011-08-04 15:45 ` Kevin Hilman 2011-08-05 6:02 ` Jarkko Nikula 2011-08-05 6:02 ` Jarkko Nikula 2011-08-05 14:57 ` Kevin Hilman [this message] 2011-08-05 14:57 ` Kevin Hilman 2011-08-09 11:14 ` [PATCH 0/6] OMAP: misc. PM-related fixes for v3.1-rc Tony Lindgren 2011-08-09 11:14 ` Tony Lindgren 2011-08-10 10:39 ` Tony Lindgren 2011-08-10 10:39 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87mxfnucr1.fsf@ti.com \ --to=khilman@ti.com \ --cc=jhnikula@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.