[RFC] bitbake git fetcher fix

[RFC] bitbake git fetcher fix

[Otavio Salvador]

Hello,

I've found a issue when using current GIT fetcher and bellow patch
fixes it for me; could someone take a look at it and commit if it does
look fine?

Cheers,

Index: lib/bb/fetch/git.py
===================================================================
--- lib/bb/fetch/git.py	(revisão 1150)
+++ lib/bb/fetch/git.py	(cópia de trabalho)
@@ -42,19 +42,17 @@
             ud.proto = ud.parm['protocol']
 
         ud.branch = ud.parm.get("branch", "master")
+        ud.tag = None
 
         tag = Fetch.srcrev_internal_helper(ud, d)
         if tag is True:
             ud.tag = self.latest_revision(url, ud, d)	
-        elif tag:
+        elif tag and tag != "1":
             ud.tag = tag
 
-        if not ud.tag:
+        if not ud.tag or ud.tag == "master":
             ud.tag = self.latest_revision(url, ud, d)	
 
-        if ud.tag == "master":
-            ud.tag = self.latest_revision(url, ud, d)
-
         ud.localfile = data.expand('git_%s%s_%s.tar.gz' % (ud.host, ud.path.replace('/', '.'), ud.tag), d)
 
         return os.path.join(data.getVar("DL_DIR", d, True), ud.localfile)

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."

Re: [RFC] bitbake git fetcher fix

[Koen Kooi]

On 06-01-09 15:12, Otavio Salvador wrote:
> Hello,
>
> I've found a issue when using current GIT fetcher and bellow patch
> fixes it for me; could someone take a look at it and commit if it does
> look fine?

> +        elif tag and tag != "1":

That looks to be a hack for lazy people that don't specify a SRCREV nor 
set AUTOREV. Such a fetch failure is intended behaviour.

regards,

Koen.

Re: [RFC] bitbake git fetcher fix

[Richard Purdie]

On Tue, 2009-01-06 at 16:41 +0100, Koen Kooi wrote:
> On 06-01-09 15:12, Otavio Salvador wrote:
> > Hello,
> >
> > I've found a issue when using current GIT fetcher and bellow patch
> > fixes it for me; could someone take a look at it and commit if it does
> > look fine?
> 
> > +        elif tag and tag != "1":
> 
> That looks to be a hack for lazy people that don't specify a SRCREV nor 
> set AUTOREV. Such a fetch failure is intended behaviour.

How about we adopt Poky's slightly more verbose approach of SRCREV ?=
"INVALID" in bitbake.conf?

We check for "INVALID" in bitbake and error if we see it.

Cheers,

Richard

Re: [RFC] bitbake git fetcher fix

[Koen Kooi]

On 06-01-09 17:47, Richard Purdie wrote:
> On Tue, 2009-01-06 at 16:41 +0100, Koen Kooi wrote:
>> On 06-01-09 15:12, Otavio Salvador wrote:
>>> Hello,
>>>
>>> I've found a issue when using current GIT fetcher and bellow patch
>>> fixes it for me; could someone take a look at it and commit if it does
>>> look fine?
>>> +        elif tag and tag != "1":
>> That looks to be a hack for lazy people that don't specify a SRCREV nor
>> set AUTOREV. Such a fetch failure is intended behaviour.
>
> How about we adopt Poky's slightly more verbose approach of SRCREV ?=
> "INVALID" in bitbake.conf?
>
> We check for "INVALID" in bitbake and error if we see it.

I like how it's more "in your face" about it :)

regards,

Koen

Re: [RFC] bitbake git fetcher fix

[Otavio Salvador]

Koen Kooi <k.kooi@student.utwente.nl> writes:

> On 06-01-09 15:12, Otavio Salvador wrote:
>> Hello,
>>
>> I've found a issue when using current GIT fetcher and bellow patch
>> fixes it for me; could someone take a look at it and commit if it does
>> look fine?
>
>> +        elif tag and tag != "1":
>
> That looks to be a hack for lazy people that don't specify a SRCREV
> nor set AUTOREV. Such a fetch failure is intended behaviour.

Since I'm this lazy people, could you tell me what I'm suppose to put
in SRCREV to use AUTOREV and solve this?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."

Re: [RFC] bitbake git fetcher fix

[Otavio Salvador]

Richard Purdie <rpurdie@rpsys.net> writes:

> How about we adopt Poky's slightly more verbose approach of SRCREV ?=
> "INVALID" in bitbake.conf?
>
> We check for "INVALID" in bitbake and error if we see it.

This would saved my a lot of time ;-)

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."