[PATCH] iwlwifi: Mark IWLMEI as broken

[PATCH] iwlwifi: Mark IWLMEI as broken

[Toke Høiland-Jørgensen]

From: Toke Høiland-Jørgensen <toke@redhat.com>

The iwlmei driver breaks iwlwifi when returning from suspend; the bug
report[0] has been open for four months now, and now fix seems to be
forthcoming. Since just disabling the iwlmei driver works as a workaround,
let's mark the config option as broken until it can be fixed properly.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=215937

Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
 drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index a647a406b87b..b20409f8c13a 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -140,6 +140,7 @@ config IWLMEI
 	depends on INTEL_MEI
 	depends on PM
 	depends on CFG80211
+	depends on BROKEN
 	help
 	  Enables the iwlmei kernel module.
 
-- 
2.37.2

Re: [PATCH] iwlwifi: Mark IWLMEI as broken

[Emmanuel Grumbach]

Hi,


On Wed, Sep 7, 2022 at 5:02 PM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> From: Toke Høiland-Jørgensen <toke@redhat.com>
>
> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
> report[0] has been open for four months now, and now fix seems to be
> forthcoming. Since just disabling the iwlmei driver works as a workaround,
> let's mark the config option as broken until it can be fixed properly.
>
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
>
> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

I am not very proud of this, to say the least, but unfortunately,
despite Toke's patience and
his willingness to provide logs and all, I couldn't find the time to fix this.
We had tested against NetworkManager wpa_s, but not against iwd.
From the start, we thought distro wouldn't enable this and this is why
we disabled iwlmei by default.
This driver is meant to be used by specific groups that need this and
they'll know how to enable this
driver even if it is marked as BROKEN.

This is why, with a heavy heart:
Acked-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

I'd also suggest to CC this to stable 5.17+

Thanks Toke and Sorry!

> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index a647a406b87b..b20409f8c13a 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -140,6 +140,7 @@ config IWLMEI
>         depends on INTEL_MEI
>         depends on PM
>         depends on CFG80211
> +       depends on BROKEN
>         help
>           Enables the iwlmei kernel module.
>
> --
> 2.37.2
>

Re: [PATCH] iwlwifi: Mark IWLMEI as broken

[Toke Høiland-Jørgensen]

Emmanuel Grumbach <egrumbach@gmail.com> writes:

> Hi,
>
>
> On Wed, Sep 7, 2022 at 5:02 PM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> From: Toke Høiland-Jørgensen <toke@redhat.com>
>>
>> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
>> report[0] has been open for four months now, and now fix seems to be
>> forthcoming. Since just disabling the iwlmei driver works as a workaround,
>> let's mark the config option as broken until it can be fixed properly.
>>
>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
>>
>> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> I am not very proud of this, to say the least, but unfortunately,
> despite Toke's patience and
> his willingness to provide logs and all, I couldn't find the time to fix this.

Well, thanks for your efforts anyway :)

> We had tested against NetworkManager wpa_s, but not against iwd.
> From the start, we thought distro wouldn't enable this and this is why
> we disabled iwlmei by default.
> This driver is meant to be used by specific groups that need this and
> they'll know how to enable this
> driver even if it is marked as BROKEN.
>
> This is why, with a heavy heart:
> Acked-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

Thanks!

> I'd also suggest to CC this to stable 5.17+

I expect the Fixes tag will be enough to get this pulled into stable,
but I'll try to keep an eye on it and submit it there manually if not...

> Thanks Toke and Sorry!

You're welcome :)

-Toke

Re: [PATCH] iwlwifi: Mark IWLMEI as broken

[Kalle Valo]

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> From: Toke Høiland-Jørgensen <toke@redhat.com>
>
> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
> report[0] has been open for four months now, and now fix seems to be

s/now/no/? I can fix that.

> forthcoming. Since just disabling the iwlmei driver works as a workaround,
> let's mark the config option as broken until it can be fixed properly.
>
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937

So does the bug only happen with iwd? Should I mention that in the
commit log? It would be good to describe the conditions when the bug
happens.

> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

I assigned the patch to me on patchwork and will queue for v6.0.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] iwlwifi: Mark IWLMEI as broken

[Toke Høiland-Jørgensen]

Kalle Valo <kvalo@kernel.org> writes:

> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>
>> From: Toke Høiland-Jørgensen <toke@redhat.com>
>>
>> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
>> report[0] has been open for four months now, and now fix seems to be
>
> s/now/no/? I can fix that.

Yeah, oops, sorry...

>> forthcoming. Since just disabling the iwlmei driver works as a workaround,
>> let's mark the config option as broken until it can be fixed properly.
>>
>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
>
> So does the bug only happen with iwd? Should I mention that in the
> commit log? It would be good to describe the conditions when the bug
> happens.

Well, what happens is that the interface ends up in the 'down' state
after coming back from suspend. And iwd doesn't touch the interface
state, but wpa_supplicant does, so the user-visible "my WiFi doesn't
work" thing only happens on iwd...

>> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> I assigned the patch to me on patchwork and will queue for v6.0.

Great, thanks!

-Toke

Re: [PATCH] iwlwifi: Mark IWLMEI as broken

[Emmanuel Grumbach]

On Fri, Sep 9, 2022 at 8:59 AM Kalle Valo <kvalo@kernel.org> wrote:
>
> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>
> > From: Toke Høiland-Jørgensen <toke@redhat.com>
> >
> > The iwlmei driver breaks iwlwifi when returning from suspend; the bug
> > report[0] has been open for four months now, and now fix seems to be
>
> s/now/no/? I can fix that.
>
> > forthcoming. Since just disabling the iwlmei driver works as a workaround,
> > let's mark the config option as broken until it can be fixed properly.
> >
> > [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
>
> So does the bug only happen with iwd? Should I mention that in the
> commit log? It would be good to describe the conditions when the bug
> happens.

The only reports I am aware of are using iwd.

>
> > Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
> > Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> I assigned the patch to me on patchwork and will queue for v6.0.
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] iwlwifi: Mark IWLMEI as broken

[Kalle Valo]

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> Kalle Valo <kvalo@kernel.org> writes:
>
>> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>>
>>> forthcoming. Since just disabling the iwlmei driver works as a workaround,
>>> let's mark the config option as broken until it can be fixed properly.
>>>
>>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
>>
>> So does the bug only happen with iwd? Should I mention that in the
>> commit log? It would be good to describe the conditions when the bug
>> happens.
>
> Well, what happens is that the interface ends up in the 'down' state
> after coming back from suspend. And iwd doesn't touch the interface
> state, but wpa_supplicant does, so the user-visible "my WiFi doesn't
> work" thing only happens on iwd...

Thanks, I'll mention that in the commit log.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] iwlwifi: Mark IWLMEI as broken

[Kalle Valo]

Emmanuel Grumbach <egrumbach@gmail.com> writes:

> On Wed, Sep 7, 2022 at 5:02 PM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> From: Toke Høiland-Jørgensen <toke@redhat.com>
>>
>> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
>> report[0] has been open for four months now, and now fix seems to be
>> forthcoming. Since just disabling the iwlmei driver works as a workaround,
>> let's mark the config option as broken until it can be fixed properly.
>>
>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
>>
>> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> I am not very proud of this, to say the least, but unfortunately,
> despite Toke's patience and
> his willingness to provide logs and all, I couldn't find the time to fix this.
> We had tested against NetworkManager wpa_s, but not against iwd.

> From the start, we thought distro wouldn't enable this and this is why
> we disabled iwlmei by default.

I'm always saying that a Kconfig option is not a "free pass" for
anything, some people will enable Kconfig options which they don't
understand and they must not break existing features.

> This driver is meant to be used by specific groups that need this and
> they'll know how to enable this driver even if it is marked as BROKEN.

This is just a temporary solution to workaround the regression. But we
cannot have broken code forever, so I hope this is properly fixed soon
so that the workaround can be removed.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: wifi: iwlwifi: Mark IWLMEI as broken

[Kalle Valo]

Toke Høiland-Jørgensen <toke@toke.dk> wrote:

> From: Toke Høiland-Jørgensen <toke@redhat.com>
> 
> The iwlmei driver breaks iwlwifi when returning from suspend. The interface
> ends up in the 'down' state after coming back from suspend. And iwd doesn't
> touch the interface state, but wpa_supplicant does, so the bug only happens on
> iwd.
> 
> The bug report[0] has been open for four months now, and no fix seems to be
> forthcoming. Since just disabling the iwlmei driver works as a workaround,
> let's mark the config option as broken until it can be fixed properly.
> 
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
> 
> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Acked-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

Patch applied to wireless.git, thanks.

8997f5c8a627 wifi: iwlwifi: Mark IWLMEI as broken

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220907134450.1183045-1-toke@toke.dk/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches