All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Edward Matijevic <motolav@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: ctxfi: Add SB046x PCI ID
Date: Sat, 21 May 2022 12:39:36 +0200	[thread overview]
Message-ID: <87o7zrnp93.wl-tiwai@suse.de> (raw)
In-Reply-To: <cae7d1a4-8bd9-7dfe-7427-db7e766f7272@gmail.com>

On Sat, 21 May 2022 06:45:15 +0200,
Edward Matijevic wrote:
> 
> Adds the PCI ID for X-Fi cards sold under the Platnum and XtremeMusic names
> 
> Before: snd_ctxfi 0000:05:05.0: chip 20K1 model Unknown (1102:0021) is found
> After: snd_ctxfi 0000:05:05.0: chip 20K1 model SB046x (1102:0021) is found
> 
> Signed-off-by: Edward Matijevic <motolav@gmail.com>

Does / did everything work as expected?  The model field influence on
a few device-specific setups such as the GPIO initial value, ADC and
DAC selections, not only the name string.


thanks,

Takashi

> ---
>  sound/pci/ctxfi/ctatc.c      | 2 ++
>  sound/pci/ctxfi/cthardware.h | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index 78f35e88aed6..fbdb8a3d5b8e 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -36,6 +36,7 @@
>  			    | ((IEC958_AES3_CON_FS_48000) << 24))
>  
>  static const struct snd_pci_quirk subsys_20k1_list[] = {
> +	SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x0021, "SB046x", CTSB046X),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x0022, "SB055x", CTSB055X),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x002f, "SB055x", CTSB055X),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x0029, "SB073x", CTSB073X),
> @@ -64,6 +65,7 @@ static const struct snd_pci_quirk subsys_20k2_list[] = {
>  
>  static const char *ct_subsys_name[NUM_CTCARDS] = {
>  	/* 20k1 models */
> +	[CTSB046X]	= "SB046x",
>  	[CTSB055X]	= "SB055x",
>  	[CTSB073X]	= "SB073x",
>  	[CTUAA]		= "UAA",
> diff --git a/sound/pci/ctxfi/cthardware.h b/sound/pci/ctxfi/cthardware.h
> index f406b626a28c..2875cec83b8f 100644
> --- a/sound/pci/ctxfi/cthardware.h
> +++ b/sound/pci/ctxfi/cthardware.h
> @@ -26,8 +26,9 @@ enum CHIPTYP {
>  
>  enum CTCARDS {
>  	/* 20k1 models */
> +	CTSB046X,
> +	CT20K1_MODEL_FIRST = CTSB046X,
>  	CTSB055X,
> -	CT20K1_MODEL_FIRST = CTSB055X,
>  	CTSB073X,
>  	CTUAA,
>  	CT20K1_UNKNOWN,
> -- 
> 2.36.1
> 

  reply	other threads:[~2022-05-21 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21  4:45 [PATCH] ALSA: ctxfi: Add SB046x PCI ID Edward Matijevic
2022-05-21 10:39 ` Takashi Iwai [this message]
2022-05-21 11:31   ` Edward Matijević
2022-05-23  7:47     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7zrnp93.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=motolav@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.