Re: [PATCH] ceph: remove dead code in ceph_sync_write

From: Luis Henriques <lhenriques@suse.de>
To: Jeff Layton <jlayton@kernel.org>
Cc: ceph-devel@vger.kernel.org, idryomov@gmail.com
Subject: Re: [PATCH] ceph: remove dead code in ceph_sync_write
Date: Wed, 11 Aug 2021 15:37:04 +0100	[thread overview]
Message-ID: <87o8a4qc8f.fsf@suse.de> (raw)
In-Reply-To: <20210811111927.8417-1-jlayton@kernel.org> (Jeff Layton's message of "Wed, 11 Aug 2021 07:19:27 -0400")

Jeff Layton <jlayton@kernel.org> writes:

> We've already checked these flags near the top of the function and
> bailed out if either were set.

The flags being checked at the top of the function are CEPH_OSDMAP_FULL
and CEPH_POOL_FLAG_FULL; here we're checking the *_NEARFULL flags.
Right?  (I had to look a few times to make sure my eyes were not lying.)

Cheers,
-- 
Luis

>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  fs/ceph/file.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index d1755ac1d964..f55ca2c4c7de 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -1834,12 +1834,8 @@ static ssize_t ceph_write_iter(struct kiocb *iocb, struct iov_iter *from)
>  		goto retry_snap;
>  	}
>  
> -	if (written >= 0) {
> -		if ((map_flags & CEPH_OSDMAP_NEARFULL) ||
> -		    (pool_flags & CEPH_POOL_FLAG_NEARFULL))
> -			iocb->ki_flags |= IOCB_DSYNC;
> +	if (written >= 0)
>  		written = generic_write_sync(iocb, written);
> -	}
>  
>  	goto out_unlocked;
>  out:
> -- 
>
> 2.31.1
>