All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Dryomov <idryomov@gmail.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Luis Henriques <lhenriques@suse.de>,
	Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] ceph: remove dead code in ceph_sync_write
Date: Wed, 11 Aug 2021 18:12:26 +0200	[thread overview]
Message-ID: <CAOi1vP8PK1G7qi43Y4_FeL1uyKafCyMidepzZ+Z8FCcgLaxTRw@mail.gmail.com> (raw)
In-Reply-To: <5b8b45707e019c16852b2aa8c9b8928fbdc60008.camel@kernel.org>

On Wed, Aug 11, 2021 at 4:44 PM Jeff Layton <jlayton@kernel.org> wrote:
>
> On Wed, 2021-08-11 at 15:37 +0100, Luis Henriques wrote:
> > Jeff Layton <jlayton@kernel.org> writes:
> >
> > > We've already checked these flags near the top of the function and
> > > bailed out if either were set.
> >
> > The flags being checked at the top of the function are CEPH_OSDMAP_FULL
> > and CEPH_POOL_FLAG_FULL; here we're checking the *_NEARFULL flags.
> > Right?  (I had to look a few times to make sure my eyes were not lying.)
> >
> > Cheers,
>
> Oof. You're totally right. Dropping this patch!

But it would have made https://github.com/ceph/ceph/pull/42749
unfounded! ;)

Thanks,

                Ilya

      reply	other threads:[~2021-08-11 16:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 11:19 [PATCH] ceph: remove dead code in ceph_sync_write Jeff Layton
2021-08-11 14:37 ` Luis Henriques
2021-08-11 14:44   ` Jeff Layton
2021-08-11 16:12     ` Ilya Dryomov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOi1vP8PK1G7qi43Y4_FeL1uyKafCyMidepzZ+Z8FCcgLaxTRw@mail.gmail.com \
    --to=idryomov@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=jlayton@kernel.org \
    --cc=lhenriques@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.