From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: Dan Williams <dan.j.williams@intel.com> Cc: Michael Ellerman <mpe@ellerman.id.au>, linux-nvdimm <linux-nvdimm@lists.01.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org> Subject: Re: [RFC PATCH 1/4] libnvdimm/namespace: Make namespace size validation arch dependent Date: Wed, 06 Nov 2019 16:14:22 +0530 [thread overview] Message-ID: <87o8xp5lo9.fsf@linux.ibm.com> (raw) In-Reply-To: <CAPcyv4h42_1deZDaaW1RqX0Ls+maiFO_1e=6xJuHTa3wdWvVvA@mail.gmail.com> Dan Williams <dan.j.williams@intel.com> writes: > On Wed, Oct 30, 2019 at 10:35 PM Aneesh Kumar K.V > <aneesh.kumar@linux.ibm.com> wrote: > [..] >> > True, for the pfn device and the device-dax mapping size, but I'm >> > suggesting adding another instance of alignment control at the raw >> > namespace level. That would need to be disconnected from the >> > device-dax page mapping granularity. >> > >> >> Can you explain what you mean by raw namespace level ? We don't have >> multiple values against which we need to check the alignment of >> namespace start and namespace size. >> >> If you can outline how and where you would like to enforce that check I >> can start working on it. >> > > What I mean is that the process of setting up a pfn namespace goes > something like this in shell script form: > > 1/ echo $size > /sys/bus/nd/devices/$namespace/size > 2/ echo $namespace > /sys/bus/nd/devices/$pfn/namespace > 3/ echo $pfn_align > /sys/bus/nd/devices/$pfn/align > > What I'm suggesting is add an optional 0th step that does: > > echo $raw_align > /sys/bus/nd/devices/$namespace/align > > Where the raw align needs to be needs to be max($pfn_align, > arch_mapping_granulariy). I started looking at this and was wondering about userspace being aware of the direct-map mapping size. We can figure that out by parsing kernel log [ 0.000000] Page orders: linear mapping = 24, virtual = 16, io = 16, vmemmap = 24 But I am not sure we want to do that. There is not set of raw_align value to select. What we need to make sure is the below. 1) While creating a namespace we need to make sure that namespace size is multiple of direct-map mapping size. If we ensure that size is aligned, we should also get the namespace start to be aligned? 2) While initialzing a namespace by scanning label area, we need to make sure every namespace in the region satisfy the above requirement. If not we should mark the region disabled. > > So on powerpc where PAGE_SIZE < arch_mapping_granulariy, the following: > > cat /sys/bus/nd/devices/$namespace/supported_aligns > > ...would show the same output as: > > cat /sys/bus/nd/devices/$pfn/align > > ...but with any alignment choice less than arch_mapping_granulariy removed. > I am not sure why we need to do that. For example: even if we have direct-map mapping size as PAGE_SIZE (64K), we still should allow an user mapping with hugepage size (16M)? -aneesh _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: Dan Williams <dan.j.williams@intel.com> Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-nvdimm <linux-nvdimm@lists.01.org> Subject: Re: [RFC PATCH 1/4] libnvdimm/namespace: Make namespace size validation arch dependent Date: Wed, 06 Nov 2019 16:14:22 +0530 [thread overview] Message-ID: <87o8xp5lo9.fsf@linux.ibm.com> (raw) In-Reply-To: <CAPcyv4h42_1deZDaaW1RqX0Ls+maiFO_1e=6xJuHTa3wdWvVvA@mail.gmail.com> Dan Williams <dan.j.williams@intel.com> writes: > On Wed, Oct 30, 2019 at 10:35 PM Aneesh Kumar K.V > <aneesh.kumar@linux.ibm.com> wrote: > [..] >> > True, for the pfn device and the device-dax mapping size, but I'm >> > suggesting adding another instance of alignment control at the raw >> > namespace level. That would need to be disconnected from the >> > device-dax page mapping granularity. >> > >> >> Can you explain what you mean by raw namespace level ? We don't have >> multiple values against which we need to check the alignment of >> namespace start and namespace size. >> >> If you can outline how and where you would like to enforce that check I >> can start working on it. >> > > What I mean is that the process of setting up a pfn namespace goes > something like this in shell script form: > > 1/ echo $size > /sys/bus/nd/devices/$namespace/size > 2/ echo $namespace > /sys/bus/nd/devices/$pfn/namespace > 3/ echo $pfn_align > /sys/bus/nd/devices/$pfn/align > > What I'm suggesting is add an optional 0th step that does: > > echo $raw_align > /sys/bus/nd/devices/$namespace/align > > Where the raw align needs to be needs to be max($pfn_align, > arch_mapping_granulariy). I started looking at this and was wondering about userspace being aware of the direct-map mapping size. We can figure that out by parsing kernel log [ 0.000000] Page orders: linear mapping = 24, virtual = 16, io = 16, vmemmap = 24 But I am not sure we want to do that. There is not set of raw_align value to select. What we need to make sure is the below. 1) While creating a namespace we need to make sure that namespace size is multiple of direct-map mapping size. If we ensure that size is aligned, we should also get the namespace start to be aligned? 2) While initialzing a namespace by scanning label area, we need to make sure every namespace in the region satisfy the above requirement. If not we should mark the region disabled. > > So on powerpc where PAGE_SIZE < arch_mapping_granulariy, the following: > > cat /sys/bus/nd/devices/$namespace/supported_aligns > > ...would show the same output as: > > cat /sys/bus/nd/devices/$pfn/align > > ...but with any alignment choice less than arch_mapping_granulariy removed. > I am not sure why we need to do that. For example: even if we have direct-map mapping size as PAGE_SIZE (64K), we still should allow an user mapping with hugepage size (16M)? -aneesh
next prev parent reply other threads:[~2019-11-06 10:44 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-28 9:48 [RFC PATCH 1/4] libnvdimm/namespace: Make namespace size validation arch dependent Aneesh Kumar K.V 2019-10-28 9:48 ` Aneesh Kumar K.V 2019-10-28 9:48 ` [RFC PATCH 2/4] libnvdimm/namespace: Disable the region if the namespace size is not aligned correctly Aneesh Kumar K.V 2019-10-28 9:48 ` Aneesh Kumar K.V 2019-10-30 9:12 ` kbuild test robot 2019-10-28 9:48 ` [RFC PATCH 3/4] libnvdimm/namespace: Use direct-mapping page size to validate namespace size Aneesh Kumar K.V 2019-10-28 9:48 ` Aneesh Kumar K.V 2019-10-28 9:48 ` [RFC PATCH 4/4] libnvdimm/namespace: Add debug check while initializing namespace resource size Aneesh Kumar K.V 2019-10-28 9:48 ` Aneesh Kumar K.V 2019-10-28 21:21 ` [RFC PATCH 1/4] libnvdimm/namespace: Make namespace size validation arch dependent Ira Weiny 2019-10-28 21:21 ` Ira Weiny 2019-10-29 4:34 ` Aneesh Kumar K.V 2019-10-29 4:34 ` Aneesh Kumar K.V 2019-10-28 23:08 ` Dan Williams 2019-10-28 23:08 ` Dan Williams 2019-10-29 4:34 ` Aneesh Kumar K.V 2019-10-29 4:34 ` Aneesh Kumar K.V 2019-10-29 5:30 ` Dan Williams 2019-10-29 5:30 ` Dan Williams 2019-10-31 5:35 ` Aneesh Kumar K.V 2019-10-31 5:35 ` Aneesh Kumar K.V 2019-10-31 6:30 ` Dan Williams 2019-10-31 6:30 ` Dan Williams 2019-10-31 8:37 ` Aneesh Kumar K.V 2019-10-31 8:37 ` Aneesh Kumar K.V 2019-10-31 15:53 ` Dan Williams 2019-10-31 15:53 ` Dan Williams 2019-11-06 10:44 ` Aneesh Kumar K.V [this message] 2019-11-06 10:44 ` Aneesh Kumar K.V 2019-11-16 12:15 ` Aneesh Kumar K.V 2019-11-16 12:15 ` Aneesh Kumar K.V 2019-11-16 18:50 ` Dan Williams 2019-11-16 18:50 ` Dan Williams 2019-11-18 9:51 ` Aneesh Kumar K.V 2019-11-18 9:51 ` Aneesh Kumar K.V 2019-11-19 17:58 ` Dan Williams 2019-11-19 17:58 ` Dan Williams 2019-11-20 3:19 ` Aneesh Kumar K.V 2019-11-20 3:19 ` Aneesh Kumar K.V 2019-11-20 3:46 ` Dan Williams 2019-11-20 3:46 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87o8xp5lo9.fsf@linux.ibm.com \ --to=aneesh.kumar@linux.ibm.com \ --cc=dan.j.williams@intel.com \ --cc=linux-nvdimm@lists.01.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.