From: Kalle Valo <kvalo@codeaurora.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Heiko Stuebner <heiko@sntech.de>,
Nishant Sarmukadam <nishants@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Xinming Hu <huxinming820@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes
Date: Fri, 08 Mar 2019 11:36:37 +0200 [thread overview]
Message-ID: <87o96l907u.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <15c00f9e-58df-e885-f3b0-2c57e9fadb11@arm.com> (Marc Zyngier's message of "Fri, 8 Mar 2019 09:02:11 +0000")
Marc Zyngier <marc.zyngier@arm.com> writes:
> On 08/03/2019 08:26, Kalle Valo wrote:
>> Marc Zyngier <marc.zyngier@arm.com> writes:
>>
>>> dt-bindings/marvell-8xxx: Allow wake-up interrupt to be placed in a
>>> separate node
>>> mwifiex: Fetch wake-up interrupt from 'wake-up' subnode when it exists
>>> mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling
>>> it too late
>>> arm64: dts: rockchip: gru: Move wifi wake-up interrupt into its own
>>> subnode
>>>
>>> .../bindings/net/wireless/marvell-8xxx.txt | 23 ++++++++++++++++++-
>>> .../dts/rockchip/rk3399-gru-chromebook.dtsi | 8 ++++---
>>> drivers/net/wireless/marvell/mwifiex/main.c | 13 +++++++++--
>>> 3 files changed, 38 insertions(+), 6 deletions(-)
>>
>> I didn't read the discussion in detail, but I understanding is that I
>> should drop this series and wait for a new version. Please correct me if
>> I misunderstood.
>
> I indeed plan to resend the series with a slightly different approach,
> removing support for the wake-up interrupt on mwifiex PCI devices
> altogether.
>
> Note that patch #3 is a fairly independent fix, which could be applied
> right now.
Ok, I'll queue that for 5.2 then:
https://patchwork.kernel.org/patch/10827971/
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Ganapathi Bhat <gbhat@marvell.com>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, Xinming Hu <huxinming820@gmail.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Amitkumar Karwar <amitkarwar@gmail.com>,
linux-rockchip@lists.infradead.org,
Nishant Sarmukadam <nishants@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes
Date: Fri, 08 Mar 2019 11:36:37 +0200 [thread overview]
Message-ID: <87o96l907u.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <15c00f9e-58df-e885-f3b0-2c57e9fadb11@arm.com> (Marc Zyngier's message of "Fri, 8 Mar 2019 09:02:11 +0000")
Marc Zyngier <marc.zyngier@arm.com> writes:
> On 08/03/2019 08:26, Kalle Valo wrote:
>> Marc Zyngier <marc.zyngier@arm.com> writes:
>>
>>> dt-bindings/marvell-8xxx: Allow wake-up interrupt to be placed in a
>>> separate node
>>> mwifiex: Fetch wake-up interrupt from 'wake-up' subnode when it exists
>>> mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling
>>> it too late
>>> arm64: dts: rockchip: gru: Move wifi wake-up interrupt into its own
>>> subnode
>>>
>>> .../bindings/net/wireless/marvell-8xxx.txt | 23 ++++++++++++++++++-
>>> .../dts/rockchip/rk3399-gru-chromebook.dtsi | 8 ++++---
>>> drivers/net/wireless/marvell/mwifiex/main.c | 13 +++++++++--
>>> 3 files changed, 38 insertions(+), 6 deletions(-)
>>
>> I didn't read the discussion in detail, but I understanding is that I
>> should drop this series and wait for a new version. Please correct me if
>> I misunderstood.
>
> I indeed plan to resend the series with a slightly different approach,
> removing support for the wake-up interrupt on mwifiex PCI devices
> altogether.
>
> Note that patch #3 is a fairly independent fix, which could be applied
> right now.
Ok, I'll queue that for 5.2 then:
https://patchwork.kernel.org/patch/10827971/
--
Kalle Valo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-08 9:36 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 14:04 [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes Marc Zyngier
2019-02-24 14:04 ` Marc Zyngier
2019-02-24 14:04 ` [PATCH 1/4] dt-bindings/marvell-8xxx: Allow wake-up interrupt to be placed in a separate node Marc Zyngier
2019-02-24 14:04 ` Marc Zyngier
2019-02-24 14:04 ` [PATCH 2/4] mwifiex: Fetch wake-up interrupt from 'wake-up' subnode when it exists Marc Zyngier
2019-02-24 14:04 ` Marc Zyngier
2019-02-24 14:04 ` [PATCH 3/4] mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late Marc Zyngier
2019-02-24 14:04 ` Marc Zyngier
2019-02-26 23:31 ` Brian Norris
2019-02-26 23:31 ` Brian Norris
2019-02-26 23:34 ` Brian Norris
2019-02-26 23:34 ` Brian Norris
2019-04-04 10:22 ` Kalle Valo
2019-04-04 10:22 ` Kalle Valo
2019-04-04 10:22 ` Kalle Valo
2019-04-04 10:22 ` Kalle Valo
2019-02-24 14:04 ` [PATCH 4/4] arm64: dts: rockchip: gru: Move wifi wake-up interrupt into its own subnode Marc Zyngier
2019-02-24 14:04 ` Marc Zyngier
2019-02-25 12:45 ` [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes Ard Biesheuvel
2019-02-25 12:45 ` Ard Biesheuvel
2019-02-25 14:52 ` Marc Zyngier
2019-02-25 14:52 ` Marc Zyngier
2019-02-26 16:21 ` Ard Biesheuvel
2019-02-26 16:21 ` Ard Biesheuvel
2019-02-26 16:21 ` Ard Biesheuvel
2019-02-26 17:14 ` Marc Zyngier
2019-02-26 17:14 ` Marc Zyngier
2019-02-26 23:44 ` Brian Norris
2019-02-26 23:44 ` Brian Norris
2019-02-26 23:44 ` Brian Norris
2019-02-27 9:27 ` Marc Zyngier
2019-02-27 9:27 ` Marc Zyngier
2019-02-27 9:27 ` Marc Zyngier
2019-02-26 23:28 ` Brian Norris
2019-02-26 23:28 ` Brian Norris
2019-02-27 10:02 ` Marc Zyngier
2019-02-27 10:02 ` Marc Zyngier
2019-02-27 10:16 ` Ard Biesheuvel
2019-02-27 10:16 ` Ard Biesheuvel
2019-02-27 10:16 ` Ard Biesheuvel
2019-02-27 10:16 ` Ard Biesheuvel
2019-02-27 20:57 ` Brian Norris
2019-02-27 20:57 ` Brian Norris
2019-02-27 20:57 ` Brian Norris
2019-02-27 23:03 ` Rafael J. Wysocki
2019-02-27 23:03 ` Rafael J. Wysocki
2019-02-27 23:03 ` Rafael J. Wysocki
2019-02-28 2:29 ` Brian Norris
2019-02-28 2:29 ` Brian Norris
2019-02-28 2:29 ` Brian Norris
2019-02-28 11:03 ` Rafael J. Wysocki
2019-02-28 11:03 ` Rafael J. Wysocki
2019-02-28 11:03 ` Rafael J. Wysocki
2019-02-27 20:51 ` Brian Norris
2019-02-27 20:51 ` Brian Norris
2019-03-08 8:26 ` Kalle Valo
2019-03-08 8:26 ` Kalle Valo
2019-03-08 8:26 ` Kalle Valo
2019-03-08 9:02 ` Marc Zyngier
2019-03-08 9:02 ` Marc Zyngier
2019-03-08 9:36 ` Kalle Valo [this message]
2019-03-08 9:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o96l907u.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=gbhat@marvell.com \
--cc=heiko@sntech.de \
--cc=huxinming820@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.