All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	eben@raspberrypi.org
Subject: Re: [PATCH 0/7] drm/vc4: Allow for more boot-time configuration
Date: Mon, 04 Mar 2019 12:06:01 -0800	[thread overview]
Message-ID: <87o96q76c6.fsf@anholt.net> (raw)
In-Reply-To: <cover.39761cc6c9d070568123e328cd216367c4c660b4.1551711042.git-series.maxime.ripard@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 1570 bytes --]

Maxime Ripard <maxime.ripard@bootlin.com> writes:

> Hi,
>
> The proprietary stack for the RaspberryPi allows for a number of video
> parameters widely used by their users, but yet don't have any equivalents
> in the mainline kernel.
>
> Those options are detailed here:
> https://www.raspberrypi.org/documentation/configuration/config-txt/video.md
>
> While not all of them are desirable to have in the mainline kernel, some of
> them still have value, such as properties to initialise the overscan or
> rotation parameters, or the one to deal with broken displays.
>
> This series is an attempt to support those, and is based on a rewrite of
> the command line parser I did a couple of years ago that never reached
> upstream (due to a lack of time on my side). While this parser was
> initially made to deal with named modes (in order to support TV modes), it
> also allowed to extend it more easily, which is why it's resurrected.

FWIW for other reviewers, the overscan and rotation are the really
important parts of this series.  Since Raspberry Pi ends up connected to
TVs so frequently, there are many users of the overscan workaround.
Rotation is important for supporting the official DSI touchscreen panel,
which is unfortunately mounted upside down in most mounts you'll find.

> Since a change of the command line parser can pretty easily get things
> wrong and introduce regressions, I also worked with a number of unit tests
> that you can find here: http://code.bulix.org/tpo7dg-607264?raw

Would kselftests be an appropriate way to include these, maybe?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>Maxime Ripard
	<maxime.ripard@bootlin.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	eben@raspberrypi.org
Subject: Re: [PATCH 0/7] drm/vc4: Allow for more boot-time configuration
Date: Mon, 04 Mar 2019 12:06:01 -0800	[thread overview]
Message-ID: <87o96q76c6.fsf@anholt.net> (raw)
In-Reply-To: <cover.39761cc6c9d070568123e328cd216367c4c660b4.1551711042.git-series.maxime.ripard@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 1570 bytes --]

Maxime Ripard <maxime.ripard@bootlin.com> writes:

> Hi,
>
> The proprietary stack for the RaspberryPi allows for a number of video
> parameters widely used by their users, but yet don't have any equivalents
> in the mainline kernel.
>
> Those options are detailed here:
> https://www.raspberrypi.org/documentation/configuration/config-txt/video.md
>
> While not all of them are desirable to have in the mainline kernel, some of
> them still have value, such as properties to initialise the overscan or
> rotation parameters, or the one to deal with broken displays.
>
> This series is an attempt to support those, and is based on a rewrite of
> the command line parser I did a couple of years ago that never reached
> upstream (due to a lack of time on my side). While this parser was
> initially made to deal with named modes (in order to support TV modes), it
> also allowed to extend it more easily, which is why it's resurrected.

FWIW for other reviewers, the overscan and rotation are the really
important parts of this series.  Since Raspberry Pi ends up connected to
TVs so frequently, there are many users of the overscan workaround.
Rotation is important for supporting the official DSI touchscreen panel,
which is unfortunately mounted upside down in most mounts you'll find.

> Since a change of the command line parser can pretty easily get things
> wrong and introduce regressions, I also worked with a number of unit tests
> that you can find here: http://code.bulix.org/tpo7dg-607264?raw

Would kselftests be an appropriate way to include these, maybe?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-03-04 20:06 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 14:52 [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Maxime Ripard
2019-03-04 14:52 ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 1/7] drm/vc4: hdmi: Check that the monitor supports HDMI audio Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 15:10   ` Paul Kocialkowski
2019-03-04 15:10     ` Paul Kocialkowski
2019-03-04 15:54   ` Stefan Wahren
2019-03-04 15:54     ` Stefan Wahren
2019-03-04 18:28     ` Eric Anholt
2019-03-04 18:28       ` Eric Anholt
2019-03-04 20:06       ` Stefan Wahren
2019-03-04 20:06         ` Stefan Wahren
2019-03-04 21:09         ` Eric Anholt
2019-03-04 21:09           ` Eric Anholt
2019-03-04 14:52 ` [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 15:47   ` Jani Nikula
2019-03-04 15:47     ` Jani Nikula
2019-03-04 15:51     ` Adam Jackson
2019-03-04 15:51       ` Adam Jackson
2019-03-05  8:08     ` Maxime Ripard
2019-03-05  8:08       ` Maxime Ripard
2019-03-05 10:33       ` Jani Nikula
2019-03-05 10:33         ` Jani Nikula
2019-03-05 15:08       ` Adam Jackson
2019-03-05 15:08         ` Adam Jackson
2019-03-04 15:59   ` Ville Syrjälä
2019-03-04 15:59     ` Ville Syrjälä
2019-03-04 19:53   ` Eric Anholt
2019-03-04 19:53     ` Eric Anholt
2019-03-04 20:05     ` Alex Deucher
2019-03-04 20:05       ` Alex Deucher
2019-03-05  9:12       ` Maxime Ripard
2019-03-05  9:12         ` Maxime Ripard
2019-03-05 15:24         ` Ville Syrjälä
2019-03-05 15:24           ` Ville Syrjälä
2019-03-05 19:15           ` Ville Syrjälä
2019-03-05 19:15             ` Ville Syrjälä
2019-03-05 19:21             ` Alex Deucher
2019-03-05 19:36               ` Ville Syrjälä
2019-03-05 19:36                 ` Ville Syrjälä
2019-03-13 10:44                 ` Takashi Iwai
2019-03-13 10:44                   ` Takashi Iwai
2019-03-13 14:03                   ` Maxime Ripard
2019-03-13 14:03                     ` Maxime Ripard
2019-03-05 18:11         ` Eric Anholt
2019-03-05 18:11           ` Eric Anholt
2019-03-11 13:07           ` Daniel Vetter
2019-03-11 13:07             ` Daniel Vetter
2019-03-05 21:47         ` Eric Anholt
2019-03-05 21:47           ` Eric Anholt
2019-03-06  8:52           ` Maxime Ripard
2019-03-06  8:52             ` Maxime Ripard
2019-03-06 13:22           ` Maxime Ripard
2019-03-06 13:22             ` Maxime Ripard
2019-03-06 17:51             ` Eric Anholt
2019-03-06 17:51               ` Eric Anholt
2019-03-04 14:52 ` [PATCH 3/7] drm/edid: Allow to ignore the HDMI monitor mode Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 15:14   ` Paul Kocialkowski
2019-03-04 15:14     ` Paul Kocialkowski
2019-03-04 15:48   ` Jani Nikula
2019-03-04 15:48     ` Jani Nikula
2019-03-04 20:02   ` Eric Anholt
2019-03-04 20:02     ` Eric Anholt
2019-03-05  9:24     ` Maxime Ripard
2019-03-05  9:24       ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 4/7] drm/modes: Rewrite the command line parser Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 5/7] drm/modes: Support modes names on the command line Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 6/7] drm/modes: Allow to specify rotation and reflection on the commandline Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 7/7] drm/modes: Parse overscan properties Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 15:21 ` [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Peter Stuge
2019-03-04 15:21   ` Peter Stuge
2019-03-04 15:56   ` Maxime Ripard
2019-03-04 15:56     ` Maxime Ripard
2019-03-04 15:44 ` Stefan Wahren
2019-03-04 15:44   ` Stefan Wahren
2019-03-04 20:06 ` Eric Anholt [this message]
2019-03-04 20:06   ` Eric Anholt
2019-03-05  9:14   ` Maxime Ripard
2019-03-05  9:14     ` Maxime Ripard
2019-03-11 13:00     ` Daniel Vetter
2019-03-11 13:00       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o96q76c6.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eben@raspberrypi.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=seanpaul@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.