All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/8] lib: Skip unused fork helpers
Date: Wed, 30 Jan 2019 13:07:32 +0200	[thread overview]
Message-ID: <87o97ye74b.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190130095500.23596-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Skip trying to stop unused fork helpers to avoid the various asserts
> that they were running and didn't die early.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109468
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_core.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 49fbf70de..0794e11a0 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1678,6 +1678,9 @@ void igt_stop_helper(struct igt_helper_process *proc)
>  {
>  	int status;
>  
> +	if (!proc->running) /* never even started */
> +		return;
> +

The comment above mentions that it is error to call this on a helper
process which hasn't been spawned yet. So as we relax the requirements,
remove that comment.

With that,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

>  	/* failure here means the pid is already dead and so waiting is safe */
>  	kill(proc->pid, proc->use_SIGKILL ? SIGKILL : SIGTERM);
>  
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/8] lib: Skip unused fork helpers
Date: Wed, 30 Jan 2019 13:07:32 +0200	[thread overview]
Message-ID: <87o97ye74b.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190130095500.23596-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Skip trying to stop unused fork helpers to avoid the various asserts
> that they were running and didn't die early.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109468
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_core.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 49fbf70de..0794e11a0 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1678,6 +1678,9 @@ void igt_stop_helper(struct igt_helper_process *proc)
>  {
>  	int status;
>  
> +	if (!proc->running) /* never even started */
> +		return;
> +

The comment above mentions that it is error to call this on a helper
process which hasn't been spawned yet. So as we relax the requirements,
remove that comment.

With that,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

>  	/* failure here means the pid is already dead and so waiting is safe */
>  	kill(proc->pid, proc->use_SIGKILL ? SIGKILL : SIGTERM);
>  
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-01-30 11:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  9:54 [PATCH i-g-t 1/8] lib: Skip unused fork helpers Chris Wilson
2019-01-30  9:54 ` [igt-dev] " Chris Wilson
2019-01-30  9:54 ` [PATCH i-g-t 2/8] i915/gem_eio: Check for allow-hang prior to issuing a reset Chris Wilson
2019-01-30  9:54   ` [igt-dev] " Chris Wilson
2019-01-30 11:08   ` Mika Kuoppala
2019-01-30 11:08     ` [igt-dev] [Intel-gfx] " Mika Kuoppala
2019-01-30  9:54 ` [PATCH i-g-t 3/8] i915/gem_exec_latency: Normalize results into ns Chris Wilson
2019-01-30  9:54   ` [Intel-gfx] " Chris Wilson
2019-01-30  9:54 ` [PATCH i-g-t 4/8] i915/gem_exec_latency: Eliminate the wakeup penalty Chris Wilson
2019-01-30  9:54   ` [igt-dev] " Chris Wilson
2019-01-30  9:54 ` [PATCH i-g-t 5/8] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block Chris Wilson
2019-01-30  9:54   ` [Intel-gfx] " Chris Wilson
2019-01-30  9:54 ` [PATCH i-g-t 6/8] i915/gem_exec_nop: poll-sequential requires ordering between rings Chris Wilson
2019-01-30  9:54   ` [igt-dev] " Chris Wilson
2019-01-30  9:54 ` [PATCH i-g-t 7/8] i915/gem_sync: Make switch-default asymmetric Chris Wilson
2019-01-30  9:54   ` [igt-dev] " Chris Wilson
2019-01-30  9:55 ` [PATCH i-g-t 8/8] intel-ci: Drop gem_exec_nop from BAT Chris Wilson
2019-01-30  9:55   ` [igt-dev] " Chris Wilson
2019-01-30 11:12   ` Mika Kuoppala
2019-01-30 11:12     ` [igt-dev] [Intel-gfx] " Mika Kuoppala
2019-01-30 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] lib: Skip unused fork helpers Patchwork
2019-01-30 11:07 ` Mika Kuoppala [this message]
2019-01-30 11:07   ` [igt-dev] [Intel-gfx] [PATCH i-g-t 1/8] " Mika Kuoppala
2019-01-30 12:47 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/8] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o97ye74b.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.