[LTP] [PATCH v1] Test statx syscall for SYNC_FLAGS

[LTP] [PATCH v1] Test statx syscall for SYNC_FLAGS

[kewal]

* statx06.c :-

 Testcase 1: AT_STATX_DONT_SYNC
  With AT_STATX_DONT_SYNC server changes should not get sync with client.

 Testcase 2: AT_STATX_FORCE_SYNC
  With AT_STATX_FORCE_SYNC server changes should get sync with client.

Signed-off-by: Kewal Ukunde <kewal@zilogic.com>
Signed-off-by: Vaishnavi.d <vaishnavi.d@zilogic.com>
Signed-off-by: Tarun.T.U <tarun@zilogic.com>
---
 runtest/syscalls                           |   1 +
 testcases/kernel/syscalls/statx/.gitignore |   1 +
 testcases/kernel/syscalls/statx/statx06.c  | 183 +++++++++++++++++++++++++++++
 3 files changed, 185 insertions(+)
 create mode 100644 testcases/kernel/syscalls/statx/statx06.c

diff --git a/runtest/syscalls b/runtest/syscalls
index 0d0be7713..71b83b25c 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -1504,3 +1504,4 @@ statx02 statx02
 statx03 statx03
 statx04 statx04
 statx05 statx05
+statx06 statx06
diff --git a/testcases/kernel/syscalls/statx/.gitignore b/testcases/kernel/syscalls/statx/.gitignore
index 209fc3a33..c1ceddabf 100644
--- a/testcases/kernel/syscalls/statx/.gitignore
+++ b/testcases/kernel/syscalls/statx/.gitignore
@@ -3,3 +3,4 @@
 /statx03
 /statx04
 /statx05
+/statx06
diff --git a/testcases/kernel/syscalls/statx/statx06.c b/testcases/kernel/syscalls/statx/statx06.c
new file mode 100644
index 000000000..8b66bf832
--- /dev/null
+++ b/testcases/kernel/syscalls/statx/statx06.c
@@ -0,0 +1,183 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ *  Copyright (c) Zilogic Systems Pvt. Ltd., 2018
+ *  Email : code@zilogic.com
+ */
+
+/*
+ * Test statx
+ *
+ * This code tests the following flags:
+ * 1) AT_STATX_FORCE_SYNC
+ * 2) AT_STATX_DONT_SYNC
+ *
+ * By exportfs cmd creating NFS setup.
+ *
+ * A test file is created in server folder and statx is being
+ * done in client folder.
+ *
+ * TESTCASE 1:
+ * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
+ * Then, by using AT_STATX_FORCE_SYNC getting new updated vaue
+ * from server file changes.
+ *
+ * TESTCASE 2:
+ * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
+ * AT_STATX_FORCE_SYNC is called to create cache data of the file. 
+ * Then, by using DONT_SYNC_FILE getting old cached data in client folder,
+ * but mode has been chaged in server file.
+ *
+ * Minimum kernel version required is 4.11.
+ */
+
+#include <netdb.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include "tst_test.h"
+#include "lapi/stat.h"
+
+#define MODE(X) (X & (~S_IFMT))
+#define BUFF_SIZE 512
+#define DEFAULT_MODE 0644
+#define CURRENT_MODE 0777
+
+#define CLIENT_PATH "client"
+#define SERVER_PATH "server"
+#define FORCE_SYNC_FILE  "force_sync_file"
+#define DONT_SYNC_FILE "dont_sync_file"
+
+static char cwd[BUFF_SIZE];
+static char cmd[BUFF_SIZE];
+
+static int get_mode(char *file_name, int flag_type, char *flag_name)
+{
+	char client_path[BUFF_SIZE];
+	struct statx buff;
+
+	sprintf(client_path, "%s/%s/%s", cwd, CLIENT_PATH, file_name);
+
+	TEST(statx(AT_FDCWD, client_path, flag_type, STATX_ALL, &buff));
+
+	if (TST_RET == -1)
+		tst_brk(TFAIL | TST_ERR,
+				"statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
+				file_name, flag_name);
+	else
+		tst_res(TINFO, "statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
+				file_name, flag_name);
+
+	return buff.stx_mode;
+}
+
+static void test_for_dont_sync(void)
+{
+	unsigned int cur_mode;
+	char server_path[BUFF_SIZE];
+
+	sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, DONT_SYNC_FILE);
+
+	get_mode(DONT_SYNC_FILE, AT_STATX_FORCE_SYNC,
+			"AT_STATX_FORCE_SYNC");
+
+	SAFE_CHMOD(server_path, CURRENT_MODE);
+	cur_mode = get_mode(DONT_SYNC_FILE, AT_STATX_DONT_SYNC,
+			"AT_STATX_DONT_SYNC");
+
+	if (DEFAULT_MODE == MODE(cur_mode))
+		tst_res(TPASS,
+				"statx() with AT_STATX_DONT_SYNC for mode %o %o",
+				DEFAULT_MODE, (cur_mode & ~S_IFMT));
+	else
+		tst_res(TFAIL,
+				"statx() with AT_STATX_DONT_SYNC for mode %o %o",
+				DEFAULT_MODE, (cur_mode & ~S_IFMT));
+}
+
+static void test_for_force_sync(void)
+{
+	unsigned int cur_mode;
+	char server_path[BUFF_SIZE];
+
+	sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, FORCE_SYNC_FILE);
+
+	SAFE_CHMOD(server_path, CURRENT_MODE);
+	cur_mode = get_mode(FORCE_SYNC_FILE, AT_STATX_FORCE_SYNC,
+			"AT_STATX_FORCE_SYNC");
+
+	if (CURRENT_MODE == MODE(cur_mode))
+		tst_res(TPASS,
+				"statx() with AT_STATX_FORCE_SYNC for mode %o %o",
+				CURRENT_MODE, (cur_mode & ~S_IFMT));
+	else
+		tst_res(TFAIL,
+				"statx() with AT_STATX_FORCE_SYNC for mode %o %o",
+				CURRENT_MODE, (cur_mode & ~S_IFMT));
+}
+
+struct test_cases {
+	void (*func)(void);
+} tcases[] = {
+	{test_for_dont_sync},
+	{test_for_force_sync}
+};
+
+static void test_statx(unsigned int nr)
+{
+	struct test_cases *tc = &tcases[nr];
+
+	tc->func();
+}
+
+static void setup(void)
+{
+	char force_sync_file[BUFF_SIZE];
+	char dont_sync_file[BUFF_SIZE];
+	char server_path[BUFF_SIZE];
+	char client_path[BUFF_SIZE];
+	char mount_data[BUFF_SIZE];
+	char *ip = "127.0.0.1";
+
+	TESTPTR(getcwd(cwd, BUFF_SIZE));
+	if (TST_RET_PTR == NULL)
+		tst_brk(TBROK | TST_ERR, "Failed to get PWD");
+
+	sprintf(force_sync_file, "%s/%s", SERVER_PATH, FORCE_SYNC_FILE);
+	sprintf(dont_sync_file, "%s/%s", SERVER_PATH, DONT_SYNC_FILE);
+
+	SAFE_MKDIR(SERVER_PATH, DEFAULT_MODE);
+	SAFE_MKDIR(CLIENT_PATH, DEFAULT_MODE);
+	SAFE_CREAT(force_sync_file, DEFAULT_MODE);
+	SAFE_CREAT(dont_sync_file, DEFAULT_MODE);
+
+	sprintf(server_path, ":%s/%s", cwd, SERVER_PATH);
+	sprintf(client_path, "%s/%s", cwd, CLIENT_PATH);
+	sprintf(mount_data, "addr=%s", ip);
+
+	sprintf(cmd,
+			"exportfs -i -o no_root_squash,rw,sync,no_subtree_check *%s",
+			server_path);
+
+	if (WEXITSTATUS(tst_system(cmd)) == 127)
+		tst_brk(TBROK | TST_ERR, "%s not found", cmd);
+
+	SAFE_MOUNT(server_path, client_path, "nfs", 0, mount_data);
+}
+
+static void cleanup(void)
+{
+	if (WEXITSTATUS(tst_system("exportfs -ua")) == 127)
+		tst_brk(TBROK | TST_ERR, "%s", cmd);
+
+	SAFE_UMOUNT(CLIENT_PATH);
+}
+
+static struct tst_test test = {
+	.tcnt = ARRAY_SIZE(tcases),
+	.test = test_statx,
+	.setup = setup,
+	.cleanup = cleanup,
+	.min_kver = "4.11",
+	.needs_tmpdir = 1,
+	.dev_fs_type = "nfs",
+	.needs_root = 1,
+};
-- 
2.11.0

[LTP] [PATCH v1] Test statx syscall for SYNC_FLAGS

[Richard Palethorpe]

Hello,

kewal <kewal@zilogic.com> writes:

> * statx06.c :-
>
>  Testcase 1: AT_STATX_DONT_SYNC
>   With AT_STATX_DONT_SYNC server changes should not get sync with client.
>
>  Testcase 2: AT_STATX_FORCE_SYNC
>   With AT_STATX_FORCE_SYNC server changes should get sync with client.
>
> Signed-off-by: Kewal Ukunde <kewal@zilogic.com>
> Signed-off-by: Vaishnavi.d <vaishnavi.d@zilogic.com>
> Signed-off-by: Tarun.T.U <tarun@zilogic.com>
> ---
>  runtest/syscalls                           |   1 +
>  testcases/kernel/syscalls/statx/.gitignore |   1 +
>  testcases/kernel/syscalls/statx/statx06.c  | 183 +++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 testcases/kernel/syscalls/statx/statx06.c
>
> diff --git a/runtest/syscalls b/runtest/syscalls
> index 0d0be7713..71b83b25c 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -1504,3 +1504,4 @@ statx02 statx02
>  statx03 statx03
>  statx04 statx04
>  statx05 statx05
> +statx06 statx06
> diff --git a/testcases/kernel/syscalls/statx/.gitignore b/testcases/kernel/syscalls/statx/.gitignore
> index 209fc3a33..c1ceddabf 100644
> --- a/testcases/kernel/syscalls/statx/.gitignore
> +++ b/testcases/kernel/syscalls/statx/.gitignore
> @@ -3,3 +3,4 @@
>  /statx03
>  /statx04
>  /statx05
> +/statx06
> diff --git a/testcases/kernel/syscalls/statx/statx06.c b/testcases/kernel/syscalls/statx/statx06.c
> new file mode 100644
> index 000000000..8b66bf832
> --- /dev/null
> +++ b/testcases/kernel/syscalls/statx/statx06.c
> @@ -0,0 +1,183 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + *  Copyright (c) Zilogic Systems Pvt. Ltd., 2018
> + *  Email : code@zilogic.com
> + */
> +
> +/*
> + * Test statx
> + *
> + * This code tests the following flags:
> + * 1) AT_STATX_FORCE_SYNC
> + * 2) AT_STATX_DONT_SYNC
> + *
> + * By exportfs cmd creating NFS setup.
> + *
> + * A test file is created in server folder and statx is being
> + * done in client folder.
> + *
> + * TESTCASE 1:
> + * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
> + * Then, by using AT_STATX_FORCE_SYNC getting new updated vaue
> + * from server file changes.
> + *
> + * TESTCASE 2:
> + * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
> + * AT_STATX_FORCE_SYNC is called to create cache data of the file.
> + * Then, by using DONT_SYNC_FILE getting old cached data in client folder,
> + * but mode has been chaged in server file.
> + *
> + * Minimum kernel version required is 4.11.
> + */
> +
> +#include <netdb.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include "tst_test.h"
> +#include "lapi/stat.h"
> +
> +#define MODE(X) (X & (~S_IFMT))
> +#define BUFF_SIZE 512
> +#define DEFAULT_MODE 0644
> +#define CURRENT_MODE 0777
> +
> +#define CLIENT_PATH "client"
> +#define SERVER_PATH "server"
> +#define FORCE_SYNC_FILE  "force_sync_file"
> +#define DONT_SYNC_FILE "dont_sync_file"
> +
> +static char cwd[BUFF_SIZE];
> +static char cmd[BUFF_SIZE];
> +
> +static int get_mode(char *file_name, int flag_type, char *flag_name)
> +{
> +	char client_path[BUFF_SIZE];
> +	struct statx buff;
> +
> +	sprintf(client_path, "%s/%s/%s", cwd, CLIENT_PATH, file_name);
> +
> +	TEST(statx(AT_FDCWD, client_path, flag_type, STATX_ALL, &buff));
> +
> +	if (TST_RET == -1)
> +		tst_brk(TFAIL | TST_ERR,
> +				"statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
> +				file_name, flag_name);
> +	else
> +		tst_res(TINFO, "statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
> +				file_name, flag_name);

Seems like something strange is happening with the whitespace.

> +
> +	return buff.stx_mode;
> +}
> +
> +static void test_for_dont_sync(void)
> +{
> +	unsigned int cur_mode;
> +	char server_path[BUFF_SIZE];
> +
> +	sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, DONT_SYNC_FILE);
> +
> +	get_mode(DONT_SYNC_FILE, AT_STATX_FORCE_SYNC,
> +			"AT_STATX_FORCE_SYNC");
> +
> +	SAFE_CHMOD(server_path, CURRENT_MODE);
> +	cur_mode = get_mode(DONT_SYNC_FILE, AT_STATX_DONT_SYNC,
> +			"AT_STATX_DONT_SYNC");
> +
> +	if (DEFAULT_MODE == MODE(cur_mode))

Try running check_patch from the kernel on this:

WARNING: Comparisons should place the constant on the right side of the test
#86: FILE: statx06.c:86:
+       if (DEFAULT_MODE == MODE(cur_mode))

> +		tst_res(TPASS,
> +				"statx() with AT_STATX_DONT_SYNC for mode %o %o",
> +				DEFAULT_MODE, (cur_mode & ~S_IFMT));
> +	else
> +		tst_res(TFAIL,
> +				"statx() with AT_STATX_DONT_SYNC for mode %o %o",
> +				DEFAULT_MODE, (cur_mode & ~S_IFMT));
> +}
> +
> +static void test_for_force_sync(void)
> +{
> +	unsigned int cur_mode;
> +	char server_path[BUFF_SIZE];
> +
> +	sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, FORCE_SYNC_FILE);
> +
> +	SAFE_CHMOD(server_path, CURRENT_MODE);
> +	cur_mode = get_mode(FORCE_SYNC_FILE, AT_STATX_FORCE_SYNC,
> +			"AT_STATX_FORCE_SYNC");
> +
> +	if (CURRENT_MODE == MODE(cur_mode))
> +		tst_res(TPASS,
> +				"statx() with AT_STATX_FORCE_SYNC for mode %o %o",
> +				CURRENT_MODE, (cur_mode & ~S_IFMT));
> +	else
> +		tst_res(TFAIL,
> +				"statx() with AT_STATX_FORCE_SYNC for mode %o %o",
> +				CURRENT_MODE, (cur_mode & ~S_IFMT));
> +}
> +
> +struct test_cases {
> +	void (*func)(void);
> +} tcases[] = {
> +	{test_for_dont_sync},
> +	{test_for_force_sync}
> +};
> +
> +static void test_statx(unsigned int nr)
> +{
> +	struct test_cases *tc = &tcases[nr];
> +
> +	tc->func();
> +}
> +
> +static void setup(void)
> +{
> +	char force_sync_file[BUFF_SIZE];
> +	char dont_sync_file[BUFF_SIZE];
> +	char server_path[BUFF_SIZE];
> +	char client_path[BUFF_SIZE];
> +	char mount_data[BUFF_SIZE];
> +	char *ip = "127.0.0.1";
> +
> +	TESTPTR(getcwd(cwd, BUFF_SIZE));
> +	if (TST_RET_PTR == NULL)
> +		tst_brk(TBROK | TST_ERR, "Failed to get PWD");
> +
> +	sprintf(force_sync_file, "%s/%s", SERVER_PATH, FORCE_SYNC_FILE);
> +	sprintf(dont_sync_file, "%s/%s", SERVER_PATH, DONT_SYNC_FILE);
> +
> +	SAFE_MKDIR(SERVER_PATH, DEFAULT_MODE);
> +	SAFE_MKDIR(CLIENT_PATH, DEFAULT_MODE);
> +	SAFE_CREAT(force_sync_file, DEFAULT_MODE);
> +	SAFE_CREAT(dont_sync_file, DEFAULT_MODE);
> +
> +	sprintf(server_path, ":%s/%s", cwd, SERVER_PATH);
> +	sprintf(client_path, "%s/%s", cwd, CLIENT_PATH);
> +	sprintf(mount_data, "addr=%s", ip);

I get a lot of warnings when compiling with gcc8 like

statx06.c:152:27: warning: ‘/’ directive writing 1 byte into a region of size between 0 and 511 [-Wformat-overflow=]
  sprintf(server_path, ":%s/%s", cwd, SERVER_PATH);


> +
> +	sprintf(cmd,
> +			"exportfs -i -o no_root_squash,rw,sync,no_subtree_check *%s",
> +			server_path);

Must we use an absolute path here and when mounting?

> +
> +	if (WEXITSTATUS(tst_system(cmd)) == 127)
> +		tst_brk(TBROK | TST_ERR, "%s not found", cmd);

This should probably be just TCONF as we shouldn't expect all systems to
support running an NFS server. Also you should check for other errors.

> +
> +	SAFE_MOUNT(server_path, client_path, "nfs", 0, mount_data);
> +}
> +
> +static void cleanup(void)
> +{
> +	if (WEXITSTATUS(tst_system("exportfs -ua")) == 127)
> +		tst_brk(TBROK | TST_ERR, "%s", cmd);
> +
> +	SAFE_UMOUNT(CLIENT_PATH);
> +}
> +
> +static struct tst_test test = {
> +	.tcnt = ARRAY_SIZE(tcases),
> +	.test = test_statx,
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.min_kver = "4.11",
> +	.needs_tmpdir = 1,
> +	.dev_fs_type = "nfs",
> +	.needs_root = 1,
> +};
> --
> 2.11.0


--
Thank you,
Richard.

[LTP] [PATCH v1] Test statx syscall for SYNC_FLAGS

[Only]

Hi Richard,


On Monday 10 September 2018 07:30 PM, Richard Palethorpe wrote:
> Hello,
>
> kewal <kewal@zilogic.com> writes:
>
>> * statx06.c :-
>>
>>   Testcase 1: AT_STATX_DONT_SYNC
>>    With AT_STATX_DONT_SYNC server changes should not get sync with 
>> client.
>>
>>   Testcase 2: AT_STATX_FORCE_SYNC
>>    With AT_STATX_FORCE_SYNC server changes should get sync with client.
>>
>> Signed-off-by: Kewal Ukunde <kewal@zilogic.com>
>> Signed-off-by: Vaishnavi.d <vaishnavi.d@zilogic.com>
>> Signed-off-by: Tarun.T.U <tarun@zilogic.com>
>> ---
>>   runtest/syscalls                           |   1 +
>>   testcases/kernel/syscalls/statx/.gitignore |   1 +
>>   testcases/kernel/syscalls/statx/statx06.c  | 183 
>> +++++++++++++++++++++++++++++
>>   3 files changed, 185 insertions(+)
>>   create mode 100644 testcases/kernel/syscalls/statx/statx06.c
>>
>> diff --git a/runtest/syscalls b/runtest/syscalls
>> index 0d0be7713..71b83b25c 100644
>> --- a/runtest/syscalls
>> +++ b/runtest/syscalls
>> @@ -1504,3 +1504,4 @@ statx02 statx02
>>   statx03 statx03
>>   statx04 statx04
>>   statx05 statx05
>> +statx06 statx06
>> diff --git a/testcases/kernel/syscalls/statx/.gitignore 
>> b/testcases/kernel/syscalls/statx/.gitignore
>> index 209fc3a33..c1ceddabf 100644
>> --- a/testcases/kernel/syscalls/statx/.gitignore
>> +++ b/testcases/kernel/syscalls/statx/.gitignore
>> @@ -3,3 +3,4 @@
>>   /statx03
>>   /statx04
>>   /statx05
>> +/statx06
>> diff --git a/testcases/kernel/syscalls/statx/statx06.c 
>> b/testcases/kernel/syscalls/statx/statx06.c
>> new file mode 100644
>> index 000000000..8b66bf832
>> --- /dev/null
>> +++ b/testcases/kernel/syscalls/statx/statx06.c
>> @@ -0,0 +1,183 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + *  Copyright (c) Zilogic Systems Pvt. Ltd., 2018
>> + *  Email : code@zilogic.com
>> + */
>> +
>> +/*
>> + * Test statx
>> + *
>> + * This code tests the following flags:
>> + * 1) AT_STATX_FORCE_SYNC
>> + * 2) AT_STATX_DONT_SYNC
>> + *
>> + * By exportfs cmd creating NFS setup.
>> + *
>> + * A test file is created in server folder and statx is being
>> + * done in client folder.
>> + *
>> + * TESTCASE 1:
>> + * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
>> + * Then, by using AT_STATX_FORCE_SYNC getting new updated vaue
>> + * from server file changes.
>> + *
>> + * TESTCASE 2:
>> + * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
>> + * AT_STATX_FORCE_SYNC is called to create cache data of the file.
>> + * Then, by using DONT_SYNC_FILE getting old cached data in client 
>> folder,
>> + * but mode has been chaged in server file.
>> + *
>> + * Minimum kernel version required is 4.11.
>> + */
>> +
>> +#include <netdb.h>
>> +#include <stdio.h>
>> +#include <stdlib.h>
>> +#include "tst_test.h"
>> +#include "lapi/stat.h"
>> +
>> +#define MODE(X) (X & (~S_IFMT))
>> +#define BUFF_SIZE 512
>> +#define DEFAULT_MODE 0644
>> +#define CURRENT_MODE 0777
>> +
>> +#define CLIENT_PATH "client"
>> +#define SERVER_PATH "server"
>> +#define FORCE_SYNC_FILE  "force_sync_file"
>> +#define DONT_SYNC_FILE "dont_sync_file"
>> +
>> +static char cwd[BUFF_SIZE];
>> +static char cmd[BUFF_SIZE];
>> +
>> +static int get_mode(char *file_name, int flag_type, char *flag_name)
>> +{
>> +    char client_path[BUFF_SIZE];
>> +    struct statx buff;
>> +
>> +    sprintf(client_path, "%s/%s/%s", cwd, CLIENT_PATH, file_name);
>> +
>> +    TEST(statx(AT_FDCWD, client_path, flag_type, STATX_ALL, &buff));
>> +
>> +    if (TST_RET == -1)
>> +        tst_brk(TFAIL | TST_ERR,
>> +                "statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
>> +                file_name, flag_name);
>> +    else
>> +        tst_res(TINFO, "statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
>> +                file_name, flag_name);
> Seems like something strange is happening with the whitespace.
>
>> +
>> +    return buff.stx_mode;
>> +}
>> +
>> +static void test_for_dont_sync(void)
>> +{
>> +    unsigned int cur_mode;
>> +    char server_path[BUFF_SIZE];
>> +
>> +    sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, DONT_SYNC_FILE);
>> +
>> +    get_mode(DONT_SYNC_FILE, AT_STATX_FORCE_SYNC,
>> +            "AT_STATX_FORCE_SYNC");
>> +
>> +    SAFE_CHMOD(server_path, CURRENT_MODE);
>> +    cur_mode = get_mode(DONT_SYNC_FILE, AT_STATX_DONT_SYNC,
>> +            "AT_STATX_DONT_SYNC");
>> +
>> +    if (DEFAULT_MODE == MODE(cur_mode))
> Try running check_patch from the kernel on this:
>
> WARNING: Comparisons should place the constant on the right side of 
> the test
> #86: FILE: statx06.c:86:
> +       if (DEFAULT_MODE == MODE(cur_mode))
>
>> + tst_res(TPASS,
>> +                "statx() with AT_STATX_DONT_SYNC for mode %o %o",
>> +                DEFAULT_MODE, (cur_mode & ~S_IFMT));
>> +    else
>> +        tst_res(TFAIL,
>> +                "statx() with AT_STATX_DONT_SYNC for mode %o %o",
>> +                DEFAULT_MODE, (cur_mode & ~S_IFMT));
>> +}
>> +
>> +static void test_for_force_sync(void)
>> +{
>> +    unsigned int cur_mode;
>> +    char server_path[BUFF_SIZE];
>> +
>> +    sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, 
>> FORCE_SYNC_FILE);
>> +
>> +    SAFE_CHMOD(server_path, CURRENT_MODE);
>> +    cur_mode = get_mode(FORCE_SYNC_FILE, AT_STATX_FORCE_SYNC,
>> +            "AT_STATX_FORCE_SYNC");
>> +
>> +    if (CURRENT_MODE == MODE(cur_mode))
>> +        tst_res(TPASS,
>> +                "statx() with AT_STATX_FORCE_SYNC for mode %o %o",
>> +                CURRENT_MODE, (cur_mode & ~S_IFMT));
>> +    else
>> +        tst_res(TFAIL,
>> +                "statx() with AT_STATX_FORCE_SYNC for mode %o %o",
>> +                CURRENT_MODE, (cur_mode & ~S_IFMT));
>> +}
>> +
>> +struct test_cases {
>> +    void (*func)(void);
>> +} tcases[] = {
>> +    {test_for_dont_sync},
>> +    {test_for_force_sync}
>> +};
>> +
>> +static void test_statx(unsigned int nr)
>> +{
>> +    struct test_cases *tc = &tcases[nr];
>> +
>> +    tc->func();
>> +}
>> +
>> +static void setup(void)
>> +{
>> +    char force_sync_file[BUFF_SIZE];
>> +    char dont_sync_file[BUFF_SIZE];
>> +    char server_path[BUFF_SIZE];
>> +    char client_path[BUFF_SIZE];
>> +    char mount_data[BUFF_SIZE];
>> +    char *ip = "127.0.0.1";
>> +
>> +    TESTPTR(getcwd(cwd, BUFF_SIZE));
>> +    if (TST_RET_PTR == NULL)
>> +        tst_brk(TBROK | TST_ERR, "Failed to get PWD");
>> +
>> +    sprintf(force_sync_file, "%s/%s", SERVER_PATH, FORCE_SYNC_FILE);
>> +    sprintf(dont_sync_file, "%s/%s", SERVER_PATH, DONT_SYNC_FILE);
>> +
>> +    SAFE_MKDIR(SERVER_PATH, DEFAULT_MODE);
>> +    SAFE_MKDIR(CLIENT_PATH, DEFAULT_MODE);
>> +    SAFE_CREAT(force_sync_file, DEFAULT_MODE);
>> +    SAFE_CREAT(dont_sync_file, DEFAULT_MODE);
>> +
>> +    sprintf(server_path, ":%s/%s", cwd, SERVER_PATH);
>> +    sprintf(client_path, "%s/%s", cwd, CLIENT_PATH);
>> +    sprintf(mount_data, "addr=%s", ip);
> I get a lot of warnings when compiling with gcc8 like
>
> statx06.c:152:27: warning: ‘/’ directive writing 1 byte into a region 
> of size between 0 and 511 [-Wformat-overflow=]
>    sprintf(server_path, ":%s/%s", cwd, SERVER_PATH);
>
>
>> +
>> +    sprintf(cmd,
>> +            "exportfs -i -o no_root_squash,rw,sync,no_subtree_check 
>> *%s",
>> +            server_path);
> Must we use an absolute path here and when mounting?
    Yes, The problem with using relative path is exportfs writes the 
exact relative path to /var/lib/nfs/stab from where mount refers from. 
Because of this, ultimately mount fails. So, we are using absolute path 
in both cases.
>> +
>> +    if (WEXITSTATUS(tst_system(cmd)) == 127)
>> +        tst_brk(TBROK | TST_ERR, "%s not found", cmd);
> This should probably be just TCONF as we shouldn't expect all systems to
> support running an NFS server. Also you should check for other errors.
>
>> +
>> +    SAFE_MOUNT(server_path, client_path, "nfs", 0, mount_data);
>> +}
>> +
>> +static void cleanup(void)
>> +{
>> +    if (WEXITSTATUS(tst_system("exportfs -ua")) == 127)
>> +        tst_brk(TBROK | TST_ERR, "%s", cmd);
>> +
>> +    SAFE_UMOUNT(CLIENT_PATH);
>> +}
>> +
>> +static struct tst_test test = {
>> +    .tcnt = ARRAY_SIZE(tcases),
>> +    .test = test_statx,
>> +    .setup = setup,
>> +    .cleanup = cleanup,
>> +    .min_kver = "4.11",
>> +    .needs_tmpdir = 1,
>> +    .dev_fs_type = "nfs",
>> +    .needs_root = 1,
>> +};
>> -- 
>> 2.11.0
>
> -- 
> Thank you,
> Richard.

Regards,
Kewal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180911/8cca4ca8/attachment-0001.html>

[LTP] [PATCH v1] Test statx syscall for SYNC_FLAGS

[kewal]

This patch is extension of previous statx syscall patch.

* statx05.c :-

 Testcase 1: AT_STATX_DONT_SYNC
  With AT_STATX_DONT_SYNC server changes should not get sync with client.

 Testcase 2: AT_STATX_FORCE_SYNC
  With AT_STATX_FORCE_SYNC server changes should get sync with client.

Signed-off-by: Kewal Ukunde <kewal@zilogic.com>
Signed-off-by: Vaishnavi.d <vaishnavi.d@zilogic.com>
Signed-off-by: Tarun.T.U <tarun@zilogic.com>
---
 runtest/syscalls                           |   2 +
 testcases/kernel/syscalls/statx/.gitignore |   1 +
 testcases/kernel/syscalls/statx/statx05.c  | 195 +++++++++++++++++++++++++++++
 3 files changed, 198 insertions(+)
 create mode 100644 testcases/kernel/syscalls/statx/.gitignore
 create mode 100644 testcases/kernel/syscalls/statx/statx05.c

diff --git a/runtest/syscalls b/runtest/syscalls
index 3161d918d..297079f47 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -1277,6 +1277,8 @@ stat05_64 stat05_64
 stat06 stat06
 stat06_64 stat06_64
 
+statx05 statx05
+
 statfs01 statfs01
 statfs01_64 statfs01_64
 statfs02 statfs02
diff --git a/testcases/kernel/syscalls/statx/.gitignore b/testcases/kernel/syscalls/statx/.gitignore
new file mode 100644
index 000000000..e1c6e4141
--- /dev/null
+++ b/testcases/kernel/syscalls/statx/.gitignore
@@ -0,0 +1 @@
+/statx05
diff --git a/testcases/kernel/syscalls/statx/statx05.c b/testcases/kernel/syscalls/statx/statx05.c
new file mode 100644
index 000000000..cec520f0e
--- /dev/null
+++ b/testcases/kernel/syscalls/statx/statx05.c
@@ -0,0 +1,195 @@
+// SPDX-License-Identifier: GPL-2.0 or later
+/*
+*  Copyright (c) Zilogic Systems Pvt. Ltd., 2018
+*  Email : code@zilogic.com
+*
+* This program is free software;  you can redistribute it and/or modify
+* it under the terms of the GNU General Public License as published by
+* the Free Software Foundation; either version 2 of the License, or
+* (at your option) any later version.
+*
+* This program is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY;  without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
+* the GNU General Public License for more details.
+*/
+
+/*
+ * Test statx
+ *
+ * This code tests the following flags:
+ * 1) AT_STATX_FORCE_SYNC
+ * 2) AT_STATX_DONT_SYNC
+ *
+ * By exportfs cmd creating NFS setup.
+ *
+ * A test files are created in server folder and statx has been
+ * done in client folder.
+ *
+ * TESTCASE 1:
+ * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
+ * Then, by using AT_STATX_FORCE_SYNC getting new updated vaue
+ * from server file changes.
+ *
+ * TESTCASE 2:
+ * BY AT_STATX_SYNC_AS_STAT getting predefined mode value.
+ * AT_STATX_FORCE_SYNC is called to create cache data of the file. 
+ * Then, by using DONT_SYNC_FILE getting old cached data in client folder,
+ * but mode has been chaged in server file.
+ *
+ * Minimum kernel version required is 4.11.
+ */
+
+#include <netdb.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include "tst_test.h"
+#include "lapi/stat.h"
+
+#define MODE(X) (X & (~S_IFMT))
+#define BUFF_SIZE 512
+#define DEFAULT_MODE 0644
+#define CURRENT_MODE 0777
+
+#define CLIENT_PATH "client"
+#define SERVER_PATH "server"
+#define FORCE_SYNC_FILE  "force_sync_file"
+#define DONT_SYNC_FILE "dont_sync_file"
+
+static char cwd[BUFF_SIZE];
+static char cmd[BUFF_SIZE];
+
+static int get_mode(char *file_name, int flag_type, char *flag_name)
+{
+	char client_path[BUFF_SIZE];
+	struct statx buff;
+
+	sprintf(client_path, "%s/%s/%s", cwd, CLIENT_PATH, file_name);
+
+	TEST(statx(AT_FDCWD, client_path, flag_type, STATX_ALL, &buff));
+
+	if (TST_RET == -1)
+		tst_brk(TFAIL | TST_ERR,
+				"statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
+				file_name, flag_name);
+	else
+		tst_res(TINFO, "statx(AT_FDCWD, %s, %s, STATX_ALL, &buff)",
+				file_name, flag_name);
+
+	return buff.stx_mode;
+}
+
+static void test_for_dont_sync(void)
+{
+	unsigned int cur_mode;
+	char server_path[BUFF_SIZE];
+
+	sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, DONT_SYNC_FILE);
+
+	get_mode(DONT_SYNC_FILE, AT_STATX_FORCE_SYNC,
+			"AT_STATX_FORCE_SYNC");
+
+	SAFE_CHMOD(server_path, CURRENT_MODE);
+	cur_mode = get_mode(DONT_SYNC_FILE, AT_STATX_DONT_SYNC,
+			"AT_STATX_DONT_SYNC");
+
+	if (DEFAULT_MODE == MODE(cur_mode))
+		tst_res(TPASS,
+				"statx() with AT_STATX_DONT_SYNC for mode %o %o",
+				DEFAULT_MODE, (cur_mode & ~S_IFMT));
+	else
+		tst_res(TFAIL,
+				"statx() with AT_STATX_DONT_SYNC for mode %o %o",
+				DEFAULT_MODE, (cur_mode & ~S_IFMT));
+}
+
+static void test_for_force_sync(void)
+{
+	unsigned int cur_mode;
+	char server_path[BUFF_SIZE];
+
+	sprintf(server_path, "%s/%s/%s", cwd, SERVER_PATH, FORCE_SYNC_FILE);
+
+	SAFE_CHMOD(server_path, CURRENT_MODE);
+	cur_mode = get_mode(FORCE_SYNC_FILE, AT_STATX_FORCE_SYNC,
+			"AT_STATX_FORCE_SYNC");
+
+	if (CURRENT_MODE == MODE(cur_mode))
+		tst_res(TPASS,
+				"statx() with AT_STATX_FORCE_SYNC for mode %o %o",
+				CURRENT_MODE, (cur_mode & ~S_IFMT));
+	else
+		tst_res(TFAIL,
+				"statx() with AT_STATX_FORCE_SYNC for mode %o %o",
+				CURRENT_MODE, (cur_mode & ~S_IFMT));
+}
+
+struct test_cases {
+	void (*func)(void);
+} tcases[] = {
+	{test_for_dont_sync},
+	{test_for_force_sync}
+};
+
+static void test_statx(unsigned int nr)
+{
+	struct test_cases *tc = &tcases[nr];
+
+	tc->func();
+}
+
+static void setup(void)
+{
+	char force_sync_file[BUFF_SIZE];
+	char dont_sync_file[BUFF_SIZE];
+	char server_path[BUFF_SIZE];
+	char client_path[BUFF_SIZE];
+	char mount_data[BUFF_SIZE];
+	char *ip = "127.0.0.1";
+
+	TESTPTR(getcwd(cwd, BUFF_SIZE));
+	if (TST_RET_PTR == NULL)
+		tst_brk(TBROK | TST_ERR, "Failed to get PWD");
+
+	sprintf(force_sync_file, "%s/%s", SERVER_PATH, FORCE_SYNC_FILE);
+	sprintf(dont_sync_file, "%s/%s", SERVER_PATH, DONT_SYNC_FILE);
+
+	SAFE_MKDIR(SERVER_PATH, DEFAULT_MODE);
+	SAFE_MKDIR(CLIENT_PATH, DEFAULT_MODE);
+	SAFE_CREAT(force_sync_file, DEFAULT_MODE);
+	SAFE_CREAT(dont_sync_file, DEFAULT_MODE);
+
+	sprintf(server_path, ":%s/%s", cwd, SERVER_PATH);
+	sprintf(client_path, "%s/%s", cwd, CLIENT_PATH);
+	sprintf(mount_data, "addr=%s", ip);
+
+	sprintf(cmd,
+			"exportfs -i -o no_root_squash,rw,sync,no_subtree_check *%s",
+			server_path);
+
+	TEST(tst_system(cmd));
+	if (WEXITSTATUS(TST_RET) == 127)
+		tst_brk(TBROK | TST_ERR, "%s not found", cmd);
+
+	SAFE_MOUNT(server_path, client_path, "nfs", 0, mount_data);
+}
+
+static void cleanup(void)
+{
+	TEST(tst_system("exportfs -ua"));
+	if (WEXITSTATUS(TST_RET) == 127)
+		tst_brk(TBROK | TST_ERR, "%s", cmd);
+
+	SAFE_UMOUNT(CLIENT_PATH);
+}
+
+static struct tst_test test = {
+	.tcnt = ARRAY_SIZE(tcases),
+	.test = test_statx,
+	.setup = setup,
+	.cleanup = cleanup,
+	.min_kver = "4.11",
+	.needs_tmpdir = 1,
+	.dev_fs_type = "nfs",
+	.needs_root = 1,
+};
-- 
2.11.0