All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
@ 2017-10-26 15:07 ` jiada_wang
  0 siblings, 0 replies; 8+ messages in thread
From: jiada_wang @ 2017-10-26 15:07 UTC (permalink / raw)
  To: lgirdwood, broonie, perex, tiwai, kuninori.morimoto.gx, gustavo
  Cc: alsa-devel, linux-kernel, jiada_wang

From: Jiada Wang <jiada_wang@mentor.com>

register SSI_MODE is set when SSI works in TDM Extended or
TDM (Ex-)Split mode, but it isn't reset after SSI stops.
this will cause issue, if SSI starts to work in other modes
which requie SSI_MODE to have different value.

This patch resets SSI_MODE register in .stop callback,
when last stream calls .stop.

Fixes: 186fadc132f0 ("ASoC: rsnd: add TDM Extend Mode support")
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 sound/soc/sh/rcar/ssiu.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
index 4d94875..eff9f3b 100644
--- a/sound/soc/sh/rcar/ssiu.c
+++ b/sound/soc/sh/rcar/ssiu.c
@@ -217,6 +217,8 @@ static int rsnd_ssiu_stop_gen2(struct rsnd_mod *mod,
 	if (rsnd_ssi_multi_slaves_runtime(io))
 		rsnd_mod_write(mod, SSI_CONTROL, 0);
 
+	rsnd_mod_write(mod, SSI_MODE, 0);
+
 	return 0;
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
@ 2017-10-26 15:07 ` jiada_wang
  0 siblings, 0 replies; 8+ messages in thread
From: jiada_wang @ 2017-10-26 15:07 UTC (permalink / raw)
  To: lgirdwood, broonie, perex, tiwai, kuninori.morimoto.gx, gustavo
  Cc: jiada_wang, alsa-devel, linux-kernel

From: Jiada Wang <jiada_wang@mentor.com>

register SSI_MODE is set when SSI works in TDM Extended or
TDM (Ex-)Split mode, but it isn't reset after SSI stops.
this will cause issue, if SSI starts to work in other modes
which requie SSI_MODE to have different value.

This patch resets SSI_MODE register in .stop callback,
when last stream calls .stop.

Fixes: 186fadc132f0 ("ASoC: rsnd: add TDM Extend Mode support")
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 sound/soc/sh/rcar/ssiu.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
index 4d94875..eff9f3b 100644
--- a/sound/soc/sh/rcar/ssiu.c
+++ b/sound/soc/sh/rcar/ssiu.c
@@ -217,6 +217,8 @@ static int rsnd_ssiu_stop_gen2(struct rsnd_mod *mod,
 	if (rsnd_ssi_multi_slaves_runtime(io))
 		rsnd_mod_write(mod, SSI_CONTROL, 0);
 
+	rsnd_mod_write(mod, SSI_MODE, 0);
+
 	return 0;
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
  2017-10-26 15:07 ` jiada_wang
@ 2017-10-29 23:38   ` Kuninori Morimoto
  -1 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-10-29 23:38 UTC (permalink / raw)
  To: jiada_wang
  Cc: lgirdwood, broonie, perex, tiwai, gustavo, alsa-devel, linux-kernel


Hi Jiada

> register SSI_MODE is set when SSI works in TDM Extended or
> TDM (Ex-)Split mode, but it isn't reset after SSI stops.
> this will cause issue, if SSI starts to work in other modes
> which requie SSI_MODE to have different value.
> 
> This patch resets SSI_MODE register in .stop callback,
> when last stream calls .stop.
> 
> Fixes: 186fadc132f0 ("ASoC: rsnd: add TDM Extend Mode support")
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
>  sound/soc/sh/rcar/ssiu.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
> index 4d94875..eff9f3b 100644
> --- a/sound/soc/sh/rcar/ssiu.c
> +++ b/sound/soc/sh/rcar/ssiu.c
> @@ -217,6 +217,8 @@ static int rsnd_ssiu_stop_gen2(struct rsnd_mod *mod,
>  	if (rsnd_ssi_multi_slaves_runtime(io))
>  		rsnd_mod_write(mod, SSI_CONTROL, 0);
>  
> +	rsnd_mod_write(mod, SSI_MODE, 0);
> +
>  	return 0;
>  }

Thank you for your patch.
But, I don't want to reset register when stop, because
it might be point-less if SoC has power domain.
How about this or similar (not tested) ?

------------------
diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
index 4d94875..8dc2e92 100644
--- a/sound/soc/sh/rcar/ssiu.c
+++ b/sound/soc/sh/rcar/ssiu.c
@@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod,
 	if (ret < 0)
 		return ret;
 
-	if (rsnd_runtime_is_ssi_tdm(io)) {
-		/*
-		 * TDM Extend Mode
-		 * see
-		 *	rsnd_ssi_config_init()
-		 */
-		rsnd_mod_write(mod, SSI_MODE, 0x1);
-	}
+	/*
+	 * TDM Extend Mode
+	 * see
+	 *	rsnd_ssi_config_init()
+	 */
+	rsnd_mod_write(mod, SSI_MODE,
+		       rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);
 
 	if (rsnd_ssi_use_busif(io)) {
 		rsnd_mod_write(mod, SSI_BUSIF_ADINR,


Best regards
---
Kuninori Morimoto

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
@ 2017-10-29 23:38   ` Kuninori Morimoto
  0 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-10-29 23:38 UTC (permalink / raw)
  To: jiada_wang
  Cc: lgirdwood, broonie, perex, tiwai, gustavo, alsa-devel, linux-kernel


Hi Jiada

> register SSI_MODE is set when SSI works in TDM Extended or
> TDM (Ex-)Split mode, but it isn't reset after SSI stops.
> this will cause issue, if SSI starts to work in other modes
> which requie SSI_MODE to have different value.
> 
> This patch resets SSI_MODE register in .stop callback,
> when last stream calls .stop.
> 
> Fixes: 186fadc132f0 ("ASoC: rsnd: add TDM Extend Mode support")
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
>  sound/soc/sh/rcar/ssiu.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
> index 4d94875..eff9f3b 100644
> --- a/sound/soc/sh/rcar/ssiu.c
> +++ b/sound/soc/sh/rcar/ssiu.c
> @@ -217,6 +217,8 @@ static int rsnd_ssiu_stop_gen2(struct rsnd_mod *mod,
>  	if (rsnd_ssi_multi_slaves_runtime(io))
>  		rsnd_mod_write(mod, SSI_CONTROL, 0);
>  
> +	rsnd_mod_write(mod, SSI_MODE, 0);
> +
>  	return 0;
>  }

Thank you for your patch.
But, I don't want to reset register when stop, because
it might be point-less if SoC has power domain.
How about this or similar (not tested) ?

------------------
diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
index 4d94875..8dc2e92 100644
--- a/sound/soc/sh/rcar/ssiu.c
+++ b/sound/soc/sh/rcar/ssiu.c
@@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod,
 	if (ret < 0)
 		return ret;
 
-	if (rsnd_runtime_is_ssi_tdm(io)) {
-		/*
-		 * TDM Extend Mode
-		 * see
-		 *	rsnd_ssi_config_init()
-		 */
-		rsnd_mod_write(mod, SSI_MODE, 0x1);
-	}
+	/*
+	 * TDM Extend Mode
+	 * see
+	 *	rsnd_ssi_config_init()
+	 */
+	rsnd_mod_write(mod, SSI_MODE,
+		       rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);
 
 	if (rsnd_ssi_use_busif(io)) {
 		rsnd_mod_write(mod, SSI_BUSIF_ADINR,


Best regards
---
Kuninori Morimoto

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
  2017-10-29 23:38   ` Kuninori Morimoto
@ 2017-10-30  8:08     ` Jiada Wang
  -1 siblings, 0 replies; 8+ messages in thread
From: Jiada Wang @ 2017-10-30  8:08 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: lgirdwood, broonie, perex, tiwai, gustavo, alsa-devel, linux-kernel

Hello Morimoto-san


On 10/30/2017 08:38 AM, Kuninori Morimoto wrote:
>
> Hi Jiada
>
>> register SSI_MODE is set when SSI works in TDM Extended or
>> TDM (Ex-)Split mode, but it isn't reset after SSI stops.
>> this will cause issue, if SSI starts to work in other modes
>> which requie SSI_MODE to have different value.
>>
>> This patch resets SSI_MODE register in .stop callback,
>> when last stream calls .stop.
>>
>> Fixes: 186fadc132f0 ("ASoC: rsnd: add TDM Extend Mode support")
>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>> ---
>>  sound/soc/sh/rcar/ssiu.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
>> index 4d94875..eff9f3b 100644
>> --- a/sound/soc/sh/rcar/ssiu.c
>> +++ b/sound/soc/sh/rcar/ssiu.c
>> @@ -217,6 +217,8 @@ static int rsnd_ssiu_stop_gen2(struct rsnd_mod *mod,
>>  	if (rsnd_ssi_multi_slaves_runtime(io))
>>  		rsnd_mod_write(mod, SSI_CONTROL, 0);
>>
>> +	rsnd_mod_write(mod, SSI_MODE, 0);
>> +
>>  	return 0;
>>  }
>
> Thank you for your patch.
> But, I don't want to reset register when stop, because
> it might be point-less if SoC has power domain.
> How about this or similar (not tested) ?
>
> ------------------
> diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
> index 4d94875..8dc2e92 100644
> --- a/sound/soc/sh/rcar/ssiu.c
> +++ b/sound/soc/sh/rcar/ssiu.c
> @@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod,
>  	if (ret < 0)
>  		return ret;
>
> -	if (rsnd_runtime_is_ssi_tdm(io)) {
> -		/*
> -		 * TDM Extend Mode
> -		 * see
> -		 *	rsnd_ssi_config_init()
> -		 */
> -		rsnd_mod_write(mod, SSI_MODE, 0x1);
> -	}
> +	/*
> +	 * TDM Extend Mode
> +	 * see
> +	 *	rsnd_ssi_config_init()
> +	 */
> +	rsnd_mod_write(mod, SSI_MODE,
> +		       rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);

Thanks for your suggestion,
I will do some test for this change,
if it works fine, I will submit ver2 with it

Thanks,
Jiada
>
>  	if (rsnd_ssi_use_busif(io)) {
>  		rsnd_mod_write(mod, SSI_BUSIF_ADINR,
>
>
> Best regards
> ---
> Kuninori Morimoto
>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
@ 2017-10-30  8:08     ` Jiada Wang
  0 siblings, 0 replies; 8+ messages in thread
From: Jiada Wang @ 2017-10-30  8:08 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: alsa-devel, gustavo, linux-kernel, tiwai, lgirdwood, broonie

Hello Morimoto-san


On 10/30/2017 08:38 AM, Kuninori Morimoto wrote:
>
> Hi Jiada
>
>> register SSI_MODE is set when SSI works in TDM Extended or
>> TDM (Ex-)Split mode, but it isn't reset after SSI stops.
>> this will cause issue, if SSI starts to work in other modes
>> which requie SSI_MODE to have different value.
>>
>> This patch resets SSI_MODE register in .stop callback,
>> when last stream calls .stop.
>>
>> Fixes: 186fadc132f0 ("ASoC: rsnd: add TDM Extend Mode support")
>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>> ---
>>  sound/soc/sh/rcar/ssiu.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
>> index 4d94875..eff9f3b 100644
>> --- a/sound/soc/sh/rcar/ssiu.c
>> +++ b/sound/soc/sh/rcar/ssiu.c
>> @@ -217,6 +217,8 @@ static int rsnd_ssiu_stop_gen2(struct rsnd_mod *mod,
>>  	if (rsnd_ssi_multi_slaves_runtime(io))
>>  		rsnd_mod_write(mod, SSI_CONTROL, 0);
>>
>> +	rsnd_mod_write(mod, SSI_MODE, 0);
>> +
>>  	return 0;
>>  }
>
> Thank you for your patch.
> But, I don't want to reset register when stop, because
> it might be point-less if SoC has power domain.
> How about this or similar (not tested) ?
>
> ------------------
> diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
> index 4d94875..8dc2e92 100644
> --- a/sound/soc/sh/rcar/ssiu.c
> +++ b/sound/soc/sh/rcar/ssiu.c
> @@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod,
>  	if (ret < 0)
>  		return ret;
>
> -	if (rsnd_runtime_is_ssi_tdm(io)) {
> -		/*
> -		 * TDM Extend Mode
> -		 * see
> -		 *	rsnd_ssi_config_init()
> -		 */
> -		rsnd_mod_write(mod, SSI_MODE, 0x1);
> -	}
> +	/*
> +	 * TDM Extend Mode
> +	 * see
> +	 *	rsnd_ssi_config_init()
> +	 */
> +	rsnd_mod_write(mod, SSI_MODE,
> +		       rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);

Thanks for your suggestion,
I will do some test for this change,
if it works fine, I will submit ver2 with it

Thanks,
Jiada
>
>  	if (rsnd_ssi_use_busif(io)) {
>  		rsnd_mod_write(mod, SSI_BUSIF_ADINR,
>
>
> Best regards
> ---
> Kuninori Morimoto
>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
  2017-10-30  8:08     ` Jiada Wang
@ 2017-10-30  8:10       ` Kuninori Morimoto
  -1 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-10-30  8:10 UTC (permalink / raw)
  To: Jiada Wang
  Cc: lgirdwood, broonie, perex, tiwai, gustavo, alsa-devel, linux-kernel


Hi Jiada

> > ------------------
> > diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
> > index 4d94875..8dc2e92 100644
> > --- a/sound/soc/sh/rcar/ssiu.c
> > +++ b/sound/soc/sh/rcar/ssiu.c
> > @@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod,
> >  	if (ret < 0)
> >  		return ret;
> >
> > -	if (rsnd_runtime_is_ssi_tdm(io)) {
> > -		/*
> > -		 * TDM Extend Mode
> > -		 * see
> > -		 *	rsnd_ssi_config_init()
> > -		 */
> > -		rsnd_mod_write(mod, SSI_MODE, 0x1);
> > -	}
> > +	/*
> > +	 * TDM Extend Mode
> > +	 * see
> > +	 *	rsnd_ssi_config_init()
> > +	 */
> > +	rsnd_mod_write(mod, SSI_MODE,
> > +		       rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);
> 
> Thanks for your suggestion,
> I will do some test for this change,
> if it works fine, I will submit ver2 with it

Thanks

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register
@ 2017-10-30  8:10       ` Kuninori Morimoto
  0 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-10-30  8:10 UTC (permalink / raw)
  To: Jiada Wang
  Cc: lgirdwood, broonie, perex, tiwai, gustavo, alsa-devel, linux-kernel


Hi Jiada

> > ------------------
> > diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
> > index 4d94875..8dc2e92 100644
> > --- a/sound/soc/sh/rcar/ssiu.c
> > +++ b/sound/soc/sh/rcar/ssiu.c
> > @@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod,
> >  	if (ret < 0)
> >  		return ret;
> >
> > -	if (rsnd_runtime_is_ssi_tdm(io)) {
> > -		/*
> > -		 * TDM Extend Mode
> > -		 * see
> > -		 *	rsnd_ssi_config_init()
> > -		 */
> > -		rsnd_mod_write(mod, SSI_MODE, 0x1);
> > -	}
> > +	/*
> > +	 * TDM Extend Mode
> > +	 * see
> > +	 *	rsnd_ssi_config_init()
> > +	 */
> > +	rsnd_mod_write(mod, SSI_MODE,
> > +		       rsnd_runtime_is_ssi_tdm(io) ? 0x1 : 0x0);
> 
> Thanks for your suggestion,
> I will do some test for this change,
> if it works fine, I will submit ver2 with it

Thanks

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-10-30  8:11 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-26 15:07 [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register jiada_wang
2017-10-26 15:07 ` jiada_wang
2017-10-29 23:38 ` Kuninori Morimoto
2017-10-29 23:38   ` Kuninori Morimoto
2017-10-30  8:08   ` Jiada Wang
2017-10-30  8:08     ` Jiada Wang
2017-10-30  8:10     ` Kuninori Morimoto
2017-10-30  8:10       ` Kuninori Morimoto

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.