All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Krzysztof Halasa <khalasa@piap.pl>, Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Viresh Kumar <vireshk@kernel.org>,
	Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, <helgaas@kernel.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Greg Ungerer <gerg@uclinux.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<nsekhar@ti.com>
Subject: Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
Date: Mon, 01 Aug 2016 21:10:22 +0200	[thread overview]
Message-ID: <87oa5cxq3l.fsf@belgarion.home> (raw)
In-Reply-To: <1470049950-4697-3-git-send-email-kishon@ti.com> (Kishon Vijay Abraham, I's message of "Mon, 1 Aug 2016 16:42:29 +0530")

Kishon Vijay Abraham I <kishon@ti.com> writes:

> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.

If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as
they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change
below shouldn't be done according to the commit message.

> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index cd894d6..39f7755 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -113,7 +113,6 @@ config MACH_ARMCORE
>  	bool "CompuLab CM-X255/CM-X270 modules"
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
>  	select IWMMXT
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H if PCI
>  	select PXA25x
>  	select PXA27x

Cheers.

--
Robert

WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-pci@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Greg Ungerer <gerg@uclinux.org>,
	linux-samsung-soc@vger.kernel.org,
	Viresh Kumar <vireshk@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Kukjin Kim <kgene@kernel.org>,
	helgaas@kernel.org,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	devicetree@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
	Arnd Bergmann <arnd@arndb.de>,
	nsekhar@ti.com, Haojian Zhuang <haojian.zhuang@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.orgShiraz Hashim <sh>
Subject: Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
Date: Mon, 01 Aug 2016 21:10:22 +0200	[thread overview]
Message-ID: <87oa5cxq3l.fsf@belgarion.home> (raw)
In-Reply-To: <1470049950-4697-3-git-send-email-kishon@ti.com> (Kishon Vijay Abraham, I's message of "Mon, 1 Aug 2016 16:42:29 +0530")

Kishon Vijay Abraham I <kishon@ti.com> writes:

> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.

If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as
they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change
below shouldn't be done according to the commit message.

> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index cd894d6..39f7755 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -113,7 +113,6 @@ config MACH_ARMCORE
>  	bool "CompuLab CM-X255/CM-X270 modules"
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
>  	select IWMMXT
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H if PCI
>  	select PXA25x
>  	select PXA27x

Cheers.

--
Robert

WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-pci@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Greg Ungerer <gerg@uclinux.org>,
	linux-samsung-soc@vger.kernel.org,
	Viresh Kumar <vireshk@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Kukjin Kim <kgene@kernel.org>,
	helgaas@kernel.org,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	devicetree@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
	Arnd Bergmann <arnd@arndb.de>,
	nsekhar@ti.com, Haojian Zhuang <haojian.zhuang@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>, Daniel Mack <daniel@zonque.org>
Subject: Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
Date: Mon, 01 Aug 2016 21:10:22 +0200	[thread overview]
Message-ID: <87oa5cxq3l.fsf@belgarion.home> (raw)
In-Reply-To: <1470049950-4697-3-git-send-email-kishon@ti.com> (Kishon Vijay Abraham, I's message of "Mon, 1 Aug 2016 16:42:29 +0530")

Kishon Vijay Abraham I <kishon@ti.com> writes:

> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.

If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as
they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change
below shouldn't be done according to the commit message.

> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index cd894d6..39f7755 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -113,7 +113,6 @@ config MACH_ARMCORE
>  	bool "CompuLab CM-X255/CM-X270 modules"
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
>  	select IWMMXT
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H if PCI
>  	select PXA25x
>  	select PXA27x

Cheers.

--
Robert

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly
Date: Mon, 01 Aug 2016 21:10:22 +0200	[thread overview]
Message-ID: <87oa5cxq3l.fsf@belgarion.home> (raw)
In-Reply-To: <1470049950-4697-3-git-send-email-kishon@ti.com> (Kishon Vijay Abraham, I's message of "Mon, 1 Aug 2016 16:42:29 +0530")

Kishon Vijay Abraham I <kishon@ti.com> writes:

> *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM.
> Fix it from getting redundantly selected in all
> ARCH_MULTIPLATFORM based machines.

If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as
they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change
below shouldn't be done according to the commit message.

> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index cd894d6..39f7755 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -113,7 +113,6 @@ config MACH_ARMCORE
>  	bool "CompuLab CM-X255/CM-X270 modules"
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
>  	select IWMMXT
> -	select MIGHT_HAVE_PCI
>  	select NEED_MACH_IO_H if PCI
>  	select PXA25x
>  	select PXA27x

Cheers.

--
Robert

  parent reply	other threads:[~2016-08-02  0:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 11:12 [PATCH v2 0/3] ARM: cleanup PCI specific configs Kishon Vijay Abraham I
2016-08-01 11:12 ` Kishon Vijay Abraham I
2016-08-01 11:12 ` Kishon Vijay Abraham I
2016-08-01 11:12 ` [PATCH v2 1/3] ARM: dts: DRA7: Add "linux,pci-domain" property for pci dt nodes Kishon Vijay Abraham I
2016-08-01 11:12   ` [PATCH v2 1/3] ARM: dts: DRA7: Add "linux, pci-domain" " Kishon Vijay Abraham I
2016-08-01 11:12   ` Kishon Vijay Abraham I
2016-08-01 11:12 ` [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Kishon Vijay Abraham I
2016-08-01 11:12   ` Kishon Vijay Abraham I
2016-08-01 11:12   ` Kishon Vijay Abraham I
2016-08-01 15:24   ` Russell King - ARM Linux
2016-08-01 15:24     ` Russell King - ARM Linux
2016-08-01 15:24     ` Russell King - ARM Linux
2016-08-02  6:11     ` Kishon Vijay Abraham I
2016-08-02  6:11       ` Kishon Vijay Abraham I
2016-08-02  6:11       ` Kishon Vijay Abraham I
2016-08-01 15:50   ` Nicolas Ferre
2016-08-01 15:50     ` Nicolas Ferre
2016-08-01 15:50     ` Nicolas Ferre
2016-08-01 15:50     ` Nicolas Ferre
2016-08-01 20:26     ` Alexandre Belloni
2016-08-01 20:26       ` Alexandre Belloni
2016-08-01 20:26       ` Alexandre Belloni
2016-08-01 20:26       ` Alexandre Belloni
2016-08-01 19:10   ` Robert Jarzmik [this message]
2016-08-01 19:10     ` Robert Jarzmik
2016-08-01 19:10     ` Robert Jarzmik
2016-08-01 19:10     ` Robert Jarzmik
2016-08-02  6:15     ` Kishon Vijay Abraham I
2016-08-02  6:15       ` Kishon Vijay Abraham I
2016-08-02  6:15       ` Kishon Vijay Abraham I
2016-08-01 20:24   ` Alexandre Belloni
2016-08-01 20:24     ` Alexandre Belloni
2016-08-01 20:24     ` Alexandre Belloni
2016-08-02  6:22   ` Kishon Vijay Abraham I
2016-08-02  6:22     ` Kishon Vijay Abraham I
2016-08-02  6:22     ` Kishon Vijay Abraham I
2016-08-01 11:12 ` [RFT PATCH v2 3/3] ARM: select PCI_DOMAINS config from ARCH_MULTIPLATFORM Kishon Vijay Abraham I
2016-08-01 11:12   ` Kishon Vijay Abraham I
2016-08-01 11:12   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa5cxq3l.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=daniel@zonque.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=gerg@uclinux.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=helgaas@kernel.org \
    --cc=horms@verge.net.au \
    --cc=k.kozlowski@samsung.com \
    --cc=kernel@pengutronix.de \
    --cc=kgene@kernel.org \
    --cc=khalasa@piap.pl \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=nsekhar@ti.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=shiraz.linux.kernel@gmail.com \
    --cc=ssantosh@kernel.org \
    --cc=tony@atomide.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.