* [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region
@ 2015-08-24 8:27 Kuninori Morimoto
2015-08-24 9:50 ` Geert Uytterhoeven
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2015-08-24 8:27 UTC (permalink / raw)
To: linux-sh
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/boot/dts/r8a7778.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
index 4b1fa9f..b317ec8 100644
--- a/arch/arm/boot/dts/r8a7778.dtsi
+++ b/arch/arm/boot/dts/r8a7778.dtsi
@@ -239,7 +239,7 @@
#sound-dai-cells = <1>;
compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
reg = <0xffd90000 0x1000>, /* SRU */
- <0xffd91000 0x1240>, /* SSI */
+ <0xffd91000 0x270>, /* SSI */
<0xfffe0000 0x24>; /* ADG */
clocks = <&mstp3_clks R8A7778_CLK_SSI8>,
<&mstp3_clks R8A7778_CLK_SSI7>,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region
2015-08-24 8:27 [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region Kuninori Morimoto
@ 2015-08-24 9:50 ` Geert Uytterhoeven
2015-08-24 23:35 ` Kuninori Morimoto
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2015-08-24 9:50 UTC (permalink / raw)
To: linux-sh
On Mon, Aug 24, 2015 at 10:27 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> --- a/arch/arm/boot/dts/r8a7778.dtsi
> +++ b/arch/arm/boot/dts/r8a7778.dtsi
> @@ -239,7 +239,7 @@
> #sound-dai-cells = <1>;
> compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
> reg = <0xffd90000 0x1000>, /* SRU */
> - <0xffd91000 0x1240>, /* SSI */
> + <0xffd91000 0x270>, /* SSI */
Why not 0x240?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region
2015-08-24 8:27 [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region Kuninori Morimoto
2015-08-24 9:50 ` Geert Uytterhoeven
@ 2015-08-24 23:35 ` Kuninori Morimoto
2015-08-25 6:36 ` Geert Uytterhoeven
2015-08-25 6:58 ` Kuninori Morimoto
3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2015-08-24 23:35 UTC (permalink / raw)
To: linux-sh
Hi Geert
> > --- a/arch/arm/boot/dts/r8a7778.dtsi
> > +++ b/arch/arm/boot/dts/r8a7778.dtsi
> > @@ -239,7 +239,7 @@
> > #sound-dai-cells = <1>;
> > compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
> > reg = <0xffd90000 0x1000>, /* SRU */
> > - <0xffd91000 0x1240>, /* SSI */
> > + <0xffd91000 0x270>, /* SSI */
>
> Why not 0x240?
0x240 can't care channel 9
I forgot why it used 0x1240, not 0x1270
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region
2015-08-24 8:27 [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region Kuninori Morimoto
2015-08-24 9:50 ` Geert Uytterhoeven
2015-08-24 23:35 ` Kuninori Morimoto
@ 2015-08-25 6:36 ` Geert Uytterhoeven
2015-08-25 6:58 ` Kuninori Morimoto
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2015-08-25 6:36 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Tue, Aug 25, 2015 at 1:35 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > --- a/arch/arm/boot/dts/r8a7778.dtsi
>> > +++ b/arch/arm/boot/dts/r8a7778.dtsi
>> > @@ -239,7 +239,7 @@
>> > #sound-dai-cells = <1>;
>> > compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
>> > reg = <0xffd90000 0x1000>, /* SRU */
>> > - <0xffd91000 0x1240>, /* SSI */
>> > + <0xffd91000 0x270>, /* SSI */
>>
>> Why not 0x240?
>
> 0x240 can't care channel 9
> I forgot why it used 0x1240, not 0x1270
According to my documentation, r8a7778 has channels 0-8, r8a7779 has 0-9.
So I'd expect 0x240 on r8a7778, and 0x280 on r8a7779.
Still, 10 * 0x40 = 0x280, not 0x270.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region
2015-08-24 8:27 [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region Kuninori Morimoto
` (2 preceding siblings ...)
2015-08-25 6:36 ` Geert Uytterhoeven
@ 2015-08-25 6:58 ` Kuninori Morimoto
3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2015-08-25 6:58 UTC (permalink / raw)
To: linux-sh
Hi Geert
> >> > --- a/arch/arm/boot/dts/r8a7778.dtsi
> >> > +++ b/arch/arm/boot/dts/r8a7778.dtsi
> >> > @@ -239,7 +239,7 @@
> >> > #sound-dai-cells = <1>;
> >> > compatible = "renesas,rcar_sound-r8a7778", "renesas,rcar_sound-gen1";
> >> > reg = <0xffd90000 0x1000>, /* SRU */
> >> > - <0xffd91000 0x1240>, /* SSI */
> >> > + <0xffd91000 0x270>, /* SSI */
> >>
> >> Why not 0x240?
> >
> > 0x240 can't care channel 9
> > I forgot why it used 0x1240, not 0x1270
>
> According to my documentation, r8a7778 has channels 0-8, r8a7779 has 0-9.
> So I'd expect 0x240 on r8a7778, and 0x280 on r8a7779.
>
> Still, 10 * 0x40 = 0x280, not 0x270.
Grr... my bad.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-25 6:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-24 8:27 [PATCH] ARM: shmobile: r8a7778: tidyup SSI resource region Kuninori Morimoto
2015-08-24 9:50 ` Geert Uytterhoeven
2015-08-24 23:35 ` Kuninori Morimoto
2015-08-25 6:36 ` Geert Uytterhoeven
2015-08-25 6:58 ` Kuninori Morimoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.