[PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

[PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

[Eric W. Biederman]

With user namespaces enabled building f2fs fails with:

 CC      fs/f2fs/acl.o
fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
make[2]: *** [fs/f2fs/acl.o] Error 1
make[2]: Target `__build' not remade because of errors.

e_id is a backwards compatibility field only used for file systems
that haven't been converted to use kuids and kgids.  When the posix
acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
unnecessary.  Remove the assignment so f2fs will build with user
namespaces enabled.

Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Cc: Namjae Jeon <namjae.jeon@samsung.com>
Cc: Amit Sahrawat <a.sahrawat@samsung.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---

Barring other feedback I will push this change to Linus with my other
namespace bug fixes in the next day or two.

 fs/f2fs/acl.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index fed74d1..e95b949 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -82,7 +82,6 @@ static struct posix_acl *f2fs_acl_from_disk(const char *value, size_t size)
 		case ACL_GROUP_OBJ:
 		case ACL_MASK:
 		case ACL_OTHER:
-			acl->a_entries[i].e_id = ACL_UNDEFINED_ID;
 			entry = (struct f2fs_acl_entry *)((char *)entry +
 					sizeof(struct f2fs_acl_entry_short));
 			break;
-- 
1.7.5.4

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers

[PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

[Eric W. Biederman]

With user namespaces enabled building f2fs fails with:

 CC      fs/f2fs/acl.o
fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
make[2]: *** [fs/f2fs/acl.o] Error 1
make[2]: Target `__build' not remade because of errors.

e_id is a backwards compatibility field only used for file systems
that haven't been converted to use kuids and kgids.  When the posix
acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
unnecessary.  Remove the assignment so f2fs will build with user
namespaces enabled.

Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Cc: Namjae Jeon <namjae.jeon@samsung.com>
Cc: Amit Sahrawat <a.sahrawat@samsung.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---

Barring other feedback I will push this change to Linus with my other
namespace bug fixes in the next day or two.

 fs/f2fs/acl.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index fed74d1..e95b949 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -82,7 +82,6 @@ static struct posix_acl *f2fs_acl_from_disk(const char *value, size_t size)
 		case ACL_GROUP_OBJ:
 		case ACL_MASK:
 		case ACL_OTHER:
-			acl->a_entries[i].e_id = ACL_UNDEFINED_ID;
 			entry = (struct f2fs_acl_entry *)((char *)entry +
 					sizeof(struct f2fs_acl_entry_short));
 			break;
-- 
1.7.5.4

Re: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

[Jaegeuk Kim]

[-- Attachment #1.1: Type: text/plain, Size: 1111 bytes --]

2012-12-25 (화), 16:41 -0800, Eric W. Biederman:
> With user namespaces enabled building f2fs fails with:
> 
>  CC      fs/f2fs/acl.o
> fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
> fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
> make[2]: *** [fs/f2fs/acl.o] Error 1
> make[2]: Target `__build' not remade because of errors.
> 
> e_id is a backwards compatibility field only used for file systems
> that haven't been converted to use kuids and kgids.  When the posix
> acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
> unnecessary.  Remove the assignment so f2fs will build with user
> namespaces enabled.
> 
> Cc: Jaegeuk Kim <jaegeuk.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Amit Sahrawat <a.sahrawat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>

Acked-by: Jaegeuk Kim <jaegeuk.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

-- 
Jaegeuk Kim
Samsung

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 205 bytes --]

_______________________________________________
Containers mailing list
Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/containers

Re: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

[Jaegeuk Kim]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

2012-12-25 (화), 16:41 -0800, Eric W. Biederman:
> With user namespaces enabled building f2fs fails with:
> 
>  CC      fs/f2fs/acl.o
> fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
> fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
> make[2]: *** [fs/f2fs/acl.o] Error 1
> make[2]: Target `__build' not remade because of errors.
> 
> e_id is a backwards compatibility field only used for file systems
> that haven't been converted to use kuids and kgids.  When the posix
> acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
> unnecessary.  Remove the assignment so f2fs will build with user
> namespaces enabled.
> 
> Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com>
> Cc: Namjae Jeon <namjae.jeon@samsung.com>
> Cc: Amit Sahrawat <a.sahrawat@samsung.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Acked-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>

-- 
Jaegeuk Kim
Samsung

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]