* [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c
[not found] <1326172144-4198-1-git-send-email-y>
@ 2012-01-10 7:35 ` JJ Ding
2012-01-10 16:57 ` David Brown
0 siblings, 1 reply; 4+ messages in thread
From: JJ Ding @ 2012-01-10 7:35 UTC (permalink / raw)
To: David Brown, Daniel Walker, Bryan Huntsman, linux-arm-msm
Cc: JJ Ding, JJ Ding
From: JJ Ding <dgdunix@gmail.com>
Include linux/export.h to fix the following when CONFIG_DEBUG_FS=y.
CC arch/arm/mach-msm/vreg.o
arch/arm/mach-msm/vreg.c:190: error: 'THIS_MODULE' undeclared here (not in a function)
make[2]: *** [arch/arm/mach-msm/vreg.o] Error 1
make[1]: *** [arch/arm/mach-msm] Error 2
make: *** [sub-make] Error 2
Signed-off-by: JJ Ding <dgdunix@gmail.com>
---
Hi all,
Sorry for the wrong sender field in last mail.
Here is the correct version.
Thanks,
jj
arch/arm/mach-msm/vreg.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-msm/vreg.c b/arch/arm/mach-msm/vreg.c
index a9103bc..e87792b 100644
--- a/arch/arm/mach-msm/vreg.c
+++ b/arch/arm/mach-msm/vreg.c
@@ -20,6 +20,7 @@
#include <linux/init.h>
#include <linux/debugfs.h>
#include <linux/string.h>
+#include <linux/export.h>
#include <mach/vreg.h>
#include "proc_comm.h"
--
1.7.8
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c
2012-01-10 7:35 ` [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c JJ Ding
@ 2012-01-10 16:57 ` David Brown
2012-01-11 1:06 ` JJ Ding
0 siblings, 1 reply; 4+ messages in thread
From: David Brown @ 2012-01-10 16:57 UTC (permalink / raw)
To: JJ Ding; +Cc: Daniel Walker, Bryan Huntsman, linux-arm-msm, JJ Ding
On Tue, Jan 10, 2012 at 03:35:59PM +0800, JJ Ding wrote:
> diff --git a/arch/arm/mach-msm/vreg.c b/arch/arm/mach-msm/vreg.c
> index a9103bc..e87792b 100644
> --- a/arch/arm/mach-msm/vreg.c
> +++ b/arch/arm/mach-msm/vreg.c
> @@ -20,6 +20,7 @@
> #include <linux/init.h>
> #include <linux/debugfs.h>
> #include <linux/string.h>
> +#include <linux/export.h>
> #include <mach/vreg.h>
>
> #include "proc_comm.h"
Thanks for the patch, although I just submitted a pull request
containing a very similar fix:
http://article.gmane.org/gmane.linux.ports.arm.msm/2289
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c
2012-01-10 16:57 ` David Brown
@ 2012-01-11 1:06 ` JJ Ding
2012-01-11 1:27 ` David Brown
0 siblings, 1 reply; 4+ messages in thread
From: JJ Ding @ 2012-01-11 1:06 UTC (permalink / raw)
To: David Brown; +Cc: Daniel Walker, Bryan Huntsman, linux-arm-msm, JJ Ding
Hi David,
On Tue, 10 Jan 2012 08:57:40 -0800, David Brown <davidb@codeaurora.org> wrote:
> On Tue, Jan 10, 2012 at 03:35:59PM +0800, JJ Ding wrote:
>
> > diff --git a/arch/arm/mach-msm/vreg.c b/arch/arm/mach-msm/vreg.c
> > index a9103bc..e87792b 100644
> > --- a/arch/arm/mach-msm/vreg.c
> > +++ b/arch/arm/mach-msm/vreg.c
> > @@ -20,6 +20,7 @@
> > #include <linux/init.h>
> > #include <linux/debugfs.h>
> > #include <linux/string.h>
> > +#include <linux/export.h>
> > #include <mach/vreg.h>
> >
> > #include "proc_comm.h"
>
> Thanks for the patch, although I just submitted a pull request
> containing a very similar fix:
>
> http://article.gmane.org/gmane.linux.ports.arm.msm/2289
I am not subscribed to this list and happen to run into this.
Thanks for pointing me at this.
jj
> David
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c
2012-01-11 1:06 ` JJ Ding
@ 2012-01-11 1:27 ` David Brown
0 siblings, 0 replies; 4+ messages in thread
From: David Brown @ 2012-01-11 1:27 UTC (permalink / raw)
To: JJ Ding; +Cc: Daniel Walker, Bryan Huntsman, linux-arm-msm, JJ Ding
On Wed, Jan 11, 2012 at 09:06:02AM +0800, JJ Ding wrote:
> > Thanks for the patch, although I just submitted a pull request
> > containing a very similar fix:
> >
> > http://article.gmane.org/gmane.linux.ports.arm.msm/2289
>
> I am not subscribed to this list and happen to run into this.
> Thanks for pointing me at this.
I also CC'd the arm-linux-kernel and linux-kernel lists. They're high
traffic, though, so it's easy to miss things.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-11 1:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1326172144-4198-1-git-send-email-y>
2012-01-10 7:35 ` [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c JJ Ding
2012-01-10 16:57 ` David Brown
2012-01-11 1:06 ` JJ Ding
2012-01-11 1:27 ` David Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.