* [PATCH] wireless: ralink: rt2x00: Remove unnecessary spaces
[not found] <tencent_0AFA418AB6A31D66F3B0481E8BC58A70A108@qq.com>
@ 2023-07-21 9:37 ` hanyu001
2023-07-21 10:45 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: hanyu001 @ 2023-07-21 9:37 UTC (permalink / raw)
To: stf_xl, helmut.schaa, kvalo; +Cc: linux-wireless, linux-kernel
Fix checkpatch warnings:
./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space
prohibited after that open parenthesis '('
./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space
prohibited before that close parenthesis ')'
./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space
prohibited after that open parenthesis '('
./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space
prohibited before that close parenthesis ')'
Signed-off-by: Yu Han <hanyu001@208suo.com>
---
drivers/net/wireless/ralink/rt2x00/rt2x00reg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h
b/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h
index ffe802b..0e5094a 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h
@@ -165,8 +165,8 @@ struct rt2x00_field32 {
* Note that we cannot use the is_power_of_2() function since this
* check must be done at compile-time.
*/
-#define is_power_of_two(x) ( !((x) & ((x)-1)) )
-#define low_bit_mask(x) ( ((x)-1) & ~(x) )
+#define is_power_of_two(x) (!((x) & ((x)-1)))
+#define low_bit_mask(x) (((x)-1) & ~(x))
#define is_valid_mask(x) is_power_of_two(1LU + (x) +
low_bit_mask(x))
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wireless: ralink: rt2x00: Remove unnecessary spaces
2023-07-21 9:37 ` [PATCH] wireless: ralink: rt2x00: Remove unnecessary spaces hanyu001
@ 2023-07-21 10:45 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-07-21 10:45 UTC (permalink / raw)
To: hanyu001; +Cc: stf_xl, helmut.schaa, linux-wireless, linux-kernel
hanyu001@208suo.com writes:
> Fix checkpatch warnings:
>
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space
> prohibited after that open parenthesis '('
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space
> prohibited before that close parenthesis ')'
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space
> prohibited after that open parenthesis '('
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space
> prohibited before that close parenthesis ')'
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>
I have seen a lot of checkpatch fixes from you. We do not really like
random checkpatch fixes from new people, too much work for very little
gain. From looking at the title it's clear that you have not even read
our wireless specific instructions from our wiki (see link below).
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-21 10:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_0AFA418AB6A31D66F3B0481E8BC58A70A108@qq.com>
2023-07-21 9:37 ` [PATCH] wireless: ralink: rt2x00: Remove unnecessary spaces hanyu001
2023-07-21 10:45 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.