From: Cornelia Huck <cohuck@redhat.com> To: Parav Pandit <parav@nvidia.com>, Heng Qi <hengqi@linux.alibaba.com>, "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>, "virtio-comment@lists.oasis-open.org" <virtio-comment@lists.oasis-open.org> Cc: "Michael S . Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Alvaro Karsz <alvaro.karsz@solid-run.com>, David Edmondson <david.edmondson@oracle.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com> Subject: [virtio-dev] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation Date: Wed, 22 Mar 2023 17:36:39 +0100 [thread overview] Message-ID: <87pm90hhew.fsf@redhat.com> (raw) In-Reply-To: <PH0PR12MB5481FCF22C47F2D23E6638E2DC869@PH0PR12MB5481.namprd12.prod.outlook.com> On Wed, Mar 22 2023, Parav Pandit <parav@nvidia.com> wrote: >> From: Cornelia Huck <cohuck@redhat.com> >> Sent: Wednesday, March 22, 2023 11:21 AM >> >> On Wed, Mar 22 2023, Heng Qi <hengqi@linux.alibaba.com> wrote: >> >> > +The driver MUST NOT set \field{vqn} to any value other than an enabled >> transmit or receive virtqueue number. >> > Why do you suggest a negative statement here? > How is it better than, > The driver MUST set ... So make it "The driver MUST set \field{vqn} to the virtqueue number of an enabled transmit or receive virtqueue." ? Although I find this slightly less compelling than "do not set vqn to anything else". > > The device will anyway have to check and apply the parameter to the right virtqueue. > And if the vq is not enabled or vq is not tx or rx vq, it needs to fail the command. Well, I think we want to avoid having to add a normative statement for the device, so we need to be strict with what the driver is allowed to do. > >> "than the virtqueue number of an enabled transmit or receive virtqueue" >> >> might be better -- what do others think? >> >> Otherwise, LGTM. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com> To: Parav Pandit <parav@nvidia.com>, Heng Qi <hengqi@linux.alibaba.com>, "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>, "virtio-comment@lists.oasis-open.org" <virtio-comment@lists.oasis-open.org> Cc: "Michael S . Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Alvaro Karsz <alvaro.karsz@solid-run.com>, David Edmondson <david.edmondson@oracle.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com> Subject: [virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation Date: Wed, 22 Mar 2023 17:36:39 +0100 [thread overview] Message-ID: <87pm90hhew.fsf@redhat.com> (raw) In-Reply-To: <PH0PR12MB5481FCF22C47F2D23E6638E2DC869@PH0PR12MB5481.namprd12.prod.outlook.com> On Wed, Mar 22 2023, Parav Pandit <parav@nvidia.com> wrote: >> From: Cornelia Huck <cohuck@redhat.com> >> Sent: Wednesday, March 22, 2023 11:21 AM >> >> On Wed, Mar 22 2023, Heng Qi <hengqi@linux.alibaba.com> wrote: >> >> > +The driver MUST NOT set \field{vqn} to any value other than an enabled >> transmit or receive virtqueue number. >> > Why do you suggest a negative statement here? > How is it better than, > The driver MUST set ... So make it "The driver MUST set \field{vqn} to the virtqueue number of an enabled transmit or receive virtqueue." ? Although I find this slightly less compelling than "do not set vqn to anything else". > > The device will anyway have to check and apply the parameter to the right virtqueue. > And if the vq is not enabled or vq is not tx or rx vq, it needs to fail the command. Well, I think we want to avoid having to add a normative statement for the device, so we need to be strict with what the driver is allowed to do. > >> "than the virtqueue number of an enabled transmit or receive virtqueue" >> >> might be better -- what do others think? >> >> Otherwise, LGTM. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-03-22 16:36 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-22 12:51 [virtio-dev] [PATCH v13] virtio-net: support the virtqueue coalescing moderation Heng Qi 2023-03-22 12:51 ` [virtio-comment] " Heng Qi 2023-03-22 15:20 ` [virtio-dev] " Cornelia Huck 2023-03-22 15:20 ` [virtio-comment] " Cornelia Huck 2023-03-22 16:23 ` [virtio-dev] " Parav Pandit 2023-03-22 16:23 ` [virtio-comment] " Parav Pandit 2023-03-22 16:36 ` Cornelia Huck [this message] 2023-03-22 16:36 ` Cornelia Huck 2023-03-22 16:40 ` [virtio-dev] " Parav Pandit 2023-03-22 16:40 ` [virtio-comment] " Parav Pandit 2023-03-22 16:44 ` [virtio-dev] " Cornelia Huck 2023-03-22 16:44 ` Cornelia Huck 2023-03-22 16:46 ` [virtio-dev] " Parav Pandit 2023-03-22 16:46 ` Parav Pandit 2023-03-22 16:50 ` [virtio-dev] " Michael S. Tsirkin 2023-03-22 16:50 ` Michael S. Tsirkin 2023-03-22 16:46 ` [virtio-dev] " Michael S. Tsirkin 2023-03-22 16:46 ` Michael S. Tsirkin 2023-03-22 16:49 ` [virtio-dev] " Parav Pandit 2023-03-22 16:49 ` Parav Pandit 2023-03-22 16:53 ` [virtio-dev] " Michael S. Tsirkin 2023-03-22 16:53 ` Michael S. Tsirkin 2023-03-22 17:02 ` [virtio-dev] " Parav Pandit 2023-03-22 17:02 ` Parav Pandit 2023-03-23 2:26 ` [virtio-dev] " Heng Qi 2023-03-23 2:26 ` [virtio-comment] " Heng Qi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87pm90hhew.fsf@redhat.com \ --to=cohuck@redhat.com \ --cc=alvaro.karsz@solid-run.com \ --cc=david.edmondson@oracle.com \ --cc=hengqi@linux.alibaba.com \ --cc=jasowang@redhat.com \ --cc=mst@redhat.com \ --cc=parav@nvidia.com \ --cc=virtio-comment@lists.oasis-open.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=xuanzhuo@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.