Re: [PATCH v1 00/10] Apple M1 Pro/Max/Ultra device trees

From: Marc Zyngier <maz@kernel.org>
To: Janne Grunau <j@jannau.net>
Cc: asahi@lists.linux.dev, "Mark Kettenis" <kettenis@openbsd.org>,
	"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
	"Hector Martin" <marcan@marcan.st>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Martin Povišer" <povik+lin@cutebit.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sven Peter" <sven@svenpeter.dev>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Vinod Koul" <vkoul@kernel.org>,
	devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 00/10] Apple M1 Pro/Max/Ultra device trees
Date: Sat, 17 Sep 2022 10:17:19 +0100	[thread overview]
Message-ID: <87pmful5r4.wl-maz@kernel.org> (raw)
In-Reply-To: <20220916142550.269905-1-j@jannau.net>

On Fri, 16 Sep 2022 15:25:40 +0100,
Janne Grunau <j@jannau.net> wrote:
> 
> Hej,
> 
> this series contains device trees for Apple's M1 Pro, Max and Ultra SoCs
> and devices based on these SoCs.
> 
> Quoting from the main commit:
> 
> | These SoCs are found in Apple devices with M1 Pro (t6000), M1 Max
> | (t6001) and M1 Ultra (t6002).
> |
> | t6000 is a cut-down version of t6001, so the former just includes the
> | latter and disables the missing bits (This is currently just one PMGR
> | node and all of its domains.
> |
> | t6002 is two connected t6001 dies. The implementation seems to use
> | t6001 with blocks disabled (mostly on the second die). MMIO addresses on
> | the second die have a constant offset. The interrupt controller is
> | multi-die aware. This setup can be represented in the device tree with
> | two top level "soc" nodes. The MMIO offset is applied via "ranges" and
> | devices are included with preproceesor macros to make the node labels
> | unique and to specify the die number for the interrupt definition.
> |
> | Device nodes are distributed over dtsi files based on whether they are
> | present on both dies or just on the first die. The only execption is the
> | NVMe controller which resides on the second die. Its nodes are in a
> | separate file.
> 
> This series depends for full functionality on t600x dart support (latest
> version at
> https://lore.kernel.org/linux-iommu/20220916094152.87137-1-j@jannau.net/T/#t
> expected to be picked up for 6.1). This is the usual device tree /
> driver changes runtime dependency.
> 
> Even with the t6000-dart support t600x devices are not terribly useful
> in upstream. There is no input device support. The laptop's keyboard
> and touchpad are missing SPI and HID over SPI drivers. The dwc3
> USB-C ports are not yet added since they require special handling
> after disconnect. The PCIe based USB xhci controller in the Mac Studio
> requires firmware downloaded in a similar way as USB_XHCI_PCI_RENESAS.
> 
> To simplify dependency handling this series carries mostly identical
> device tree additions for M1 and M1 Pro/Max/Ultra as part of the in
> development audio support.
> 
> The series passes dtbs_check with 3 additional dt bindings changes:
> - "dt-bindings: apple,aic: Fix required item "apple,fiq-index" in
>   affinity description" (merged as da3b1c294d47 in Linus' repo)
> - "ASoC: Add Apple MCA I2S transceiver bindings" (6ed462d1c11675)
>   in sound/for-next
> - "dt-bindings: iommu: dart: add t6000 compatible"
>   https://lore.kernel.org/linux-iommu/20220901012519.7167-2-j@jannau.net/
> 
> New bindings passes dt_binding_check.

For the whole series:

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.