All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: apple: t8103: Remove PCIe max-link-speed properties
@ 2021-12-07  5:34 Hector Martin
  2021-12-07  9:29 ` Marc Zyngier
  0 siblings, 1 reply; 2+ messages in thread
From: Hector Martin @ 2021-12-07  5:34 UTC (permalink / raw)
  To: Marc Zyngier, Sven Peter
  Cc: Alyssa Rosenzweig, Rob Herring, linux-pci, linux-kernel, Hector Martin

The driver doesn't support these, they shouldn't be in the SoC include
anyway, and we're now configuring this in the bootloader instead. This
also solves the j274 1G/10G Ethernet variant discrepancy, since that
will now be configured properly based on the dynamic ADT property.

Signed-off-by: Hector Martin <marcan@marcan.st>
---
 arch/arm64/boot/dts/apple/t8103.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
index 15ee8c8c5fa0..8d1628e0b0c7 100644
--- a/arch/arm64/boot/dts/apple/t8103.dtsi
+++ b/arch/arm64/boot/dts/apple/t8103.dtsi
@@ -412,7 +412,6 @@ port00: pci@0,0 {
 				device_type = "pci";
 				reg = <0x0 0x0 0x0 0x0 0x0>;
 				reset-gpios = <&pinctrl_ap 152 0>;
-				max-link-speed = <2>;
 
 				#address-cells = <3>;
 				#size-cells = <2>;
@@ -432,7 +431,6 @@ port01: pci@1,0 {
 				device_type = "pci";
 				reg = <0x800 0x0 0x0 0x0 0x0>;
 				reset-gpios = <&pinctrl_ap 153 0>;
-				max-link-speed = <2>;
 
 				#address-cells = <3>;
 				#size-cells = <2>;
@@ -452,7 +450,6 @@ port02: pci@2,0 {
 				device_type = "pci";
 				reg = <0x1000 0x0 0x0 0x0 0x0>;
 				reset-gpios = <&pinctrl_ap 33 0>;
-				max-link-speed = <1>;
 
 				#address-cells = <3>;
 				#size-cells = <2>;
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: apple: t8103: Remove PCIe max-link-speed properties
  2021-12-07  5:34 [PATCH] arm64: dts: apple: t8103: Remove PCIe max-link-speed properties Hector Martin
@ 2021-12-07  9:29 ` Marc Zyngier
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2021-12-07  9:29 UTC (permalink / raw)
  To: Hector Martin
  Cc: Sven Peter, Alyssa Rosenzweig, Rob Herring, linux-pci, linux-kernel

On Tue, 07 Dec 2021 05:34:58 +0000,
Hector Martin <marcan@marcan.st> wrote:
> 
> The driver doesn't support these, they shouldn't be in the SoC include
> anyway, and we're now configuring this in the bootloader instead. This
> also solves the j274 1G/10G Ethernet variant discrepancy, since that
> will now be configured properly based on the dynamic ADT property.
> 
> Signed-off-by: Hector Martin <marcan@marcan.st>

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-07  9:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-07  5:34 [PATCH] arm64: dts: apple: t8103: Remove PCIe max-link-speed properties Hector Martin
2021-12-07  9:29 ` Marc Zyngier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.